Katana_mirror/kdelibs
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kdelibs.git synced 2025-02-24 02:42:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
5469 commits 3 branches 0 tags 36 MiB
Commit graph

1059 commits

Author SHA1 Message Date
Ivailo Monev
5f8a5ca497 kio: replace KFileItemPrivate::user() and KFileItemPrivate::group() with their body 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-28 09:31:57 +03:00
Ivailo Monev
4f2ec79294 kio: remove redundant key checks in KFileItemActions::addServiceActionsTo() 
neither X-KDE-ShowIfRunning nor X-KDE-ShowIfDBusCall is used, not
registered properties either

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-27 21:50:38 +03:00
Ivailo Monev
98b927aef3 kio: remove unused X-KDE-CfgDlgHierarchy property 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-27 21:45:42 +03:00
Ivailo Monev
ffd78c2bdb kio: testing build fix 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-27 21:37:08 +03:00
Ivailo Monev
8e76e09b00 kio: KFileItem::permissionsString() optimization 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-27 20:59:43 +03:00
Ivailo Monev
95e5af4190 kio: remove unused KFileItem methods 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-27 20:41:03 +03:00
Ivailo Monev
e88a8bd627 kio: do not cache the name in lower case from KFileItem::name() 
case-insensitive comparison is faster and is already done by
KDirSortFilterProxyModel

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-27 20:08:38 +03:00
Ivailo Monev
8e1a9cfec7 kio: use KPixmapWidget instead of QLabel in KIO::RenameDialog 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-27 19:53:52 +03:00
Ivailo Monev
c5d63044f5 kio: merge KFileItem::refreshMimeType() into KFileItem::refresh() 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-27 19:05:17 +03:00
Ivailo Monev
edbdb6dfbe kio: drop redundant KFileItem constructors and arguments 
never set to anything other than empty QString or KFileItem::Unknown

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-27 18:26:44 +03:00
Ivailo Monev
b2a8af5dd6 kio: drop the boolean argument of KFileItem constructor 
the argument name is so misleading, why is that? I did not name it..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-27 17:51:43 +03:00
Ivailo Monev
825763d73f kio: drop the feature to delay MIME type determination 
it shall be delayed without the feature (which it was anyway)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-27 17:10:04 +03:00
Ivailo Monev
07b318f9ac kio: remove redundant private method 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-24 21:25:55 +03:00
Ivailo Monev
75cf57aac5 kio: drop support for "most local URL" 
was used by some slaves (e.g. the archive slave which is no more).

lets see if you can find it jira:
https://ivailo-monev.atlassian.net/browse/KDE-12

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-24 20:46:17 +03:00
Ivailo Monev
b5b1741ca5 kio: correct logic for hiding user name in KIO::SlaveBase::openPasswordDialog() 
that nasty operator not..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-21 17:12:52 +03:00
Ivailo Monev
a224bab20c kdeui: drop the domain feature of KPasswordDialog 
editing the domain does not make sense, showing domain can be done via
comment (the complete URL is shown via comment by the KIO curl slave for
example)

note the change to KIO::AuthInfo, this invalidates stored data

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-18 23:17:35 +03:00
Ivailo Monev
2983df9818 kio: properly initialize KIO::AuthInfo members 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-18 22:33:21 +03:00
Ivailo Monev
f0dd6c73f5 kio: check cache only if the password store is not open from KIO::SlaveBase::openPasswordDialog() 
if the password store is open and KIO::SlaveBase::openPasswordDialog() is
called then the password from the cache is not valid

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-18 11:02:26 +03:00
Ivailo Monev
42f9a2162c kio: remove unused headers inclusions 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-18 11:01:17 +03:00
Ivailo Monev
03e6b05f68 kio: use members for extra KIO::AuthInfo fields 
because streaming a map of QVariants is not exactly optimal, members remain
undocumented but refer to KPasswordDialog flags and such anyway

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-18 10:56:23 +03:00
Ivailo Monev
11b5a43a53 kio: MOC warning fix 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-17 08:14:42 +03:00
Ivailo Monev
3ebc020de4 kio: remove methods that are not implemented 
the compiler is supposed to catch such errors (e.g. wrong type passed to
the method)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-17 07:46:17 +03:00
Ivailo Monev
8c8855d9a6 generic: drop temporary file option 
any program launched with temporary file (as per the spec) argument
(because it does not support %u or %U) should not be responsible for
deleting the file, klauncher already handles that thus the option is
redundant. I don't know how other implemenatations (of program launchers)
do it but I cannot say I care either

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-16 01:37:20 +03:00
Ivailo Monev
381ab0a324 kio: wake up the slave before terminating it 
otherwise (apparently) sending SIGTERM is not doing anything

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-14 11:54:19 +03:00
Ivailo Monev
9530356389 kio: use smaller type for sending KIO::JobUiDelegate::MessageBoxType type 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-14 09:02:23 +03:00
Ivailo Monev
e4ce49f138 kio: use the macro for sending data in KIO::SlaveInterface::setConfig() 
no functional change

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-14 08:58:36 +03:00
Ivailo Monev
24336de9b9 kio: KIO::NetAccess review 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-13 23:25:10 +03:00
Ivailo Monev
7f261aca95 kdecore: new KTemporaryFile::urlPath() method 
based on the bits in kparts/part.cpp

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-13 22:52:30 +03:00
Ivailo Monev
75eeefb652 kio: format and indent 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-13 08:50:41 +03:00
Ivailo Monev
c40e6014ce kio: preserve the extension from KIO::NetAccess::download() 
it was done by kioexec which KRun was using but now everything that uses
KIO::NetAccess::download() benefits from better MIME type detection (e.g.
inkscape used to fail to detect the image format because the temporary file
was lacking extension)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-13 08:30:31 +03:00
Ivailo Monev
cfceb37f62 kio: log debug messages when terminal or kdesudo is not found 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-13 07:53:16 +03:00
Ivailo Monev
292b85fb94 kio: rename KRun::isExecutable() argument 
it is not service type, is it?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-13 07:51:10 +03:00
Ivailo Monev
2ab6930a94 kio: KRun documentation review 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-13 07:44:48 +03:00
Ivailo Monev
bc9f3cf339 kinit: download remote URLs for services lacking support for such 
now klauncher has all required features (by the spec) and then some

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-13 07:32:39 +03:00
Ivailo Monev
3fb2096129 kio: remove redundant KDesktopFileActions::userDefinedServices() overload 
there is one convenience overload already

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-13 06:14:23 +03:00
Ivailo Monev
0364baa81f kio: remove unused KDesktopFileActions::userDefinedServices() argument 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-13 05:53:13 +03:00
Ivailo Monev
85cf5851bd kio: handle terminal and UID substitution options in KRun::processDesktopExec() 
much like the old implementation except that empty QStringList is returned
if either terminal or kdesudo is required but not found, ideally errors
should be reported by klauncher when that is the case

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 21:53:27 +03:00
Ivailo Monev
bd3345543d kio: reuse variable in KFilePropsPlugin 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 22:45:15 +03:00
Ivailo Monev
3c96458087 kio: rework KRun::processDesktopExec() to account for empty list of URLs and not join the URLs into single argument 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 18:28:08 +03:00
Ivailo Monev
ae72f73768 kdeui: simplify KToolInvocation::invokeMailer() 
thunderbird for one accepts a single URL (which probably is split into bits
and checked for query items). it does not have "t", "s", etc. placeholders
in its .desktop file so that whole map thing is not really working well

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 15:04:52 +03:00
Ivailo Monev
779f3b5635 kio: update placeholders references in KOpenWithDialog 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 14:44:36 +03:00
Ivailo Monev
25d81b76b9 kio: slightly better exec extraction in KOpenWithDialog 
the matching could try basename and possibly second argument match tho,
e.g. the Exec key value could be relative or full path and interpreter may
be the first argument with the actual program (or script rather) second
making the matching kinda hard to get right

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 14:40:26 +03:00
Ivailo Monev
aee3b7b3da kio: log debug messages to a valid debug area 
250 is not a registered one

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 14:25:51 +03:00
Ivailo Monev
06cafdba67 kio: default to the locale encoding in KIO::SlaveBase 
as is done in KIO::Scheduler

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 12:45:30 +03:00
Ivailo Monev
6af1008bc5 kio: kill slaves from KIO::Scheduler destructor 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 09:13:21 +03:00
Ivailo Monev
45324eac58 kio: show stat() progress after 3 seconds for remote files 
the magic of timers! continue from 5ae8fe637e

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 08:34:43 +03:00
Ivailo Monev
5ae8fe637e kio: hide of progress of stat() jobs done by KIO::NetAccess 
now that stat() is used for MIME type determination it is used in lots of
places and progress should not be shown more often than it should

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 07:20:35 +03:00
Ivailo Monev
dfd76bcd04 kio: remove the job from the queue and unlock the mutex on failure to create the slave 
if the mutex is not unlocked deadlock occurs, if the job is not removed
from the queue it will be attempted to start it again

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 06:10:08 +03:00
Ivailo Monev
5f43d4a86c kio: KRun documentation update 
other misc changes were made while at it, .gitexcludes had executable
bit set..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 05:50:57 +03:00
Ivailo Monev
1a29d6bb3b kio: check if the URL is directory before checking permissions in KRun::isExecutableFile() 
as the KRun::isExecutableFile() method name implies - it is only for
checking files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2024-05-12 04:26:15 +03:00