Commit graph

3359 commits

Author SHA1 Message Date
Ivailo Monev
49c47bf850 kdeui: add comments about values passed to X11 functions in kpixmap source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 01:52:33 +02:00
Ivailo Monev
28ae883aeb kdeui: KPixmap from QPixmap constructor optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 01:40:39 +02:00
Ivailo Monev
b9169a25a5 kdeui: KPixmap::toImage() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 01:10:33 +02:00
Ivailo Monev
a4c80f09d2 kdeui: log KPixmap and KSelectionOwner debug/warning messages to the kdeui (kdelibs) debug area
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 02:28:14 +02:00
Ivailo Monev
a5734faf0f kdeui: new KPixmap class
very much written for use case, not to make sense. while porting to it I
already noticed there are leaks for X11 pixmaps and may have to write
glue code to keep track of the pixmaps and release them before
application quits, that will be a huge performance penalty tho so may
have to be ifdef'ed for debug builds only

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 02:08:27 +02:00
Ivailo Monev
43cf97b00d kdeui: unexport KdeUiProxyStyle
not used outside kdeui library

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-08 19:30:37 +02:00
Ivailo Monev
38cc86db41 plasma: export DialogShadows class
there are 3 copies of the sources for that class because it is not
exported (one here, one in kde-workspace and one in kde-extraapps) with
one class that is very similar to it - PanelShadows (in kde-workspace
repo, part of plasmagenericshell library)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-07 18:05:11 +02:00
Ivailo Monev
6b7cd4e1e4 kdeui: remove redundant selection clearing in KSelectionOwner::release()
if both the destroy and selection clearing are delivered (in that order) to
selection poller, the poller selection may be cleared

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 11:27:11 +02:00
Ivailo Monev
e07fc01227 kdecore: return the value of KGlobal::hasLocale() from KDETranslator::isEmpty() and check it from KDETranslator::translate()
fixes possible crash due to accessing the private KLocale data after
destruction

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 10:10:46 +02:00
Ivailo Monev
7baf0c9d61 kdeui: catch X11 errors during selection owner window creation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 08:14:33 +02:00
Ivailo Monev
081477c628 kdeui: do not attempt to kill timer with 0 as ID in KSelectionOwner::release()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 08:05:15 +02:00
Ivailo Monev
cdc18e2e52 kdeui: remove unused QTimer header inclusion in kselectionowner source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 06:12:58 +02:00
Ivailo Monev
a6367dede7 kdeui: brief KSelectionOwner documentation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 06:12:37 +02:00
Ivailo Monev
491dc6383a kdeui: simplify selection claiming
using XSetSelectionOwner() to do it works like a charm

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 20:11:20 +02:00
Ivailo Monev
7f3719e3c0 kdeui: make KSelectionOwner::claim() and KSelectionOwner::release() public slots
now they can be connected to signals such as QCoreApplication::aboutToQuit()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 17:17:05 +02:00
Ivailo Monev
a6165ed19b kdeui: simplify selection window creation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 16:58:35 +02:00
Ivailo Monev
d88d74f0c9 plasma: remove unused header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 12:56:51 +02:00
Ivailo Monev
554751c76e kdeui: use timer event for ownership check in KSelectionOwner
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 12:24:51 +02:00
Ivailo Monev
6b7c8d12bb kdeui: catch X11 errors in KSelectionOwner::_checkOwnership()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 11:14:15 +02:00
Ivailo Monev
75e94cc39f kdeui: send SelectionClear X11 event first, then destroy the window if that does not work
destroying the window works for KWin but not for Openbox for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 10:52:13 +02:00
Ivailo Monev
c2a98d4c5d kdeui: KSelectionOwner rewrite
natural selection - kill or be killed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 12:44:07 +02:00
Ivailo Monev
d37ea70af9 plasma: remove redundant connection to QCoreApplication::aboutTOQuit() signal
at the point where the application is about to exit it is not safe to even
access the global static (by calling Plasma::Theme::defaultTheme()) since
it will be deleted

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 04:22:58 +02:00
Ivailo Monev
2b2ac283e8 kio: move metadata plugin keys to the .desktop files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 14:40:57 +02:00
Ivailo Monev
1e982a7e2d kio: move metadata plugin MIME types to the .desktop files
ideally, the keys would also be stored in the .desktop files so that
plugin instances would not have to be created from
KFileMetaInfo::supportedKeys() too

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 13:59:00 +02:00
Ivailo Monev
3a6ed6d1e1 kdecore: KDirWatch::addDir() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 11:12:13 +02:00
Ivailo Monev
134d90ee06 kdecore: remove unused custom autostart path
the XDG path is be used instead, the custom autostart path was for programs
and scripts which is not feature mentioned in the spec

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 09:54:48 +02:00
Ivailo Monev
74cbd4de8d kdecore: do not attempt to load empty data into QTranslator
fixes runtime warning about empty data for invalid catalogs (e.g. when
translations are not installed either for the language requested or at all)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 04:21:39 +02:00
Ivailo Monev
2178afec68 kded: do not send notification to ksplash
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 11:36:22 +02:00
Ivailo Monev
642042c30e kdeui: default to Oxygen_White as cursor theme
same default as the one in startkde script

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 10:37:03 +02:00
Ivailo Monev
9937b5e854 kinit: remove the feature to start programs specified in kdeinit4 argument
the goal is to make kdeinit4 do only startup, i.e. XDG-like startup and
KCM modules initialization (which currently kcminit does). klauncher
(which is part of kdeinit4 still) shall be responsible for programs and
KIO slaves only

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 10:18:15 +02:00
Ivailo Monev
4a371cc21e Revert "kdeui: remove bogus --kdeinit argument passing from KCrash::defaultCrashHandler()"
This reverts commit a375907865.
2022-11-03 09:54:41 +02:00
Ivailo Monev
75c23a2bb8 kdeui: check if kapp pointer is valid in KSelectionOwner destructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 08:34:44 +02:00
Ivailo Monev
95847bfd2c kdeui: initialize static KApplication variables
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 08:01:08 +02:00
Ivailo Monev
6377634ce2 kdeui: remove KSelectionOwner from the KApplication X11 event filters in its destructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 07:53:29 +02:00
Ivailo Monev
b3844e6958 kdeui: deep-copy the event filters list in KApplication::x11EventFilter()
fixes possible KWin crash on exit (does not happen always)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 07:00:18 +02:00
Ivailo Monev
31c3c80b35 kdecore: add entry for the default debug area to kdebug.areas
now it will be configurable via KCM

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 04:23:47 +02:00
Ivailo Monev
dbb4526272 kdeui: apply cursor theme from KGlobalSettings::activate()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 01:55:59 +02:00
Ivailo Monev
889ae8d00f kdeui: simplify code for cursor theme setup
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 01:52:02 +02:00
Ivailo Monev
1af12047e6 kdecore: remove unused KLocalizedString semantics
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 01:06:07 +02:00
Ivailo Monev
8d9978f7e5 kdecore: remove unused KLocalizedString semantics
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 00:47:26 +02:00
Ivailo Monev
169e338449 kdecore: convert KuitFormats functions to static
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 02:37:11 +02:00
Ivailo Monev
bb9979b108 kutils: plug KExiv2 memory leaks
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-02 12:15:09 +02:00
Ivailo Monev
b8b37e01a3 kdecore: actually install the KDETranslator
was non-operational code due to QT_NO_TRANSLATION being defined in the
kglobal source file for some reason, it has a huge impact on performance
ofcourse because anything Katie will attempt to translate will go trough it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-02 11:02:51 +02:00
Ivailo Monev
95ee157d51 kdecore: undeprecate raw string translation methods
the catalog name argument is unused, KCatalog should be public if
translation from specific catalog is required

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-02 08:48:28 +02:00
Ivailo Monev
4afeec1725 kdecore: do not copy the catalogs list in KLocalePrivate::translateRawFrom()
the global KLocale mutex is locked in that method

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-02 07:08:04 +02:00
Ivailo Monev
881b47b8ea kdecore: use the Katie translations format
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-02 05:42:59 +02:00
Ivailo Monev
a7fc6cd735 kinit: rename exec command definitions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-01 08:55:13 +02:00
Ivailo Monev
5da95ad0f9 kinit: remove unused LAUNCHER_EXEC command
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-01 08:47:22 +02:00
Ivailo Monev
a375907865 kdeui: remove bogus --kdeinit argument passing from KCrash::defaultCrashHandler()
it was ment for kdeinit wrappers but they do not supports such argument

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-01 08:18:29 +02:00
Ivailo Monev
4d2b877aaf kinit: remove code for always false condition
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-01 08:14:00 +02:00