Commit graph

3363 commits

Author SHA1 Message Date
Ivailo Monev
4bd5d6b609 kimgio: cast the character to uchar and return EOF on error from RAWDataStream::get_char()
note that LibRaw_buffer_datastream returns -1 if the position is
out-of-bounds but https://www.gnu.org/software/libc/manual/html_node/EOF-and-Errors.html
claims that EOF may not be -1

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 08:33:14 +03:00
Ivailo Monev
37217b7fe7 kimgio: warn if seeking fails in RAWDataStream::seek()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-25 18:53:56 +03:00
Ivailo Monev
a2ae8fe7f4 kutils: warn that attachements are not implemented
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-25 02:32:41 +03:00
Ivailo Monev
59f42738c2 kimgio: const-ify RAWDataStream member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-25 02:30:43 +03:00
Ivailo Monev
5c9b183447 kimgio: use custom datastream class in raw plugin
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-25 03:12:45 +03:00
Ivailo Monev
efea5fade2 kutils: implement SSL option for KEMail
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 20:52:30 +03:00
Ivailo Monev
4af17bbebf kutils: check curl_easy_setopt() return values in KEMail::send()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 19:49:18 +03:00
Ivailo Monev
b403cadd86 plasma: wallpaper cache lookup optimization
QFile::exists() uses temporary QFileInfo object that does the same

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 19:03:45 +03:00
Ivailo Monev
d4ac838463 plasma: return if the X11 property is deleted in Plasma::WindowEffects::highlightWindows()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:39:43 +03:00
Ivailo Monev
b0b9fb8fce plasma: remove redundant computations and checks in Plasma::WindowEffects functions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:37:05 +03:00
Ivailo Monev
35cb26227d plasma: use specialized QImage constructor instead of constructing and loading
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:31:40 +03:00
Ivailo Monev
1b15162b50 plasma: deal with TODO related to moving Plasma::Wallpaper member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:27:49 +03:00
Ivailo Monev
f34d660dbb plasma: automatic MOC-ing warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:26:01 +03:00
Ivailo Monev
55e7b76bd0 kio: fix regression since 704ef230d5
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 17:46:10 +03:00
Ivailo Monev
4e933b8cc8 kdecore: check if KDebug mutex is destroyed before using it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 17:34:08 +03:00
Ivailo Monev
76ffb428ee kio: add timeout timer to the KDirLister test
fixes possible test hang

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 17:20:51 +03:00
Ivailo Monev
c392733865 kutils: compiler warnings fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 16:54:31 +03:00
Ivailo Monev
0ef6ec5e26 kdecore: verify that there are no multiple occurrences of X character in KTemporaryFile test case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 16:43:37 +03:00
Ivailo Monev
9c3d435eab kdecore: compiler warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 16:41:31 +03:00
Ivailo Monev
6bee91f902 kdecore: compiler warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 16:35:29 +03:00
Ivailo Monev
78b1c9af08 kdecore: minor KDebug documentation review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 05:53:46 +03:00
Ivailo Monev
d33ed63e8f kdecore: cache debug area preferences on demand
most programs use 5-15 areas and if kdebugrc contains preferences for many
areas the initial caching process would take a lot of time

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 05:34:21 +03:00
Ivailo Monev
054f2fc7e7 kdecore: deal with TODO related to KDebug
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 03:28:52 +03:00
Ivailo Monev
a1a03f11a0 kdecore: do not add timestamp to header when the output type is syslog
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 02:54:54 +03:00
Ivailo Monev
70b7bb978d kdecore: use red color for both critical and fatal message type but make the fatal blink
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 05:23:42 +03:00
Ivailo Monev
612b956ada kdecore: KDebug documentation review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 04:28:25 +03:00
Ivailo Monev
2e69366e51 kdecore: KTemporaryFile documentation correction
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 04:05:13 +03:00
Ivailo Monev
f433324deb kdecore: KDebug review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 04:04:57 +03:00
Ivailo Monev
6d54fcbe94 kdecore: simplify and unexport KDebug internals
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 00:33:05 +03:00
Ivailo Monev
b45b5344b2 kdecore: cache KDebug devices based on area and output type
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 00:59:46 +03:00
Ivailo Monev
d1217860f4 kdecore: PCI IDs database update
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 23:43:49 +03:00
Ivailo Monev
0a13898dad kdecore: kdebugrc documentation update
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 20:23:50 +03:00
Ivailo Monev
22463b6895 kdecore: cache KDebug area preferences
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 20:11:28 +03:00
Ivailo Monev
a2ed707470 kdecore: oops, fix build of KTempDir test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 20:09:23 +03:00
Ivailo Monev
65e8d1dfe3 kdecore: open and close the system log for each message
sub-optimal but recommended in glibc/manual/syslog.texi for shared
libraries, there is also the case of multiple KDebugSyslogDevice opening
the system log more than once per-program

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 19:29:58 +03:00
Ivailo Monev
b287467137 kdecore: do not prepend the temporary directory and main component name if template is absolute path from KTemporaryFile::filePath()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 18:05:15 +03:00
Ivailo Monev
8224768f2a kdecore: print debug messages of shell type to stderr too
for program that outputs something to stdout and other program reads it,
don't want programs to read debug messages

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 07:10:52 +03:00
Ivailo Monev
e67ecffaac kdecore: log important classes warning, error and fatal messages in the system log
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 07:06:43 +03:00
Ivailo Monev
d834ef9e19 kdecore: fix writing of warning messages to file and test case it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 06:44:30 +03:00
Ivailo Monev
35fa149bc0 kdecore: copyrighting KDebug to me
if I rewrite kBacktrace() there is nothing left not coded by me there, I
wrote backtrace printer for Katie with symbols demangling btw

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 05:51:54 +03:00
Ivailo Monev
6403e15075 kdecore: minor KDebug review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 05:46:59 +03:00
Ivailo Monev
271b1a0588 kdecore: print colorized messages that are not of debug type to stderr
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 03:39:26 +03:00
Ivailo Monev
960461d7ce kdecore: destroy devices and reset environment variable caches from kClearDebugConfig()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 03:36:59 +03:00
Ivailo Monev
04c84dfbc1 kdecore: implement KDE_DEBUG_COLOR for KDebug
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 02:53:46 +03:00
Ivailo Monev
f3905e1760 kdecore: implement KDE_DEBUG_METHODNAME for KDebug
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 02:04:33 +03:00
Ivailo Monev
db036cd4ee kdecore: adjust KLockFile test to KDebug changes
KDebug no longer proxies messages designated for the shell to the Katie
message handler because the Katie message handler has its own abort logic,
e.g. if QT_FATAL_WARNINGS is not empty or the message type is fatal abort()
would be called

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 01:28:37 +03:00
Ivailo Monev
8a224de2f4 kdecore: test kWarning(), kError() and kFatal() in KDebug test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 01:20:44 +03:00
Ivailo Monev
04a111969a kdecore: flush the file stream after printing to it from KDebugShellDevice
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 01:20:15 +03:00
Ivailo Monev
930c5af97c kdecore: unexport internal kDebugDevNull() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 00:17:22 +03:00
Ivailo Monev
e9a1dfb0bc kdecore: update kdebug.areas
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 00:11:23 +03:00