Commit graph

66 commits

Author SHA1 Message Date
Ivailo Monev
c29db4dd9c kdeui: remove toolbar directory from appicon resource
no icons are installed there

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-27 16:53:34 +03:00
Ivailo Monev
dc208c52fd generic: update references to shared data directory
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-18 00:20:22 +03:00
Ivailo Monev
11ddbf175a kdeui: minor KIconLoader optimizations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 22:31:39 +03:00
Ivailo Monev
d032a0ed6d kdeui: move KIconLoader::Type enums to KIconThemeDir
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 21:42:15 +03:00
Ivailo Monev
c552f4bb86 kdeui: get rid of K3Icon
the information it holds is not used anywhere, bonus points for
optimizing the icons lookup

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 21:16:45 +03:00
Ivailo Monev
25336bda89 kdeui: mark KIconEngine reimplementations as final
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 20:18:00 +03:00
Ivailo Monev
fe93b26370 kdeui: remove unused KIcon and K3Icon data pointer members
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 19:29:26 +03:00
Ivailo Monev
15252c920e kdeui: fix possible out-of-bounds in KIconEffect::apply() methods
e.g. if KIconLoader::NoGroup (-1) is passed as group

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 23:53:28 +03:00
Ivailo Monev
c2618febf9 kdeui: convert some KIconEffect::apply() methods to static
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 22:41:34 +03:00
Ivailo Monev
29bd64349f kdeui: do not use global static QString for the null effect fingerprint
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-20 01:00:02 +03:00
Ivailo Monev
ed4ebbe70e kdeui: remove unused KIconEffect::doublePixels() method
that's actually just scaling/transformation

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-20 00:49:00 +03:00
Ivailo Monev
4c7db025ff kdeui: someone's typos
why do KIconLoader methods take two size arguments overriding each other?
could've used negative values for KIconLoader::Group. I guess I will have
to fix someone's mess at some point

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-28 15:51:11 +02:00
Ivailo Monev
148110f398 generic: drop locolor support
`apt-file` search yeilds 221 files matching (8 packages provide such),
it is also unused by plasma even tho there are leftovers from support for it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-05 01:30:27 +02:00
Ivailo Monev
d37a7c4c6e kdeui: ensure the favicon has size suitable for overlay
with commit de8c7f6af1d79c6b3cd3e8b2a21a56a020163b73 (in kde-workspace) I
changed the behaviour of favicon KDED module to not down-scale the favicons
to 16x16 and that ofcourse means large favicons (e.g. 256x256, yes some
websites have favicon with such size) may be overlayed on top of 32x32 icon
which does not look OK.

with this change the icon overlay will match the visual ratio of any
other icon overlay, unfortunetly that means scaling the favicon (i.e. for
large icons such 256x256, favicon with size 16x16 may be up-scaled to 32x32
) but it will still look better than it used to

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 04:44:04 +02:00
Ivailo Monev
9b41127ecb generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 00:40:18 +02:00
Ivailo Monev
b63686e9d0 generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 04:43:56 +02:00
Ivailo Monev
803e38914d kdeui: include now required system limits header
was previously included by qcontiguouscache header

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-31 05:55:19 +02:00
Ivailo Monev
6cf96c3a87 kdeui: remove unused KAnimatedButton class and KIconLoader getters for movies
KIconLoader::loadMovie() and KIconLoader::moviePath() are attempting to
load non-standard .mng files which, as far as I am aware, no icon theme
ships. for reference:
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#context

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-28 17:56:47 +03:00
Ivailo Monev
e79637377e kdeui: remove hardcoded pixmaps directories and filter duplicate directories in KIconTheme
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-23 05:03:56 +03:00
Ivailo Monev
2431839ba0 kdeui: avoid temporary in KIconEffect::semiTransparent()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-21 02:04:08 +03:00
Ivailo Monev
4e192e5660 kdeui: remove checks for obsolete index.desktop icon theme files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-20 16:22:57 +03:00
Ivailo Monev
5b8b2af7c4 kdeui: remove code for images with depth equal to 8
indexed, Katie does not support such anymore

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-29 22:22:04 +03:00
Ivailo Monev
b6af68c97d generic: trim the lines when reading files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-29 14:09:07 +03:00
Ivailo Monev
6f34ee6809 generic: optimize reading from files
QTextStream uses internal buffer

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-29 10:54:57 +03:00
Ivailo Monev
eb3ea2e4b0 kdeui: remove duplicate QPixmap header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-28 14:45:13 +03:00
Ivailo Monev
926345627a generic: bump minimum Katie version requirement to 4.12.0
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 03:54:07 +03:00
Ivailo Monev
3422ca4413 generic: get rid of KGLobal::staticQString()
global statics are static objects and the method is using one

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-02-18 19:49:54 +02:00
Ivailo Monev
2ef0b94051 kdeui: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-12-22 08:39:39 +02:00
Ivailo Monev
b187d42601 kdeui: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-12-22 07:08:49 +02:00
Ivailo Monev
58efc0af13 generic: rename KIconEffect::shadowBlur() method and use it in Plasma::PaintUtils::shadowBlur()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-11-12 03:25:28 +02:00
Ivailo Monev
6509d1f533 kdeui: make shadow blur effect function public
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-11-11 06:28:04 +02:00
Ivailo Monev
409301e9d0 kdeui: ensure icon image used to paint overlay is in format supported by QPainter
fixes drawing of favourite icons in bookmarks runner

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-10-03 06:37:39 +03:00
Ivailo Monev
ea8fad680c generic: load SVG images as any other format
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-09-15 00:20:09 +03:00
Ivailo Monev
3b1c1d09a5 kdeui: move default switch case to bottom in qIconModeToKIconState() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-08-28 05:08:24 +03:00
Ivailo Monev
c809676fc1 kdeui: use Q_BYTE_ORDER to determine byte order
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-08-06 23:07:36 +03:00
Ivailo Monev
921e497471 generic: correct codec names in KMimeTypeRepository::parents() and KIconLoaderGlobalData::parseGenericIconsFiles()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-07-11 17:56:24 +03:00
Ivailo Monev
b24622f35d kdeui: use QDir::exists() to check for icon directory existence
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 04:01:04 +00:00
Ivailo Monev
956151a106 kdeui: let QCache decide the cost and when to trim
the problem is that even 128x128 pixmaps would trigger cache trim with the
w*h+1 formula because the max cost is set to 10240 and as noted in the
icon loaded source comments some applications use it to load icons with
size greater than that

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-28 16:44:55 +00:00
Ivailo Monev
4a0c21e15b kdeui: improve icon cache colisions check
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-28 16:18:45 +00:00
Ivailo Monev
d543f77e67 kdeui: clear the icon cache upon reconfigure/init
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-28 15:59:03 +00:00
Ivailo Monev
fdfa8de248 kdeui: optimize icon loader
pixmap data is explicity shared and there is no need to insert multiple
pixmaps with the same key into the cache

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-28 15:09:14 +00:00
Ivailo Monev
61333c4671 generic: namespaced Qt4/Katie build fixes
most of the changes were done trought Katie's namefsck script which
convertes forward class declarations to include directives, however
other fixes here and there were needed as well as some questionable
changes to Q_DECLARE_TYPEINFO() macro calls because they most likely
have to do the namespacing themselfs (QT_BEGIN/END_NAMESPACE, and
probably will be in Katie) meaning that some of the changes may be
temporary and reverted later.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2017-08-04 09:24:39 +00:00
Ivailo Monev
fbf3973d05 generic: replace QLatin1Literal with QLatin1String
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-10-30 02:26:10 +00:00
Ivailo Monev
1e3b872a26 generic: get rid of the QStringBuilder requirement
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-10-29 05:06:31 +00:00
Ivailo Monev
972baa3d86 kdeui: minor KIconLoader::iconPath() optimization
the benefit from QStringBuilder is better than the static QString access

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-16 05:57:05 +00:00
Ivailo Monev
a15eff9116 Revert "kdeui: ease identification of invalid icon groups"
note to self: this breaks the icons in systemsettings and requires
a bit more poking into the source than I've initially put into it

This reverts commit 170da9afc4.
2016-04-06 11:53:04 +00:00
Ivailo Monev
170da9afc4 kdeui: ease identification of invalid icon groups
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-05 12:37:36 +00:00
Ivailo Monev
c6f33f23aa generic: get rid of KImageCache and KSharedDataCache
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-05 03:48:27 +00:00
Ivailo Monev
ef15158907 kdeui: do not use disk storage for icon cache
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-05 00:50:42 +00:00
Ivailo Monev
14f89b73a3 kdeui: do not hardcode the pixmaps directory
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-02-12 20:53:00 +02:00