Commit graph

3688 commits

Author SHA1 Message Date
Ivailo Monev
fcdcbe612e kdecore: KAuthorization optimization
calling the stop() adaptor method instead of ping() and then stop() saves a
lot of D-Bus round-trips

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 11:34:53 +02:00
Ivailo Monev
0a67ba2ddd kdecore: partially revert 1bd459a073
dead-lock may happen if QStandardPaths (which KStandardDirs uses and
thus KDebug indirectly) warns about something

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 10:18:46 +01:00
Ivailo Monev
1bd459a073 kdecore: log KAuthorization messages to specialized area
that includes Katie messages

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 10:09:33 +02:00
Ivailo Monev
89177c0614 kdecore: KCharsets optimizations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 09:49:04 +02:00
Ivailo Monev
39f0466cac kdecore: convert the QString to QByteArray only once in KGlobalPrivate::initFakeComponent()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 09:40:37 +02:00
Ivailo Monev
65164ccd12 kdecore: KMimeTypeFactory::allMimeTypes() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 09:14:02 +02:00
Ivailo Monev
755337cd6b kdecore: remove unused and private KMimeTypeTrader member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 08:45:54 +02:00
Ivailo Monev
c22292b849 kdecore: disable copying of KServiceTypeTrader via Q_DISABLE_COPY() macro
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 08:08:06 +02:00
Ivailo Monev
b43da6504e kdecore: remove unused and private KServiceTypeTrader member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 08:06:53 +02:00
Ivailo Monev
110e53a48e plasma: remove unused X-Plasma-Args property
according to the chanages log (see kde-workspace/plasma/design/CHANGELOG-4.4)
it was used by the mediawiki runner which is no longer supported

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 07:32:35 +02:00
Ivailo Monev
34d87abfd8 kinit: new method for dumping the system environment
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-10 09:01:48 +02:00
Ivailo Monev
f82af797c3 kinit: require phase argument to be passed to autoStart method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-10 08:53:45 +02:00
Ivailo Monev
c8223bd24b kinit: store and reuse the converted environment in KLauncherAdaptor::exec_blind()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-10 01:47:45 +02:00
Ivailo Monev
922b4b44d1 kinit: do not insert empty environment variables into the klauncher environment
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-10 01:41:19 +02:00
Ivailo Monev
7cfcbc3775 kdeui: new KCrash::Backtrace to log backtraces
for programs that cannot call drkonqi to show backtrace (such as
ksmserver or any non-GUI D-Bus service)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 12:28:21 +02:00
Ivailo Monev
bdff3fa4e7 kdeui: log backtrace when no KCrash flags are set
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 12:17:48 +02:00
Ivailo Monev
6784f51d58 kdeui: tweak KNotificationManager and KGlobalAccel for automatic service activation
KGlobalAccelPrivate uses service watcher and the interface is invalid until
the service is activated (either by the first call of the interface or some
other lazy-initialization method), however KNotificationManager does
connect to signals immediately (which should work regardless) but the error
may have been logged before

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 12:00:23 +02:00
Ivailo Monev
a1951cfbae kdeui: reuse the already created interface in KGlobalAccelPrivate::getComponent()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 11:37:02 +02:00
Ivailo Monev
32dbecf2c6 kdeui: disable auto-restart when the application is about to quit
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 10:19:13 +02:00
Ivailo Monev
717fd59dc8 kdeui: send only SIGTERM before killing the selection owner via XKillClient()
XKillClient() is the same as sending SIGKILL

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 09:24:33 +02:00
Ivailo Monev
eb8ff2c536 kdeui: remove unused and private KHBox member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:55:12 +02:00
Ivailo Monev
593dd8b8d3 kdeui: format and indent khbox source and header files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:53:13 +02:00
Ivailo Monev
e7ae8c8351 kdeui: remove unused and private KTabBar methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:46:18 +02:00
Ivailo Monev
d5d26f9b11 kdeui: remove unused and non-operational KWindowSystem::allowExternalProcessWindowActivation() method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:06:40 +02:00
Ivailo Monev
ca762874c8 kdeui: remove KWindowSystem::doNotManage() method
what if KWin is not running? it's not a WM spec thing anyway

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:04:20 +02:00
Ivailo Monev
0e980c95cc kdeui: remove redundant attempts to start D-Bus services
creating QDBusInterface should start the services, in case the services
cannot be started tho delays may be experienced (such as the UI freezing
while waiting for D-Bus reply to finish) thus logging error

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 03:40:07 +02:00
Ivailo Monev
2de2388352 kinit: remove the "README" in the README file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 01:51:53 +02:00
Ivailo Monev
69f56fa9d8 plasma: remove unused Plasma::ComboBoxPrivate members
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 03:08:57 +02:00
Ivailo Monev
97372a82ef plasma: remove unused AbstractDialogManager class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 00:06:27 +02:00
Ivailo Monev
7ba06852a7 kutils: add TODO for KMediaWidget
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 13:20:56 +02:00
Ivailo Monev
f27ab85ce6 kdeui: correct breaks indentation in KPixmapSequenceOverlayPainter::eventFilter()
they look really out of place, don't they?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 13:16:20 +02:00
Ivailo Monev
802bf9aaf1 kdeui: KPixmap documentation correction
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 13:12:30 +02:00
Ivailo Monev
00d47751c1 kutils: set the position to zero when the player finishes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 13:02:01 +02:00
Ivailo Monev
638f54bc2b kio: deprecation warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 14:04:47 +02:00
Ivailo Monev
3fca1f6504 plasma: pass the script data directly to QScriptEngine::evaluate()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 10:06:36 +02:00
Ivailo Monev
0aa020de88 plasma: remove duplicate animation registration
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 09:49:47 +02:00
Ivailo Monev
bfa8788988 kfile: remove archive KIO slaves leftovers
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 09:24:52 +02:00
Ivailo Monev
637366d0a1 kdecore: new KToolInvocation::setLaunchEnv() method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 06:35:30 +02:00
Ivailo Monev
89e0305c24 kinit: remove redundant reparseConfiguration() method of org.kde.KLauncher interface
klauncher is no longer responsible for KIO slaves

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 03:59:18 +02:00
Ivailo Monev
b4017ba41a kpty: remove unused QByteArray object
build with clang v14, -Wall in CXXFLAGS and still got not warning for
it being unused

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 01:56:24 +02:00
Ivailo Monev
b0b0f528da kdecore: parent the KAuthorization object to the application instance if parent is null
that way it will be deleted before the application instance is plugging
memory leaks

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 01:29:42 +02:00
Ivailo Monev
6c98720e24 kdeui: implement KCrash::NoRestart flag
for programs that cannot be restarted by simply exec-ing them such as the
KIO slaves which require application socket as argument

note that restarting is maybe works thing - programs started by kdesudo
cannot be restarted (properly) as they are exec-ed by other program that
does the setup for them to function the way they should

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 00:36:35 +02:00
Ivailo Monev
936cc87544 kinit: log messages when service status changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 23:45:49 +02:00
Ivailo Monev
e7375fce97 kinit: set the application ID of the ASN
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 22:41:52 +02:00
Ivailo Monev
d4bf3d7a70 kdeui: exit after logging error when drkonqi is not installed
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 08:54:32 +02:00
Ivailo Monev
41418cb12b kdeui: set the KCrash handler to the default one if command line args are not initialized
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 08:33:04 +02:00
Ivailo Monev
f1e45b0142 kdecore: PCI IDs database update
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 08:12:43 +02:00
Ivailo Monev
6896f96245 kdeui: check if the KCmdLineArgs pointer is non-null before using it
fixes possible crash (e.g. when KCmdLineArgs is not initialized)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 07:49:43 +02:00
Ivailo Monev
d258df3881 generic: unblock signals when setting handlers for them
generally, those signals should not be blocked but it seems something is
blocking consequent SIGSEGV signals send by `kill` for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 07:45:25 +02:00
Ivailo Monev
053898e849 kio: use the default KCrash handler for debugging KIO slaves
once KIO slaves are plugins it would not matter tho (KApplication sets the
KCrash::DrKonqi flag already) but for now since they are detached
process poping drkonqi in case they crash (and KDE_DEBUG is set) is more
usefull than printing trace to stderr

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 07:33:20 +02:00