Commit graph

40 commits

Author SHA1 Message Date
Ivailo Monev
b8d4dc0dc4 generic: call static KStandardDirs methods as such
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 02:04:03 +03:00
Ivailo Monev
688f770e6e kdeui: remove KIconTheme getters for non-standard properties
other changes were made while at it, for reference:
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-31 15:10:06 +03:00
Ivailo Monev
1eaf89824e generic: make use of the new QPixmap comparison operators
requires the following commit from the Katie repo:
e28900041a4e78589f3ba28c36fda5bfd6e0f150

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-30 13:07:11 +02:00
Ivailo Monev
0c5d00727e generic: remove redundant Q_OS_UNIX definition checks
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-15 09:28:30 +02:00
Ivailo Monev
a2101eec56 kdeui: remove invalid KIconLoader resource directory
considered - nothing installs icons in such directory

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-09 03:08:36 +03:00
Ivailo Monev
c29db4dd9c kdeui: remove toolbar directory from appicon resource
no icons are installed there

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-27 16:53:34 +03:00
Ivailo Monev
11ddbf175a kdeui: minor KIconLoader optimizations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 22:31:39 +03:00
Ivailo Monev
c552f4bb86 kdeui: get rid of K3Icon
the information it holds is not used anywhere, bonus points for
optimizing the icons lookup

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 21:16:45 +03:00
Ivailo Monev
29bd64349f kdeui: do not use global static QString for the null effect fingerprint
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-20 01:00:02 +03:00
Ivailo Monev
d37a7c4c6e kdeui: ensure the favicon has size suitable for overlay
with commit de8c7f6af1d79c6b3cd3e8b2a21a56a020163b73 (in kde-workspace) I
changed the behaviour of favicon KDED module to not down-scale the favicons
to 16x16 and that ofcourse means large favicons (e.g. 256x256, yes some
websites have favicon with such size) may be overlayed on top of 32x32 icon
which does not look OK.

with this change the icon overlay will match the visual ratio of any
other icon overlay, unfortunetly that means scaling the favicon (i.e. for
large icons such 256x256, favicon with size 16x16 may be up-scaled to 32x32
) but it will still look better than it used to

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 04:44:04 +02:00
Ivailo Monev
9b41127ecb generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 00:40:18 +02:00
Ivailo Monev
b63686e9d0 generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 04:43:56 +02:00
Ivailo Monev
6cf96c3a87 kdeui: remove unused KAnimatedButton class and KIconLoader getters for movies
KIconLoader::loadMovie() and KIconLoader::moviePath() are attempting to
load non-standard .mng files which, as far as I am aware, no icon theme
ships. for reference:
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#context

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-28 17:56:47 +03:00
Ivailo Monev
4e192e5660 kdeui: remove checks for obsolete index.desktop icon theme files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-20 16:22:57 +03:00
Ivailo Monev
b6af68c97d generic: trim the lines when reading files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-29 14:09:07 +03:00
Ivailo Monev
6f34ee6809 generic: optimize reading from files
QTextStream uses internal buffer

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-29 10:54:57 +03:00
Ivailo Monev
926345627a generic: bump minimum Katie version requirement to 4.12.0
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 03:54:07 +03:00
Ivailo Monev
3422ca4413 generic: get rid of KGLobal::staticQString()
global statics are static objects and the method is using one

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-02-18 19:49:54 +02:00
Ivailo Monev
b187d42601 kdeui: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-12-22 07:08:49 +02:00
Ivailo Monev
409301e9d0 kdeui: ensure icon image used to paint overlay is in format supported by QPainter
fixes drawing of favourite icons in bookmarks runner

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-10-03 06:37:39 +03:00
Ivailo Monev
ea8fad680c generic: load SVG images as any other format
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-09-15 00:20:09 +03:00
Ivailo Monev
921e497471 generic: correct codec names in KMimeTypeRepository::parents() and KIconLoaderGlobalData::parseGenericIconsFiles()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-07-11 17:56:24 +03:00
Ivailo Monev
956151a106 kdeui: let QCache decide the cost and when to trim
the problem is that even 128x128 pixmaps would trigger cache trim with the
w*h+1 formula because the max cost is set to 10240 and as noted in the
icon loaded source comments some applications use it to load icons with
size greater than that

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-28 16:44:55 +00:00
Ivailo Monev
4a0c21e15b kdeui: improve icon cache colisions check
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-28 16:18:45 +00:00
Ivailo Monev
d543f77e67 kdeui: clear the icon cache upon reconfigure/init
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-28 15:59:03 +00:00
Ivailo Monev
fdfa8de248 kdeui: optimize icon loader
pixmap data is explicity shared and there is no need to insert multiple
pixmaps with the same key into the cache

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-28 15:09:14 +00:00
Ivailo Monev
fbf3973d05 generic: replace QLatin1Literal with QLatin1String
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-10-30 02:26:10 +00:00
Ivailo Monev
1e3b872a26 generic: get rid of the QStringBuilder requirement
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-10-29 05:06:31 +00:00
Ivailo Monev
972baa3d86 kdeui: minor KIconLoader::iconPath() optimization
the benefit from QStringBuilder is better than the static QString access

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-16 05:57:05 +00:00
Ivailo Monev
c6f33f23aa generic: get rid of KImageCache and KSharedDataCache
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-05 03:48:27 +00:00
Ivailo Monev
ef15158907 kdeui: do not use disk storage for icon cache
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-05 00:50:42 +00:00
Ivailo Monev
14f89b73a3 kdeui: do not hardcode the pixmaps directory
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-02-12 20:53:00 +02:00
Ivailo Monev
114af2916c kdeui: minor movie path lookup optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2015-11-22 16:55:34 +02:00
Ivailo Monev
636f904183 generic: optimize standard directories lookup
by caching results and storing them in a hash the results should
flow faster, a limit should probably be set on this but for now
there isn't. exists() and realPath() now cannot be called without
object!
2015-10-17 18:53:50 +03:00
Ivailo Monev
39b9ee37b2 generic: misc cleanups 2015-10-03 12:35:27 +03:00
Ivailo Monev
9c7b41e8f4 generic: misc cleanups 2015-09-21 20:30:05 +00:00
Ivailo Monev
5333e9917d generic: remove deprecated API 2015-02-28 03:27:54 +00:00
Ivailo Monev
82fc15f54b generic: use CMake moc instead of automoc4 by default
for compatibilty reasons automoc4 support is not removed but it
shall be in the future. automoc4 has not been maintained for a
while (last commit is from 2011) and the stable release is from
2009.

CMake version >= 2.8.6 provides the functionality for mocking so
I see no reason to not make use of it.
2015-02-27 07:40:26 +00:00
Ivailo Monev
3f0dd268de remove win and mac cruft 2014-11-27 18:22:42 +00:00
Ivailo Monev
814163a8dc initial import 2014-11-13 01:04:59 +02:00