Commit graph

612 commits

Author SHA1 Message Date
Ivailo Monev
520cf5a629 generic: headers inclusions review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-02 11:31:52 +03:00
Ivailo Monev
2c730832c1 kdeui: remove unused KDBusMenuExporter and KDBusMenuImporter API
the methods and signals were implemenented for compat with libdbusmenu-qt
but KStatusNotifierItem tracks status by itself for example, internal menu
synchronization (e.g. triggering importer action when exporter action is
triggered) can be implemented via the D-Bus adaptor and interface but is
currently not required

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-29 21:19:47 +03:00
Ivailo Monev
6a99e23068 kdeui: fix parameter shadowing in KDBusMenuAdaptor::actions()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-29 04:03:14 +03:00
Ivailo Monev
d92f080806 kdeui: document KDBusMenuExporter and KDBusMenuImporter
the finishing touch

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-29 01:55:05 +03:00
Ivailo Monev
675881c624 kdeui: KDBusMenuExporter and KDBusMenuImporter optimizations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-29 01:54:19 +03:00
Ivailo Monev
4bf945c574 kdeui: new static function to de-duplicate KDBusMenuImporter code
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-29 00:13:23 +03:00
Ivailo Monev
9a86368853 kdeui: implement sub-menu export/import for D-Bus menus
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-28 23:58:56 +03:00
Ivailo Monev
b54ba45a5a kdeui: create the QMenu only once from KDBusMenuImporter::updateMenu()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-28 21:16:45 +03:00
Ivailo Monev
819cca1e41 kdeui: replace libdbusmenu-qt dependency with custom classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-28 20:56:05 +03:00
Ivailo Monev
3db230c695 kdeui: remove redundant KDBusMenuExporter class
KIcon constructed from QIcon is just a QIcon (does not do icon lookup,
loading of icon, etc.)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-27 19:39:05 +03:00
Ivailo Monev
11ddbf175a kdeui: minor KIconLoader optimizations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 22:31:39 +03:00
Ivailo Monev
d032a0ed6d kdeui: move KIconLoader::Type enums to KIconThemeDir
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 21:42:15 +03:00
Ivailo Monev
c552f4bb86 kdeui: get rid of K3Icon
the information it holds is not used anywhere, bonus points for
optimizing the icons lookup

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 21:16:45 +03:00
Ivailo Monev
25336bda89 kdeui: mark KIconEngine reimplementations as final
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 20:18:00 +03:00
Ivailo Monev
fe93b26370 kdeui: remove unused KIcon and K3Icon data pointer members
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-24 19:29:26 +03:00
Ivailo Monev
2d2c71065c kdeui: somewhat format kacceleratormanager source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-23 05:06:12 +03:00
Ivailo Monev
6e549c55ff kimgio: drop TIFF write support
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 17:27:52 +03:00
Ivailo Monev
b3e9998d8c kimgio: fix TIFF images reading and implement write
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 07:54:18 +03:00
Ivailo Monev
15252c920e kdeui: fix possible out-of-bounds in KIconEffect::apply() methods
e.g. if KIconLoader::NoGroup (-1) is passed as group

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 23:53:28 +03:00
Ivailo Monev
c2618febf9 kdeui: convert some KIconEffect::apply() methods to static
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 22:41:34 +03:00
Ivailo Monev
53fda3a2f6 kdeui: remove the unused and non-standard LAUNCHED_BY ASN info
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 05:23:54 +03:00
Ivailo Monev
29bd64349f kdeui: do not use global static QString for the null effect fingerprint
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-20 01:00:02 +03:00
Ivailo Monev
ed4ebbe70e kdeui: remove unused KIconEffect::doublePixels() method
that's actually just scaling/transformation

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-20 00:49:00 +03:00
Ivailo Monev
c778105bde kdeui: format and indent kglobalsettings source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-01-02 00:26:14 +02:00
Ivailo Monev
6b477ad3dc kdeui: merge KGlobalSettingsData into KGlobalSettings::Private
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-01-01 20:48:04 +02:00
Ivailo Monev
e3117700d8 kdeui: remove unused KGlobalSettings::allowDefaultBackgroundImages() method
unused, no GUI to disable/enable it and palettes use colors (altough QBrush
can hold a texture)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-01-01 20:02:17 +02:00
Ivailo Monev
7a67866279 kdeui: read the mouse button mapping from the correct config
the mouse KCM stores the value in kcminputrc, not kdeglobals

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-01-01 19:48:10 +02:00
Ivailo Monev
4c7db025ff kdeui: someone's typos
why do KIconLoader methods take two size arguments overriding each other?
could've used negative values for KIconLoader::Group. I guess I will have
to fix someone's mess at some point

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-28 15:51:11 +02:00
Ivailo Monev
58798988c1 kdeui: minor KApplication documentation correction
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-23 20:27:49 +02:00
Ivailo Monev
ee59c22250 kdeui: minor KApplicationPrivate::sessionConfigName() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-23 18:40:00 +02:00
Ivailo Monev
8ab4b4bd40 kdeui: close only QMainWindow and derived classes from the KApplication quit handler
any widget should be parented to the main window (i.e. be a child of the
main window)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-23 17:49:33 +02:00
Ivailo Monev
4dd219d38b kdeui: close top-level widgets from the KApplication signal handler
this is much like session management but simply quitting the application
does not close the windows, if windows are not closed they will be leaked
(KMainWindow and derived classes are created on the heap without parent!)
and not saved properly because destructors would not be called

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-23 17:11:10 +02:00
Ivailo Monev
38e370d475 kdeui: new KApplication::quitOnDisconnected() method, also setup quit signal handler by default
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-23 15:09:48 +02:00
Ivailo Monev
786a11eeb0 kdeui: format and indent kdialogjobuidelegate source and header files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-23 03:35:16 +02:00
Ivailo Monev
5e3ceb0dd2 kdeui: quit KApplication when D-Bus daemon disconnects
so that applications (services like kglobalaccel, knotify, etc.) do not
keep running after the daemon quits (e.g. when program is started via
`kdesudo`, daemon quits but does not terminate services). there is a catch
tho - the order in which services quit may cause some trouble for
applications that do not expect services to suddenly stop

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-22 16:16:35 +02:00
Ivailo Monev
9d5d4d3f72 kdeui: remove the compat KApplication::saveYourself() signal
now unused

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-22 14:36:22 +02:00
Ivailo Monev
c545d14cf7 generic: remove binary compat bits
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-20 11:56:02 +02:00
Ivailo Monev
275b7be299 kdeui: klauncher recursion hack
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-19 16:59:18 +02:00
Ivailo Monev
4dbb501d25 generic: drop text-to-speech support
Katana (or any interface designed around key and mouse events) is not
for blind people, trying to slap text-to-speech on top of it was the
wrong thing to do to begin with

side note: speech-dispatcher tends to hang if the output device is not
configured properly (i.e. editing /etc/speech-dispatcher/speechd.conf
manually)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-18 15:56:59 +02:00
Ivailo Monev
bceaae0470 kdeui: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-17 15:09:27 +02:00
Ivailo Monev
e596f9a5d6 kdeui: unreserve KMessageBox::DialogType::SSLMessageBox
KIO SSL support was dropped some time ago (the certificates related code
that was used by konqueror)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-13 14:36:47 +02:00
Ivailo Monev
7cfcbc3775 kdeui: new KCrash::Backtrace to log backtraces
for programs that cannot call drkonqi to show backtrace (such as
ksmserver or any non-GUI D-Bus service)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 12:28:21 +02:00
Ivailo Monev
bdff3fa4e7 kdeui: log backtrace when no KCrash flags are set
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 12:17:48 +02:00
Ivailo Monev
6784f51d58 kdeui: tweak KNotificationManager and KGlobalAccel for automatic service activation
KGlobalAccelPrivate uses service watcher and the interface is invalid until
the service is activated (either by the first call of the interface or some
other lazy-initialization method), however KNotificationManager does
connect to signals immediately (which should work regardless) but the error
may have been logged before

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 12:00:23 +02:00
Ivailo Monev
a1951cfbae kdeui: reuse the already created interface in KGlobalAccelPrivate::getComponent()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 11:37:02 +02:00
Ivailo Monev
32dbecf2c6 kdeui: disable auto-restart when the application is about to quit
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 10:19:13 +02:00
Ivailo Monev
717fd59dc8 kdeui: send only SIGTERM before killing the selection owner via XKillClient()
XKillClient() is the same as sending SIGKILL

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 09:24:33 +02:00
Ivailo Monev
eb8ff2c536 kdeui: remove unused and private KHBox member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:55:12 +02:00
Ivailo Monev
593dd8b8d3 kdeui: format and indent khbox source and header files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:53:13 +02:00
Ivailo Monev
e7ae8c8351 kdeui: remove unused and private KTabBar methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:46:18 +02:00