Commit graph

130 commits

Author SHA1 Message Date
Ivailo Monev
1ac69ccc74 kdecore: drop unused startup condition feature
there are other conditions that are checked tho like the allowed
environment but this one is Katana specific and unused so

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-12 05:02:58 +03:00
Ivailo Monev
302a470d3b kded: drop unused window registration feature
no point in passing around windows to kded4 or its modules, job UI delegate
windows are different thing tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 15:45:36 +03:00
Ivailo Monev
75b9cfddd3 generic: const-ify private data pointers where copying is disabled
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-23 06:49:59 +02:00
Ivailo Monev
ff97198317 kdecore: unit conversion classes optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-27 20:50:15 +03:00
Ivailo Monev
2cdc9837a9 kdecore: compare units case-insensitively in unit conversion classes
on a side note: the old KUnitConversion implementation was not thread-safe
and was causing plasma-desktop crashes because it was used in the weather
and unit conversion applets, that is no longer the case tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-26 14:27:13 +03:00
Ivailo Monev
3ad6579891 kdecore: findLibraryInternal() function optimization
by checking if the unmodified (by makeLibName()) name is absolute first and
by not checking for relative library (if the name is not absolute path
QFileInfo::path() would return "." resulting in a relative lookup for
the library by KStandardDirs::findResource() in "lib" resource) the most
common cases are only looked for by KPluginLoader (either absolute path,
relative module or library but not relative to the current directory)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 18:02:33 +03:00
Ivailo Monev
fe00f4058f kdecore: remove TODO related to KPluginLoader
the property shall not be removed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 17:27:32 +03:00
Ivailo Monev
59b1d3da2d kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 17:14:38 +03:00
Ivailo Monev
4d01af27ee kdecore: remove unused KPluginFactoryPrivate member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 17:06:17 +03:00
Ivailo Monev
33138d4a49 kdecore: effectively revert 6ae96c3c1d
due to Katie changes (see 7c840afcb12096778ecb1539f7baba3e02ba6f85 in the
Katie repo) reading lines is much faster

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-07 17:12:37 +03:00
Ivailo Monev
73e5c1ad96 kdecore: compiler warnings fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-30 11:31:25 +03:00
Ivailo Monev
c44da5428f kdecore: do not insert and remove catalogs from KPluginFactory
already done by KComponentDataPrivate, when the component is created and
deleted

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-28 10:04:36 +03:00
Ivailo Monev
e512f4af70 kdecore: remove unused qtextstream header inclusion in qtest_kde header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-06 09:06:18 +03:00
Ivailo Monev
9e021af628 kdecore: initialize KMacroMapExpander and KWordMacroExpander variables
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 07:38:52 +03:00
Ivailo Monev
d2b312f5a1 kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 07:20:37 +03:00
Ivailo Monev
4a47d9f369 kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 07:14:51 +03:00
Ivailo Monev
059c365fee kdecore: replace component with class headers inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 07:02:09 +03:00
Ivailo Monev
687fcc041c kdecore: use foreach() for iterations in KUser and KUserGroup
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 06:55:43 +03:00
Ivailo Monev
825de1bb05 kdecore: use getpwnam_r(), getpwuid_r(), getgrnam_r() and getgrgid_r() in KUser and KUserGroup for thread-safety
TODO from:
704ef230d5

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 06:49:31 +03:00
Ivailo Monev
4d2b257330 kdecore: remove redundant qglobal inclusion in kshell header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 22:56:42 +03:00
Ivailo Monev
a3010676d5 kdecore: KUserGroup::userNames() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 05:37:22 +03:00
Ivailo Monev
dee81a72ef kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 05:32:43 +03:00
Ivailo Monev
c22d136874 kdecore: store KUser properties as a vector of QString
clever use of QVector<T> is clever

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 05:06:16 +03:00
Ivailo Monev
6ae96c3c1d kdecore: do not block while parsing files in KDeviceDatabase
parsing ~30k lines and filling maps for the entries takes some time and
could block the events of kinfocenter for example which is noticable
because the parsing of files is delayed until a KDeviceDatabase query is
made

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-06 16:07:14 +03:00
Ivailo Monev
65957abb2e kdecore: KDeviceDatabase optimization
I didn't benchmark it but I did the same kind of optimization for
KSystemTimeZones (which I did benchmark)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-03 05:47:20 +03:00
Ivailo Monev
6d9779739e kdecore: implement Foot (ft) unit conversion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 02:55:49 +03:00
Ivailo Monev
4fb8a1d674 generic: call klauncher methods asynchronously from KToolInvocation
so that application event processing is not blocked by any
KToolInvocation method, the D-Bus service name and PID return arguments
are not used anyway so removing them

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-19 12:44:44 +02:00
Ivailo Monev
89e0305c24 kinit: remove redundant reparseConfiguration() method of org.kde.KLauncher interface
klauncher is no longer responsible for KIO slaves

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 03:59:18 +02:00
Ivailo Monev
aa6b5ea4f0 kinit: klauncher and KCrash rewrite
much simpler and easier to maintain, also it will be proper D-Bus
service now with no sockets, process title hack and whatnot. KCrash
and startkde script (in kde-workspace repo) have to be adjusted for
it tho

note that the internal KIO scheduler already has the functionality to
put slaves on hold but now they will be started as detached process.
eventually they may become plugins (they are loaded as such by kioslave
program) without event loop dispatcher

fixes application startup notification (ASN) and cleanup issues

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-04 23:20:15 +02:00
Ivailo Monev
e851a35ee5 generic: remove unused X-KDE-autostart-after feature
klipper and kmix set it to "panel" in their .desktop files but that's not
valid application/service

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-03 04:06:04 +02:00
Ivailo Monev
86adc6607c kdecore: do not check if the file exists from KAutostart::isServiceRegistered()
if the file does not exists KStandardDirs::locate() returns empty QString

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-02 06:58:27 +02:00
Ivailo Monev
6ce3335549 kdecore: drop support for storing autostart phase as string
note: workspaceoptions KCM may have written such entries

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-02 06:53:22 +02:00
Ivailo Monev
8e5dd5ea50 generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-14 15:50:30 +02:00
Ivailo Monev
04c84dfbc1 kdecore: implement KDE_DEBUG_COLOR for KDebug
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 02:53:46 +03:00
Ivailo Monev
af07c63a89 kdecore: check if the dollar sign is used for command in KShellTest::envExpand()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-16 19:54:51 +03:00
Ivailo Monev
9fd7e104aa kdecore: fetch environment variables only if needed in KShell::envExpand()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-11 02:05:32 +03:00
Ivailo Monev
cee8f0b972 kdecore: minor KShell::envExpand() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-11 01:22:59 +03:00
Ivailo Monev
abe3e49268 kdecore: implement KShell::envExpand() and use it in KConfig and KUrlCompletion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-11 01:19:02 +03:00
Ivailo Monev
0b85d352a4 kdecore: format kuser_unix source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-10 23:14:44 +03:00
Ivailo Monev
8a7126133f kdecore: KShell and KMacroExpanderBase documentation update
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-10 18:59:48 +03:00
Ivailo Monev
b8cda045bd kdecore: do not assume the output exists in KDE::rename()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-07 22:49:55 +03:00
Ivailo Monev
4ff227e336 kdecore: emulate cross-filesystem move in KDE::rename()
if the temporary directory is of tmpfs type (which is the case on
Debian) then moving temporary files will fail thus thumbnails will not be
cached for example because they are stored as temporary file first and
then moved to ~/.thumbnails

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-07 22:38:57 +03:00
Ivailo Monev
e587e6ad28 kdecore: update comment and remove unused variable in KSaveFile::backupFile()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-03 14:34:32 +03:00
Ivailo Monev
dbf9fba9a7 kdecore: remove redundant append operator for QStringList
QList<T> already provides it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-03 04:56:03 +03:00
Ivailo Monev
f2b5c374ed kdecore: check for arc4random_uniform() and use it in KRandom::randomMax() if available
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-01 21:22:43 +00:00
Ivailo Monev
5743a7f5f4 kdecore: remove declaration of non-existing KShell::quoteArgInternal() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-26 13:13:58 +03:00
Ivailo Monev
7dc5187778 kdecore: replace most of KRandomSequence with new KRandom::randomMax() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-26 12:58:37 +03:00
Ivailo Monev
a08c91ab3c kdecore: mark internal KWordMacroExpander and KCharMacroExpander reimplementations as final
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-23 19:16:22 +03:00
Ivailo Monev
39e687084e kdecore: remove unused and internal KPluginFactory methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-23 19:05:28 +03:00
Ivailo Monev
4a4c85431e kdecore: move K_EXPORT_PLUGIN() macro to kpluginfactory header [ci reset]
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-31 09:06:11 +03:00