Commit graph

71 commits

Author SHA1 Message Date
Ivailo Monev
6d0274d417 generic: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-06 23:37:03 +03:00
Ivailo Monev
22755ffef1 kutils: drop the fullscreen option of the media widget
that nasty hack was working like a charm tho. oh, well..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 07:08:27 +02:00
Ivailo Monev
7408c3b692 kutils: de-duplicate KAbstractPlayer code
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 06:03:56 +02:00
Ivailo Monev
12a58a3ee0 kutils: media classes debug and warning messages review
some of them were wrapped in i18n() macro with the idea to use some of them
in errorString() getter to report MPV initialization failure for example
but I do not think I will implement that (not that there is error(QString)
signal for reporting MPV failure after its initialization)

the debug messages are also quite spammy (because of time-pos property
changing constantly while playing for example), i.e. don't enable them
unless you have good reason for that because multiple media classes
instances can quickly fill your ~/.xsession-errors with lots of messages

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 02:22:04 +02:00
Ivailo Monev
7f4e028fb6 kutils: do not observe loadfile property
altought it is a command an event it send for it but the property is not
used by the media classes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 02:09:40 +02:00
Ivailo Monev
883db83628 kutils: KMediaPlayer initialization optimization
there used to be "vo" option doing the same I believe, anyway it should
speed up initializations by not checks for other contexts (it is to be
rendered into X11 window after all)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 01:15:44 +02:00
Ivailo Monev
667c23d743 kutils: delete the player before the UI from KMediaWidget destructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 00:36:02 +02:00
Ivailo Monev
90928e8320 generic: store package found definitions in config header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-30 05:41:21 +02:00
Ivailo Monev
f1a580ebaf kutils: fix build without MPV
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-02 13:37:59 +03:00
Ivailo Monev
1a06d034e0 kutils: warn when the media player option type is invalid
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-23 08:03:09 +03:00
Ivailo Monev
2e3f7122b6 generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-11 22:55:59 +03:00
Ivailo Monev
997a8df465 kutils: use correct type for double properties in media classes property setter
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-05 13:37:11 +03:00
Ivailo Monev
30bb40bf9f kutils: reimplement media classes command sender, option getter and option setter
less bits, less CPU cycles wasted

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-04 00:02:22 +03:00
Ivailo Monev
2b2f82946a kutils: media classes copyright update [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-01-09 04:24:09 +02:00
Ivailo Monev
063b6de441 kutils: fix build with MPV v0.35.0+
https://github.com/fluxer/katana/issues/28

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-01-07 23:45:54 +02:00
Ivailo Monev
6c17a1ab07 kutils: typo
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-07-01 16:46:08 +03:00
Ivailo Monev
c6b8c9b10f kutils: typo
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-06-24 12:38:28 +03:00
Ivailo Monev
f993b5e90d kutils: do not issue warning for invalid media player properties
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-03-13 22:19:51 +02:00
Ivailo Monev
4077bf11db kutils: do not issue warning from option getter
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-03-11 06:40:50 +02:00
Ivailo Monev
9d120c519d kutils: add support for setting the player ID to media classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-02-26 09:55:47 +02:00
Ivailo Monev
277ef757e0 kutils: compiler warning fixes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-01-03 00:16:00 +02:00
Ivailo Monev
b6e1f0f867 kutils: include locale header for setlocale() in kmediaplayer source
fixes build on FreeBSD

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-01-03 00:09:40 +02:00
Ivailo Monev
3f844d4dca kutils: adjust KAbstractPlayer to MPV changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-01-02 06:29:59 +02:00
Ivailo Monev
4e652836b2 kutils: convert asserts to runtime warnings
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-01-02 06:04:01 +02:00
Ivailo Monev
f316c4bb47 kutils: fix build against MPV v0.33.0
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2020-12-28 20:49:44 +00:00
Ivailo Monev
f0511e043c kutils: use const-reference in KAbstractPlayer iteration to avoid copy
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-25 17:40:51 +00:00
Ivailo Monev
6512385459 kutils: fix WId type handling in KMediaPlayer constructor for 64-bit host
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-25 00:59:00 +00:00
Ivailo Monev
a1345d67d6 generic: require filename and mode to be passed to KSettings constructor
otherwise the constructor can be shadowed by the default QSettings
constructor which does not take any arguments at all

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-01 12:46:10 +00:00
Ivailo Monev
7d0c2d0cb1 generic: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-23 16:36:22 +00:00
Ivailo Monev
5b41f81878 generic: make use of KSettings where possible
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-07-12 17:45:25 +00:00
Ivailo Monev
c2f8387fa6 generic: implement KSettings class
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-07-12 14:09:24 +00:00
Ivailo Monev
91e0870d9e kutils: mostly documentation updates
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-06-01 23:59:31 +00:00
Ivailo Monev
1e129fc882 kutils: fix hidden media controls bugs and declare API as stable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-06-01 21:59:08 +00:00
Ivailo Monev
09423d9589 ktuls: overhaul media classes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-24 20:29:43 +00:00
Ivailo Monev
6f03b92281 kutils: fix API clashes and improve error handling of media classes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-23 17:12:53 +00:00
Ivailo Monev
7def7bf6e3 kutils: review multimedia related classes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-22 04:44:14 +00:00
Ivailo Monev
a22d3b9663 kutils: minor kmediaplayer cleanups
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2017-07-08 13:08:34 +00:00
Ivailo Monev
62c851e322 kutils: store the player's volume as integer rather than variant
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-12-19 05:55:20 +00:00
Ivailo Monev
c89aaffc1a kutils: add asserts for properties handling and a comment about a quirck
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-11-09 02:03:01 +00:00
Ivailo Monev
63d4353e4a kutils: more const-ing
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-24 20:18:18 +00:00
Ivailo Monev
c0fd00a6d3 kutils: const-const-constop it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-24 18:21:23 +00:00
Ivailo Monev
0c12ff6ce8 kutils: avoid use of delete on QObject derived classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-21 21:29:22 +00:00
Ivailo Monev
293536b688 kutils: const-fy the media classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-21 17:58:44 +00:00
Ivailo Monev
72fed1d6a5 kutils: hide private members of media classes behind KAbstractPlayerPrivate
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-19 05:30:36 +00:00
Ivailo Monev
36072e6f92 generic: remove now redundant QT_KATIE guards
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-13 22:43:04 +00:00
Ivailo Monev
155082bdf3 kutils: fix the window id setup in KMediaPlayer
WId should be unsigned long for Q_WS_X11 (see qwindowdefs.h from Qt4) but
MPV requiers that the type is intptr_t (see options.rst from MPV) yet none
of them works but quintptr does - it's magic.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-08-09 03:29:12 +00:00
Ivailo Monev
d1ee2575c1 kutils: make the player thread-safe
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-06-22 17:22:29 +00:00
Ivailo Monev
30c6025c61 kutils: the static cast was needed, oops
neither the compiler would complain (QVariant can hold custom types via
runtime registration) nor runtime warning about invalid QVariant was issued
for this (because it was casted to something, not sure what but it was the
wrong type)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-06-04 01:07:37 +00:00
Ivailo Monev
ecf6f851af kutils: use method that works on x86_64 for widget ID setup in KMediaPlayer
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-06-03 22:15:57 +00:00
Ivailo Monev
2d823ecdd8 generic: make MPV recommended not required
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-05-14 10:07:58 +00:00