no way the grab failed or something other than KGlobalAccel grabs the
shortcut by force from KGlobalAccel, right?
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
now to figure out if importing of action collections settings should be
magic or done by a KShortcutsEditor::importConfiguration() call (there is
only one place where it is called, see kwin/kcmkwin/kwindesktop/main.cpp)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
kinda hack tho but makes it easier to distinguish between main and plugin
action collection shortcuts, if there is only one top-level item it should
not be visible (decorated) for cases like kwin KCM but this will be done
later on
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
global shortcut resolution (the KGlobalAccel methods) work on
application level, X11 as far as I can tell does not have a method to
tell which application has grabbed a key (to fill KGlobalShortcutInfo).
other than that no configuration interface for global shortcuts (not by
KGlobalAccel itself, plasma and its applets have interface for that),
also the shortcuts interface did not and still does not handle global
shortcuts well so that is something to look into.
one of the problems solved with this change is the fact that multiple
plasma applets (e.g. multiple instances of the keyboard applet) could
not use the same shortcut, now it is possible. as for which applet gets
the shortcut action it is the one that has the grab first - that is how
key grabbing works in X11
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
animating KMessageWidget could not be done properly, not with fade and
not with size animation. it was bad idea from the start
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
using the selection color for information messages when the text is
selectable was questionable atleast, overriding QFrame action setters,
using QFrame as base class when none of its features were used..
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
this can be done by callers but is not, makes changing of language from the
plasma spellcheck applet take effect for example
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
it is not matter of timeout, it is matter of the KNotification instance
being around for the actions. once it is not the notification actions
become non-operational. other than that notification stay indefinetly
in the notification area
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
instead of virtual method for creating one and a setter now there is only
a setter with ownership of the highlighter belonging to the parent (the
case for the default-created highlighter) or caller of
KTextEdit::setHighlighter()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
