it is needed in Okular and in KNotify I think so with the overload method
the possibility for MPV API break to affect those application will be
reduced, KAbstractPlayer is ment to be abstraction after all
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
it has too many side effects that will complicate things more then it is
worth it to save a few MB of RAM per-application until load
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
one bug was that replay was not possible after sucessfull finish, another
one was that controls remained hidden after finish because path is empty
and finally the play/pause button was not update on finish because MPV does
not emit the event on finish (noted in the API docs)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
returing from the constructor prematurely is not a good idea because the
settings pointer may be left uninitialized, also issue a general warning
if mpv_create() failed
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
kcompactdisc was remove because there is no use for it in the
current set of applications supported, if it is needed it will
need some work to make it use KMediaPlayer or whatever.
the Plasma VideoWidget class was dropped because custom widgets
(at some point) will be dropped unless absolutely needed and
hopefully getting rid of the heavy-weight QML stuff.
the new KMediaPlayer and KMediaWidgets classes are experimental
but they have been tested and they work as they should.
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
