From: Simeon Bird <bladud@gmail.com>
Date: Thu, 18 Dec 2014 03:54:32 +0000
Subject: Fix crash in KIO due to exposing inconsistent views of internal data.
X-Git-Tag: v4.14.8
X-Git-Url: http://quickgit.kde.org/?p=kdelibs.git&a=commitdiff&h=4288d7e7c81839d6bdb25b1197c6e614f0259036
---
Fix crash in KIO due to exposing inconsistent views of internal data.
This can be triggered by renaming a directory while one of the files in
it is open in gwenview.
It occurs because when KCoreDirListerCache::emitRedirections is called,
itemsInUse contains the old url. However, KDirLister::Private::redirect
changes lstDirs to the new url. Thus at this point lstDirs contains an
item not in itemsInUse, which causes an assertion if forgetDirs is
called.
In gwenview, the redirection signal is connected to openURL. This calls
forgetDirs, and causes the assertion.
The solution: update itemsInUse *before* emitting redirections.
This fixes the crash, but gwenview opens the first file in
the new directory instead of the file open before renaming.
This is probably an unrelated gwenview bug.
REVIEW: 117345
---
sometimes with metadata that has many small value entries the
widget rows were overlapping. in the process of fixing this a
minor cleanup was done - two less temporary variables are assigned
namely "Part of" and an extra "Type". The "Part of" filed is not
very obvious and in most cases just a null (empty string), the
extra "Type" refers to some sorta Semantic spec thing is not more
than useless as two other MIME information fileds are show - one
with a human friendly and one with programmers friendly string in
it and are more than enough in most if not all cases.
altought the KIO library is not needed I faced some linking
problems during build, almost as if the libraries requested for
the kded4 building were ignored. this needs further investigation
but for now that will do.
previously one had to set KDESU_USE_SUDO_DEFAULT to build kdesu
with sudo support and no message has been printed to show that it
was/was not found in the features log.
since most of the settings are "frozen" now there is little to no
chance that it will be needed. CMake files that reference paths
for installing .upd files are left intact for now.
From: Pino Toscano <pino@kde.org>
Date: Sat, 16 May 2015 13:25:56 +0000
Subject: Use tcgetattr & tcsetattr if available
X-Git-Tag: v5.11.0
X-Git-Url: http://quickgit.kde.org/?p=kpty.git&a=commitdiff&h=35ea45b588db9afcbd796576833ac338c6b4b8e8
---
Use tcgetattr & tcsetattr if available
Look for tcgetattr & tcsetattr, and use them if found before trying the
own OS checks. They are specified by POSIX.1-2008, so they should be
available on platforms implementing modern POSIX interfaces.
The rest of the fallback code is left as is for platforms not previously
using tcgetattr & tcsetattr.
REVIEW: 123811
---
