Katana_mirror/kdelibs
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kdelibs.git synced 2025-02-24 10:52:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
4264 commits 3 branches 0 tags 36 MiB
Commit graph

4264 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ivailo Monev
43dc4568db kdecore: remove unused QMimeData inclusion 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 23:17:47 +03:00
Ivailo Monev
bf62c2b69d generic: consistent RFC references 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 23:02:40 +03:00
Ivailo Monev
bd990c2ae8 kdecore: return empty string if there is no slash in the input of kPathDirectory() 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 21:52:43 +03:00
Ivailo Monev
4f1050a5ac kdecore: KUrl optimizations 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 21:24:18 +03:00
Ivailo Monev
eac8fd79cc kdecore: re-use KUrl::AdjustPathOption for KUrl::fileName() and KUrl::directory() 
so that it is clear that the options shall affect only the result, also for
local files the correct thing can be done regardless of the trailing slash
as is done in KUrl::upUrl()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 20:47:38 +03:00
Ivailo Monev
065100c799 plasma: fix regression since 4ae4a6f174 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 18:09:54 +03:00
Ivailo Monev
06ce034a80 kdecore: remove declaration of non-existing KUrl::join() method 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 17:00:27 +03:00
Ivailo Monev
37d9ca4f71 kdecore: rename KUrl test for consistency 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 07:47:18 +03:00
Ivailo Monev
f1bd676623 kdecore: test relative vs relative local file URLs 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 07:44:41 +03:00
Ivailo Monev
5bf76a5f3a kdecore: compare the clean paths of local file URLs 
things are getting complicated for local files but that is how it should be

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 07:36:59 +03:00
Ivailo Monev
9f5081f9f8 kdecore: rename variables for consistency 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 06:12:01 +03:00
Ivailo Monev
b83771b4c2 kdecore: handle local file paths with and without trailing slash in KUrl::upUrl() 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 05:42:51 +03:00
Ivailo Monev
f632a2b9bb generic: define NDEBUG when not building for debugging 
not adding it to KDE4_DEFINITIONS on purpose (KDELibs4Config.cmake does it
conditionally)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 03:50:54 +03:00
Ivailo Monev
181e119ecc kdecore: KUrl::equals() rework to use KUrl::url() for the comparison 
same thing (all URL components are compared) except the trailing slash
option can be re-used for it essentially adding one more option (to add
trailing slash when comparing)

also fixed and tested KUrl::upUrl() for some cases

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 01:30:23 +03:00
Ivailo Monev
180f34d2e3 kdecore: fix null/empty KUrl comparison and test it 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 00:34:45 +03:00
Ivailo Monev
b1c7c3b392 kdecore: move KUrl code where it belongs 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 00:10:11 +03:00
Ivailo Monev
84d5b447d3 kio: add the kurlcompletiontest header 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-26 00:00:54 +03:00
Ivailo Monev
db7fb2a8ee kdecore: add comment about the re-construction of the URL in KUrlTest::testHash() 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 23:59:40 +03:00
Ivailo Monev
47d0b5a297 kdecore: remove unused KUrl metadata 
was used to pass the referrer and while it is still possible to
reimplement it realisticly speaking it is impossible to preserve the
referrer (and other HTTP(S) header metadata) because it will be lost in
transition in some cicumstances such as when drag-n-drop is done to
application unaware of application/x-kio-metadata

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 21:13:59 +03:00
Ivailo Monev
e4a4798d60 kdecore: remove redundant KUrl::fromMimeDataByteArray() method 
calls KUrl constructor with the unmodified str argument in both cases

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 19:54:51 +03:00
Ivailo Monev
2c6f00f690 kdecore: remove reference to non-existing KUrl::setExportAsText() and KUrl::List::setExportAsText() methods 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 19:48:15 +03:00
Ivailo Monev
03bd3652c3 kdecore: compiler warning fix 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 19:36:10 +03:00
Ivailo Monev
1c25006049 kdecore: typo in KUrl tests comment 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 18:51:44 +03:00
Ivailo Monev
865711ae83 kdecore: KUrl::url() optimization 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 18:51:15 +03:00
Ivailo Monev
40da298881 kdecore: never output file:// for local files 
there is a fix for that legacy thing

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 18:15:06 +03:00
Ivailo Monev
cb8a624390 kdecore: fix recursion due to kCheckLocalFile() 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 17:47:18 +03:00
Ivailo Monev
5b90bcb8ea kdecore: test hashing of KUrl with different port 
now that it is taken into account, see:
7e056ee4a1

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 17:22:48 +03:00
Ivailo Monev
54ee8ee1cd kdecore: clarfication on the note in KUrl test 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 16:50:36 +03:00
Ivailo Monev
d63bb71869 kdecore: rename constant for consistency 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 16:36:45 +03:00
Ivailo Monev
10858e928f kio: KDirModelPrivate::_k_slotNewItems() optimization 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 08:22:16 +03:00
Ivailo Monev
f1df519d20 kdecore: test qHash() for KUrl 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 06:31:53 +03:00
Ivailo Monev
7e056ee4a1 kdecore: use KUrl::url() for the hash 
otherwise different user, password, host or port will not result in
different hash, duh

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 05:11:39 +03:00
Ivailo Monev
0917277201 kdecore: remove unused KUrl::CompareWithoutFragment enum 
doubles as optimization for KUrl comparisons

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 05:05:08 +03:00
Ivailo Monev
94a5a3f641 kdecore: remove redundant KUrl destructor 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 04:00:49 +03:00
Ivailo Monev
a7fe953ca9 kdecore: ensure KUrl::url() handles only full paths to local files specially 
it's dirty, it's magic, it's a fix

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-25 03:15:21 +03:00
Ivailo Monev
728dc0838e kdecore: remove unused headers inclusions in kurl source file 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-24 23:20:20 +03:00
Ivailo Monev
13fdc7b7cd kdecore: do not prettify the URL in KUrl::pathOrUrl() 
here is how to make browsers barf - check the tooltip and where the browser
thinks the URL points to:
https://ibb.co/cyhwppK

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-24 23:13:38 +03:00
Ivailo Monev
ef02376c35 kdecore: add KUrl query and fragment test 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-24 21:25:20 +03:00
Ivailo Monev
67d6fa8588 generic: adjust expected tests data 
QUrl::StripTrailingSlash removes all trailing slashes and KUrl does not
convert to percentage encoding - local file URLs remain the same when
passed around.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-24 20:57:21 +03:00
Ivailo Monev
0a5fadde75 kdecore: do not change the scheme from KUrl::cleanPath() 
the fact that many KUrl methods change it (by calling KUrl::setPath()) is
just bonkers but that's how it was implemented - to convert to file scheme
from setters

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-24 20:44:03 +03:00
Ivailo Monev
78c109df85 kdecore: more compatible KUrl 
abusing the QUrl path for local files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-24 20:10:09 +03:00
Ivailo Monev
8f348b4c5b kdecore: remove FIXME for KUrl 
so far so good:
https://ibb.co/TYN4z3x

now on to the quircks..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-24 03:00:21 +03:00
Ivailo Monev
ea02aa2c1a kdecore: fix regression since 7b8ff71eba 
oops

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-24 00:53:35 +03:00
Ivailo Monev
341e16d4c6 kdecore: update comment in KUrl::prettyUrl() 
konqueror is no more

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-23 23:58:08 +03:00
Ivailo Monev
5e4732f809 kdecore: KUrl::List from QList<QUrl> optimization 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-23 23:55:19 +03:00
Ivailo Monev
c81c3bd71d kdecore use the new QUrl::AddTrailingSlash enum 
requires the following commit from Katie repo:
3369835da10412451d082713433321a72f25e0df

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-23 23:08:09 +03:00
Ivailo Monev
7b8ff71eba kdecore: KUrl rewrite to output encoded strings 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-23 22:33:18 +03:00
Ivailo Monev
b4861f86d5 kdecore: rename variable in uriListData() 
bad variable naming - clashes with the function name and inconsistent

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-23 18:22:41 +03:00
Ivailo Monev
840f3a3b68 kdecore: assume strings passed to KUrl constructors are percentage-encoded 
for compat, test case for it is KUrlMimeTest::testURLList()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-23 18:14:39 +03:00
Ivailo Monev
30cd526513 kdecore: set the scheme to file when it KUrl is constructor from string and it is empty 
the test case for it is "local file 3" case of KUrl::cleanPath() test and
the KUrlNavigator test

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-23 17:53:20 +03:00