Commit graph

4796 commits

Author SHA1 Message Date
Ivailo Monev
88598523d0 kdeui: new KPixmapWidget
the idea for QImage/QPixmap-optimized widget occurred to me while
writing kimageviewer (see the kde-playground repo), unlike the widget I
wrote for kimageviewer this one supports drag-n-drop tho and is drop-in
replacement for QLabel when showing only a pixmap is required. the
widget also shows a small image while dragging ala ksnapshot

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 08:59:51 +03:00
Ivailo Monev
7cb0785160 kdecore: add note about QDialog::exec() to the alarm() call in KDebugMessageBoxDevice::writeData()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 00:24:31 +03:00
Ivailo Monev
e6ef3d422f kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 21:38:59 +03:00
Ivailo Monev
ac69de425c kdecore: create the global KDirWatch instance on demand
Q_GLOBAL_STATIC() no longer creates instance on demand

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 20:59:11 +03:00
Ivailo Monev
cc6903476e kdecore: new KDirWatch methods to get and set the poll interval
requires the following commit from the Katie repo:
4795a577bff4f9db89c77195df763575a602bcc3

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 20:58:06 +03:00
Ivailo Monev
e7823a0484 generic: require Katie v4.14.0+
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 20:35:10 +03:00
Ivailo Monev
8703b0b0d5 kdeui: plug KNotificationManager memory leak
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 19:48:24 +03:00
Ivailo Monev
d6e335dbc6 kdeui: watch the notification configs for changes and lock KNotificationManager for thread-safety
in the old implementation KNotificationManager was not locked but it is
global static so it is subject to thread-safety issues thus it has to be
mutex-locked

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 19:41:37 +03:00
Ivailo Monev
bdd45bac0e kdeui: filter sound files with unknown extension in KNotificationConfigWidget::setNotification()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 19:08:35 +03:00
Ivailo Monev
cc338a8f3b kdeui: build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 16:09:52 +03:00
Ivailo Monev
9338606754 kdeui: fix possible double-free in KApplicationPrivate::parseCommandLine()
could happen only if "waitforwm" command line argument was passed and there
was no window manager

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 15:11:56 +03:00
Ivailo Monev
6c5b16e503 kdecore: remove unused and redundant KStringHandler::isUtf8() and KStringHandler::from8Bit() methods
use QTextCodec::codecForText() and QTextConverter instead

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 03:32:57 +03:00
Ivailo Monev
7145876ebd generic: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 03:25:39 +03:00
Ivailo Monev
fd53dcd2f4 kio: remove non-operational bits
CHECK_UTF8 is never defined

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 03:18:08 +03:00
Ivailo Monev
640cfb06e3 kdeui: KRecentFilesAction::saveEntries() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 03:00:45 +03:00
Ivailo Monev
91168f281c kdeui: remove unused variable in KRecentFilesAction::saveEntries()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:58:04 +03:00
Ivailo Monev
9acda75f99 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:57:26 +03:00
Ivailo Monev
312c5a6268 kdeui: de-virtualize KPasteTextAction destructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:32:18 +03:00
Ivailo Monev
7fda04bcd0 kdeui: remove unused KPasteTextAction::setMixedMode() method
not only is the method unused but so is the KPasteTextActionPrivate member

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:31:28 +03:00
Ivailo Monev
c9d9c44643 kdeui: initialize KPasteTextActionPrivate members from its constructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:28:45 +03:00
Ivailo Monev
6278217dc6 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:26:32 +03:00
Ivailo Monev
b1b18231d8 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 01:52:15 +03:00
Ivailo Monev
e8cb5109be kdeui: remove unused variable in KActionCollection::exportGlobalShortcuts()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 01:41:36 +03:00
Ivailo Monev
c573c74ea1 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 01:40:03 +03:00
Ivailo Monev
8f21b07de6 kdeui: remove unused KActionCategoryPrivate member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 01:27:27 +03:00
Ivailo Monev
acdc2e7acf kdecore: typo
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 21:09:07 +03:00
Ivailo Monev
453680e04d kdecore: do not store the KCatalog object as KuitSemantics member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 20:46:25 +03:00
Ivailo Monev
5d12e973e6 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 20:45:47 +03:00
Ivailo Monev
5ff064886b kdeui: de-virtualize KAction desctructor
KAction has no virtual methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 19:17:38 +03:00
Ivailo Monev
3fcfdb2687 kdeui: KAction constructors optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 19:17:10 +03:00
Ivailo Monev
558295b483 kdeui: KAction::shortcut() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 18:46:59 +03:00
Ivailo Monev
048737d48c kdeui: remove bogus bits in KAction::setGlobalShortcut()
the keycode for invalid shortcuts (QKeySequence) is zero, the key could be
zero if alternative shortcut is not set and there is only primary shortcut.
also, Katie's QKeySequence supports only two key combinations now - one for
primary and one for alternative, see the following commit in the Katie
repo:
d03db175529e800f62acd858badb5622be2e00af

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 17:23:59 +03:00
Ivailo Monev
7339f85e8c kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 07:20:24 +03:00
Ivailo Monev
2bf47096e8 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 07:08:35 +03:00
Ivailo Monev
97b1ea46c1 kdecore: log KSystemTimeZones and KTimeZone messages to the correct debug area
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 05:45:50 +03:00
Ivailo Monev
b2db2e1c36 kdecore: update description of kpty debug area
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 05:41:32 +03:00
Ivailo Monev
ef013e9da7 kdecore: add debug area for kglobalaccel
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 05:08:19 +03:00
Ivailo Monev
6f03a3127c kutils: typo
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 03:09:25 +03:00
Ivailo Monev
e99b1b6e32 kdeui: round-trip to the event loop from KNotification::event() again
compat for ksmserver..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 02:03:29 +03:00
Ivailo Monev
3e01296579 kfile: add the leading directory to recent directories for files and URLs from KFileWidgetPrivate::addToRecent()
continuation from:
978cf7f0dd

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 01:55:16 +03:00
Ivailo Monev
eef26737e5 kdeui: use the global group comment as application name for the notification
questionable but the old implementation was doing it, as for why it is
questionable - it is more like a description rather than application name
(e.g. "Crash notifier" rather than "kcrash")

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 01:20:16 +03:00
Ivailo Monev
ed513261b3 kdeui: correct x-kde-appname notification hint
while in most cases it is the same as the main component name the always
correct value (now anyway) is the main group which is part of the event ID

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 01:05:14 +03:00
Ivailo Monev
a5f571b76b kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 23:17:24 +03:00
Ivailo Monev
2c0a265496 kdeui: set initial size for the KNotificationConfigWidget dialog
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 22:08:56 +03:00
Ivailo Monev
4a15907fbb kdeui: remove unused static g_bMacLabels variable
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 21:03:04 +03:00
Ivailo Monev
217c3c1f66 kdeui: remove unused Mod, SymVariation and SymName structs
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 21:00:39 +03:00
Ivailo Monev
f1d3035572 kdeui: initialize static variables in kkeyserver_x11
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 20:56:34 +03:00
Ivailo Monev
bd07b86156 kdeui: do not return the created KNotification from KNotification::event()
to prevent stupidity, fixing issues is piece of cake when compatibility is
not concern

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 20:55:22 +03:00
Ivailo Monev
288d07c31d kdeui: delay the automatic deletion of non-persistent notifications by 500ms
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 20:41:03 +03:00
Ivailo Monev
856b853b89 kutils: de-duplicate KAudioPlayerModule code
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 20:15:29 +03:00