Commit graph

571 commits

Author SHA1 Message Date
Ivailo Monev
1ecd860cd3 kio: specialize only the globs matching
the soft MIME matching via KMimeType::is() is way too.. soft. it can match
application/x-dvi as plain/text (and use ps thumbnailer) which is not ideal
(should use only textthumbnail thumbnailer for plain/text and ps
thumbnailer for application/x-dvi)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 00:02:56 +02:00
Ivailo Monev
f9b87a7adf kio: update comment in PreviewJobPrivate::getOrCreateThumbnail()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 06:13:29 +02:00
Ivailo Monev
e3f470feab kio: typo
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 06:12:13 +02:00
Ivailo Monev
9e3f2b3eb2 kio: log PreviewJob messages to the kio (KIOJob) debug area
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 06:10:02 +02:00
Ivailo Monev
9e5c94b905 kio: check if any of the preferred services is in the list of enabled plugins
the reason for checking the preffered offers first should be obvious - it
is questionable which match should be done first. should it be the glob or
the exact match? chicken and egg thing

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 02:25:06 +02:00
Ivailo Monev
bc10416911 kio: try to find thumbnailer plugin via KMimeTypeTrader::query() first
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 02:13:58 +02:00
Ivailo Monev
2e6f3fba02 kio: PreviewJobPrivate::startPreview() rewrite
mostly to make the MIME types check consistent by using KMimeType::is()
for the comparison (as done by KPreviewPropsPlugin::supports() for example)
and to filter the ThumbCreator service type (to avoid invalid KMimeType
checks)

fixed KFileMetaInfo regression for plugins that use globs aswell

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 01:25:33 +02:00
Ivailo Monev
27de045733 kio: drop unused remote thumbnailers feature
none of the plugins support it and it slows down the thumbnail
preview generation (or fetching of existing thumbnail)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 23:25:40 +02:00
Ivailo Monev
de3384ee46 kio: format and indent previewjob source file
side note: the MIME matching code in PreviewJobPrivate::startPreview() is
spaghetti

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 22:41:13 +02:00
Ivailo Monev
d67610909c kio: remove documentation for non-existing methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 03:48:28 +02:00
Ivailo Monev
38635d4406 kio: implement IconAlpha config option for previews
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 23:35:39 +02:00
Ivailo Monev
b5c5b5c85a kio: remove preview overlay icon alpha override
setting it to zero essentially disables it, an option for it will be
implemented instead

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 23:34:32 +02:00
Ivailo Monev
8611f36591 kio: correct reference to kDebug()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 00:59:14 +02:00
Ivailo Monev
3339338121 generic: prepare for Katie changes
note that kDebug(), kWarning(), etc. automatically add end of line

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 00:46:32 +02:00
Ivailo Monev
9b41127ecb generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 00:40:18 +02:00
Ivailo Monev
2b2ac283e8 kio: move metadata plugin keys to the .desktop files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 14:40:57 +02:00
Ivailo Monev
1e982a7e2d kio: move metadata plugin MIME types to the .desktop files
ideally, the keys would also be stored in the .desktop files so that
plugin instances would not have to be created from
KFileMetaInfo::supportedKeys() too

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 13:59:00 +02:00
Ivailo Monev
b8834c9cdd kio: increase the default preview sizes limits
the option to change them is hidden deep into the Dolphin configuration
meaning a thumbnail not being generated in gwenview may require from the
user to launch Dolphin and increase the limit (especially for images in
RAW format) but does he/she know about it?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 07:32:12 +03:00
Ivailo Monev
55e7b76bd0 kio: fix regression since 704ef230d5
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 17:46:10 +03:00
Ivailo Monev
76ffb428ee kio: add timeout timer to the KDirLister test
fixes possible test hang

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 17:20:51 +03:00
Ivailo Monev
ebdee75650 kio: correct area in KDirModel::flags()
7007 is for kio (KIOJob)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-22 23:48:10 +03:00
Ivailo Monev
2c53b75153 kio: correct error message areas in KIO::chmod()
250 is reserved for kfile (kdelibs)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-22 23:23:17 +03:00
Ivailo Monev
0b998b4881 kio: log FileUndoManager messages to the kio area
1203 is reserved for libkonq

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-22 20:52:09 +03:00
Ivailo Monev
c0a340914c kio: remove comment for them aswell
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-18 03:47:52 +03:00
Ivailo Monev
59bd1359f9 kio: remove code for unsupported info and man KIO slaves
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-18 03:29:18 +03:00
Ivailo Monev
32cc183690 kio: KRemoteEncoding::decode() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-16 18:57:54 +03:00
Ivailo Monev
feb0869d29 kio: avoid temporary in kfilematadata_exiv2 plugin
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-16 01:02:53 +03:00
Ivailo Monev
e29151a728 kutils: essentially KExiv2 rewrite
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-16 00:59:16 +03:00
Ivailo Monev
301bc3a1e5 kutils: new kemail library
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-15 05:03:10 +03:00
Ivailo Monev
368cfcd2f4 kio: correct arguments passed to konsole executable
fixes starting programs that require terminal from Plasma menu for
example

%i no longer expands to "--icon '%i'", I changed it to be so some time ago
so that different arguments can be passed along with %i to programs if they
support icon option but with different option name

%m is deprecated, for reference:
https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s07.html

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-14 22:52:06 +03:00
Ivailo Monev
decb354a0d generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-14 16:16:22 +03:00
Ivailo Monev
30a64d7b4a kio: register KUrl as metatype from the KUrlRequesterPrivate constructor
that way it is registered from any KUrlRequester constructor not the just
one that takes two QWidget arguments

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-14 02:59:38 +03:00
Ivailo Monev
abe3e49268 kdecore: implement KShell::envExpand() and use it in KConfig and KUrlCompletion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-11 01:19:02 +03:00
Ivailo Monev
2a2f13addc kio: move static functions to the top of kurlcompletion source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-10 23:15:00 +03:00
Ivailo Monev
704ef230d5 generic: make use of KUser and KUserGroup
eventually KUser and KUserGroup will use getpwnam_r(), getgrnam_r(), etc. for thread safety

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-10 21:05:19 +03:00
Ivailo Monev
10ec136182 kio: make use of KShell::tildeExpand() in expandTilde() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-10 19:36:53 +03:00
Ivailo Monev
747df5dee8 generic: use KStandardDirs::findExe() instead of resource lookup to find kioslave
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-10 18:31:39 +03:00
Ivailo Monev
55699fc8a3 kdecore: remove the unused "html" and hidden "home" standard directory resources
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-10 04:15:48 +03:00
Ivailo Monev
93bc6749ab kio: remove extra dot in temporary file template
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-07 14:16:14 +03:00
Ivailo Monev
ce8875380f kio: make use of KTemporaryFile::filePath()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-07 13:46:45 +03:00
Ivailo Monev
1bcd336015 kio: make use of KTemporaryFile::filePath()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-07 05:40:41 +03:00
Ivailo Monev
451301f58f kio: implement fonts meta information extractor via Freetype
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-06 20:51:32 +03:00
Ivailo Monev
c27d7e7ee6 kio: add meta information entries for fonts
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-06 15:20:50 +03:00
Ivailo Monev
8bb2fec99a generic: drop support for archive KIO slaves
KIO was designed around remote protocols and is very much not suitable for
archive browsing for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-06 14:41:24 +03:00
Ivailo Monev
a3f47ed50f kio: warn when statvfs() fails in KDiskFreeSpaceInfo::freeSpaceInfo()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-04 03:05:16 +03:00
Ivailo Monev
f8443ced0b kio: keep reference to the QByteArray object in KDiskFreeSpaceInfo::freeSpaceInfo()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-04 03:04:43 +03:00
Ivailo Monev
9b07290ada kdeui: prefix HOME_URL, BUG_REPORT_URL and BUG_REPORT_EMAIL definitions with "KDE_"
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-03 16:25:13 +03:00
Ivailo Monev
894a2d52bb kdecore: remove KLocale getters related to text codec
see the comment in KLocalePrivate::initEncoding()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-30 20:00:04 +03:00
Ivailo Monev
c78363de67 kdecore: deal with TODO related to KService::newServicePath()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-29 23:07:31 +03:00
Ivailo Monev
b40ed43aa4 cmake: new baseline kde4_optional_add_subdirectory() macro replacing macro_optional_add_subdirectory()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-27 17:25:09 +03:00