TODO from https://github.com/fluxer/katana/issues/7. I've decided to
keep KDE4 and Katie libraries as PUBLIC, all other libraries as PRIVATE
for that and not use INTERFACE at all since that will not require a lot
of changes to all other sub-projects (kde-baseapps, kde-workspace and
kde-extraapps) build systems.
MusicBrainz5 CMake module was also rewritten as the actual library that
should be linked to is libmusicbrainz5cc, libmusicbrainz5 is the C
version of it.
common checks for X11 extensions where move to main config header,
eventually to be moved to separate config-x11 header.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
otherwise the constructor can be shadowed by the default QSettings
constructor which does not take any arguments at all
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
most of the changes were done trought Katie's namefsck script which
convertes forward class declarations to include directives, however
other fixes here and there were needed as well as some questionable
changes to Q_DECLARE_TYPEINFO() macro calls because they most likely
have to do the namespacing themselfs (QT_BEGIN/END_NAMESPACE, and
probably will be in Katie) meaning that some of the changes may be
temporary and reverted later.
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
the module has some use cases, like avoiding linkage to the
kmediaplayer library which links to MPV, which links to FFmpeg.
and since the module is loaded on demand there should be no change
in terms of resources usage untils it is used, in which case it
will use (roughly) the resources of single MPV instance until
kded4 quits.
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
now when the slider is being dragged the player does not continuesly seek,
it does it only when the slider is released to avoid bad noise during the
quick seeking.
also, the controls will not be hidden now while any of the controls is
being pressed by the user, it's still not perfect because once the user
releases it the controls will be hidden and then (most likely) shown again
(unless no mouse was used for the interactive, e.g. tab for selection and
then space for interaction) but that will require even more connections
to the controls so I'm leaving it as is for now.
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
WId should be unsigned long for Q_WS_X11 (see qwindowdefs.h from Qt4) but
MPV requiers that the type is intptr_t (see options.rst from MPV) yet none
of them works but quintptr does - it's magic.
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
neither the compiler would complain (QVariant can hold custom types via
runtime registration) nor runtime warning about invalid QVariant was issued
for this (because it was casted to something, not sure what but it was the
wrong type)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
