Commit graph

270 commits

Author SHA1 Message Date
Ivailo Monev
f1df519d20 kdecore: test qHash() for KUrl
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-25 06:31:53 +03:00
Ivailo Monev
7e056ee4a1 kdecore: use KUrl::url() for the hash
otherwise different user, password, host or port will not result in
different hash, duh

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-25 05:11:39 +03:00
Ivailo Monev
0917277201 kdecore: remove unused KUrl::CompareWithoutFragment enum
doubles as optimization for KUrl comparisons

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-25 05:05:08 +03:00
Ivailo Monev
94a5a3f641 kdecore: remove redundant KUrl destructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-25 04:00:49 +03:00
Ivailo Monev
a7fe953ca9 kdecore: ensure KUrl::url() handles only full paths to local files specially
it's dirty, it's magic, it's a fix

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-25 03:15:21 +03:00
Ivailo Monev
728dc0838e kdecore: remove unused headers inclusions in kurl source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 23:20:20 +03:00
Ivailo Monev
13fdc7b7cd kdecore: do not prettify the URL in KUrl::pathOrUrl()
here is how to make browsers barf - check the tooltip and where the browser
thinks the URL points to:
https://ibb.co/cyhwppK

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 23:13:38 +03:00
Ivailo Monev
ef02376c35 kdecore: add KUrl query and fragment test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 21:25:20 +03:00
Ivailo Monev
0a5fadde75 kdecore: do not change the scheme from KUrl::cleanPath()
the fact that many KUrl methods change it (by calling KUrl::setPath()) is
just bonkers but that's how it was implemented - to convert to file scheme
from setters

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 20:44:03 +03:00
Ivailo Monev
78c109df85 kdecore: more compatible KUrl
abusing the QUrl path for local files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 20:10:09 +03:00
Ivailo Monev
8f348b4c5b kdecore: remove FIXME for KUrl
so far so good:
https://ibb.co/TYN4z3x

now on to the quircks..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 03:00:21 +03:00
Ivailo Monev
ea02aa2c1a kdecore: fix regression since 7b8ff71eba
oops

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 00:53:35 +03:00
Ivailo Monev
341e16d4c6 kdecore: update comment in KUrl::prettyUrl()
konqueror is no more

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 23:58:08 +03:00
Ivailo Monev
5e4732f809 kdecore: KUrl::List from QList<QUrl> optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 23:55:19 +03:00
Ivailo Monev
c81c3bd71d kdecore use the new QUrl::AddTrailingSlash enum
requires the following commit from Katie repo:
3369835da10412451d082713433321a72f25e0df

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 23:08:09 +03:00
Ivailo Monev
7b8ff71eba kdecore: KUrl rewrite to output encoded strings
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 22:33:18 +03:00
Ivailo Monev
b4861f86d5 kdecore: rename variable in uriListData()
bad variable naming - clashes with the function name and inconsistent

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 18:22:41 +03:00
Ivailo Monev
840f3a3b68 kdecore: assume strings passed to KUrl constructors are percentage-encoded
for compat, test case for it is KUrlMimeTest::testURLList()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 18:14:39 +03:00
Ivailo Monev
30cd526513 kdecore: set the scheme to file when it KUrl is constructor from string and it is empty
the test case for it is "local file 3" case of KUrl::cleanPath() test and
the KUrlNavigator test

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 17:53:20 +03:00
Ivailo Monev
ed4ae48705 kdecore: KUrl test-anew
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 14:44:33 +03:00
Ivailo Monev
9f05a33ee6 generic: build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 14:08:10 +03:00
Ivailo Monev
34b75e4f7f kdecore: different take on KUrl::upUrl()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 13:08:49 +03:00
Ivailo Monev
e2a0be91ae kdecore: KTemporaryFile::filePath() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 13:00:14 +03:00
Ivailo Monev
fab969cf3e kdecore: remove most of the KUrl compat methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 12:26:07 +03:00
Ivailo Monev
10eb45205c kdecore: move static KUrl functions to the top
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 11:47:07 +03:00
Ivailo Monev
1e99d802a7 kdecore: KUrl::List to QList<QUrl> conversion optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 11:46:34 +03:00
Ivailo Monev
3cdc7da129 kdecore: simplify KUrl by using QDir::cleanPath() and QUrl::resolved()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 11:30:35 +03:00
Ivailo Monev
639d8def3b generic: adjust to QUrl changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 15:23:29 +03:00
Ivailo Monev
a424284337 kdecore: remove unused and redundant KUrl methods
plus some disabled bits

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 13:42:25 +03:00
Ivailo Monev
7e60364ce0 kdecore: initialize variables in KProcess::startDetached() methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-15 07:26:18 +03:00
Ivailo Monev
afa983f02f kdecore: remove unused buffer in KLockFilePrivate::tryLock()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-15 07:25:41 +03:00
Ivailo Monev
add0b2cad3 kdecore: drop KProcess channel forward feature
was used only by klipper, also a program writing something ment for
stderr to stdout (and vice versa) is doing something wrong already

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 23:44:38 +03:00
Ivailo Monev
2f6dae867e kdecore: mark the bottom of KProcess::setOutputChannelMode() as unreachable
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 23:27:53 +03:00
Ivailo Monev
fdd0df9586 kdecore: remove unused header inclusion in kprocess source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 23:26:43 +03:00
Ivailo Monev
e1a01725c2 kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 23:26:00 +03:00
Ivailo Monev
6ba957038d kdecore: KLockFile optimization
also not storing the host name because it serves no real purpose other than
being a possible source of problem (hostname change?), copyrighting it to
me because there is nothing relevant left of the original implementation

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 03:34:48 +03:00
Ivailo Monev
ca379a7d67 kdecore: tweak the KLockFile sleep time
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 02:43:21 +03:00
Ivailo Monev
e978590acd generic: define KDE_DEFAULT_DEBUG_AREA in the main build file for each library
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-09 23:43:20 +03:00
Ivailo Monev
4966846ed7 generic: drop sub-URL support
was used by the archive KIO slave for example (which is no longer
maintained)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-06 08:34:19 +03:00
Ivailo Monev
49904fd247 kdecore: KTemporaryFile optimization
assuming that default constructed KComponentData is invalid and the
temporary directory is the same as that returned by the global
KStandardDirs isntance the private data pointer is redundant

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-04 09:37:45 +03:00
Ivailo Monev
dcdc02baf2 kdecore: remove archive KIO slaves leftovers
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-01-02 07:54:18 +02:00
Ivailo Monev
e921df61cf kdecore: implement option to recurse into sub-directories from KDirWatch::addDir()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-21 11:47:56 +02:00
Ivailo Monev
6160da3e6a kdecore: remove the paths from the internal KDirWatch list
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-21 11:18:24 +02:00
Ivailo Monev
03aba012a0 kdecore: KDirWatch rewrite
I rewrote QFileSystemWatcher some time ago for it to be able to watch
non-existing directories, did rewrite KDirWatch too to not use FAM
and inotify making the created() and deleted() signals non-operational
(with the plan to maybe implement them in QFileSystemWatcher but that
will be hack-ish for directories with stat()-based implementation)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-21 00:24:49 +02:00
Ivailo Monev
90c57ada83 kdecore: unregister the helper service and object from KAuthorization destructor
I should (ab)use the object name for more things

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 08:19:15 +02:00
Ivailo Monev
f9171a653f kdecore: cache the debug area devices as KDebugConfig member
reducing the global statics used by KDebug to two - one for the null device
and one for the configuration and internal cache

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 07:42:40 +02:00
Ivailo Monev
6e8e2238cc kdecore: add comment to KDebug() default switch case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 04:51:47 +02:00
Ivailo Monev
f80529f5cd kdecore: replace hard-codec KDebug output types with enums
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 02:44:44 +02:00
Ivailo Monev
9b41127ecb generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 00:40:18 +02:00
Ivailo Monev
3a6ed6d1e1 kdecore: KDirWatch::addDir() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 11:12:13 +02:00