because KMimeType::iconNameForUrl() really cannot determine the MIME type
reliably for non-local URLs (can only guess from the name), also the MIME
type is known by KFileItem for such meaning it will not have to be
determined again
on a side note the documentation of the method mentions overlays - that is
not a thing for KMimeType::iconNameForUrl()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
none of the bits actually belong there but KIO was designed in such a way
that it is not part of kdecore and as such KMimeType::iconNameForUrl() will
have to handle the cases for KIO (except overlays maybe)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
more conditions are added into the mix but that is how it should be,
KMimeType::iconNameForUrl() barely covers some cases (no overlays?)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
so that classes that inherit from it and use D-Bus interfaces can return
true if the interface is not valid as may be the case for
KPlasmaJobTracker, that way KDynamicJobTracker will not have to create
QDBusInterface object to decide which tracker to use
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
also active and queued threads remain unchanged by the method, events
processing continues too (at a certain interval)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
any program launched with temporary file (as per the spec) argument
(because it does not support %u or %U) should not be responsible for
deleting the file, klauncher already handles that thus the option is
redundant. I don't know how other implemenatations (of program launchers)
do it but I cannot say I care either
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
there are other conditions that are checked tho like the allowed
environment but this one is Katana specific and unused so
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
two things doing the same thing - one has to go away. also KRun does not
fork and the launched service/application lifetime was bound to the
process launching it, that is not the case with klauncher - it is bound
to the session (in the usual case)
a few things on the TODO list but mostly for services/applications
lacking features
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
every comment about X11 and session management in general claims it was
broken, not going to claim otherwise. everything that does not use
KApplication shall not be involved into session management now and gets
the middle finger (SIGTERM or SIGKILL) after 5 sec by klauncher when the
session is done
also session management has to be explicitly enabled by applications
now, disabled by default
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
some logging to the generic debug area, some to the services debug area and
some to the kbuildsycoca debug area..
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
more accurate probing then before, notably by probing the file content
from the file slave (only the name was checked before because the
filepath was not a full path in some cases and the file could not be
open)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>