generic: various cleanups

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
This commit is contained in:
Ivailo Monev 2019-05-04 22:25:48 +00:00
parent bc28637562
commit e189969fd1
5 changed files with 10 additions and 16 deletions

View file

@ -151,10 +151,10 @@ class CDInfoDialog::Private
QList<QStandardItem *> trackItems = QList<QStandardItem *>();
TrackInfo ti(info.track(i));
QStandardItem *trackNumberItem = new QStandardItem(QString().sprintf("%02d", i + 1));
trackNumberItem->setEditable(FALSE);
trackNumberItem->setEditable(false);
trackItems << trackNumberItem;
QStandardItem *trackLengthItem = new QStandardItem(framesTime(trackStartFrames[i + 1] - trackStartFrames[i]));
trackLengthItem->setEditable(FALSE);
trackLengthItem->setEditable(false);
trackItems << trackLengthItem;
QStandardItem *trackTitleItem = new QStandardItem(ti.get(Title).toString());
trackItems << trackTitleItem;

View file

@ -178,24 +178,21 @@ KCModule::~KCModule()
void KCModule::load()
{
KConfigDialogManager* manager;
Q_FOREACH( manager , d->managers )
Q_FOREACH(KConfigDialogManager *manager , d->managers )
manager->updateWidgets();
emit( changed( false ));
}
void KCModule::save()
{
KConfigDialogManager* manager;
Q_FOREACH( manager , d->managers )
Q_FOREACH(KConfigDialogManager *manager , d->managers )
manager->updateSettings();
emit( changed( false ));
}
void KCModule::defaults()
{
KConfigDialogManager* manager;
Q_FOREACH( manager , d->managers )
Q_FOREACH(KConfigDialogManager *manager , d->managers )
manager->updateWidgetsDefault();
}
@ -206,8 +203,7 @@ void KCModule::widgetChanged()
bool KCModule::managedWidgetChangeState() const
{
KConfigDialogManager* manager;
Q_FOREACH( manager , d->managers )
Q_FOREACH(KConfigDialogManager *manager , d->managers )
{
if ( manager->hasChanged() )
return true;

View file

@ -298,7 +298,7 @@ void KMenu::keyPressEvent(QKeyEvent* e)
d->keySeq += keyString;
const int seqLen = d->keySeq.length();
foreach (a, actions()) {
foreach (QAction *a, actions()) {
// don't search disabled entries
if (!a->isEnabled())
continue;

View file

@ -146,7 +146,7 @@ void BusyWidget::paint(QPainter *painter, const QStyleOptionGraphicsItem *option
if (!d->running && d->svg->hasElement("paused")) {
d->svg->paint(painter, spinnerRect, "paused");
} else {
if (!d->frames[intRotation]) {
if (d->frames[intRotation].isNull()) {
QPointF translatedPos(spinnerRect.width()/2, spinnerRect.height()/2);
d->frames[intRotation] = QPixmap(spinnerRect.size().toSize());

View file

@ -164,8 +164,7 @@ FakeDevice *FakeManager::findDevice(const QString &udi)
QStringList FakeManager::findDeviceStringMatch(const QString &key, const QString &value)
{
QStringList result;
FakeDevice *device;
foreach (device, d->loadedDevices)
foreach (FakeDevice *device, d->loadedDevices)
{
if (device->property(key).toString() == value)
{
@ -179,8 +178,7 @@ QStringList FakeManager::findDeviceStringMatch(const QString &key, const QString
QStringList FakeManager::findDeviceByDeviceInterface(Solid::DeviceInterface::Type type)
{
QStringList result;
FakeDevice *device;
foreach (device, d->loadedDevices)
foreach (FakeDevice *device, d->loadedDevices)
{
if (device->queryDeviceInterface(type))
{