From da2cb4b8487af81d3b6dc567372a4b80e5be8046 Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Mon, 14 Aug 2023 16:17:47 +0300 Subject: [PATCH] plasma: do not check if the current "requires configuration" state matches from Plasma::Applet::setConfigurationRequired() because the message overlay is used for both (error) messages and to show configuration button (with optional message) and the overlay may have to be recreated to override the one previously setup by Plasma::Applet::showMessage() (e.g. when an applet is created, message is shown and then a configuration overlay but with the internal "requries configuration" state not changing) Signed-off-by: Ivailo Monev --- plasma/applet.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/plasma/applet.cpp b/plasma/applet.cpp index 2503b253..db2e07d8 100644 --- a/plasma/applet.cpp +++ b/plasma/applet.cpp @@ -991,10 +991,6 @@ bool Applet::configurationRequired() const void Applet::setConfigurationRequired(bool needsConfig, const QString &reason) { - if (d->needsConfig == needsConfig) { - return; - } - d->needsConfig = needsConfig; if (!needsConfig) {