Katana_mirror/kdelibs
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kdelibs.git synced 2025-02-24 10:52:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kdecore: do not deep-copy objects when iterating

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2022-09-21 04:09:59 +03:00
parent 01d40bf689
commit d3cb89b9e2
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
kdecore/io/kurl.cpp
View file

@ -186,7 +186,7 @@ QStringList KUrl::List::toStringList(KUrl::AdjustPathOption trailing) const
static QByteArray uriListData(const KUrl::List& urls) static QByteArray uriListData(const KUrl::List& urls)
{ {
QByteArray uriListData; QByteArray uriListData;
foreach(const KUrl uit, urls) { foreach(const KUrl &uit, urls) {
// Get each URL encoded in utf8 - and since we get it in escaped // Get each URL encoded in utf8 - and since we get it in escaped
// form on top of that, .toLatin1() is fine. // form on top of that, .toLatin1() is fine.
uriListData += uit.toMimeDataString().toLatin1(); uriListData += uit.toMimeDataString().toLatin1();
@ -306,7 +306,7 @@ KUrl::List KUrl::List::fromMimeData(const QMimeData *mimeData,
const QStringList lst = str.split(QLatin1String("$@@$")); const QStringList lst = str.split(QLatin1String("$@@$"));
bool readingKey = true; // true, then false, then true, etc. bool readingKey = true; // true, then false, then true, etc.
QString key; QString key;
foreach(const QString it, lst) { foreach(const QString &it, lst) {
if ( readingKey ) if ( readingKey )
key = it; key = it;
else else
@ -748,7 +748,7 @@ QString KUrl::fileEncoding() const
q = q.mid(1); q = q.mid(1);
const QStringList args = q.split(QLatin1Char('&'), QString::SkipEmptyParts); const QStringList args = q.split(QLatin1Char('&'), QString::SkipEmptyParts);
foreach(const QString it, args) foreach(const QString &it, args)
{ {
QString s = QUrl::fromPercentEncoding(it.toLatin1()); QString s = QUrl::fromPercentEncoding(it.toLatin1());
if (s.startsWith(QLatin1String("charset="))) if (s.startsWith(QLatin1String("charset=")))
@ -1466,7 +1466,7 @@ QMap< QString, QString > KUrl::queryItems( const QueryItemsOptions &options ) co
QMap< QString, QString > result; QMap< QString, QString > result;
const QStringList items = strQueryEncoded.split( QLatin1Char('&'), QString::SkipEmptyParts ); const QStringList items = strQueryEncoded.split( QLatin1Char('&'), QString::SkipEmptyParts );
foreach(const QString it, items) { foreach(const QString &it, items) {
const int equal_pos = it.indexOf(QLatin1Char('=')); const int equal_pos = it.indexOf(QLatin1Char('='));
if ( equal_pos > 0 ) { // = is not the first char... if ( equal_pos > 0 ) { // = is not the first char...
QString name = it.left( equal_pos ); QString name = it.left( equal_pos );