From d181c8678c9b24d93c40f2c33b84cdd618cd9295 Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Thu, 10 Aug 2023 20:10:09 +0300 Subject: [PATCH] kdecore: do not deep-copy the QString objects in KAboutData::translators() Signed-off-by: Ivailo Monev --- kdecore/kernel/kaboutdata.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kdecore/kernel/kaboutdata.cpp b/kdecore/kernel/kaboutdata.cpp index 9decf0be..f200ea09 100644 --- a/kdecore/kernel/kaboutdata.cpp +++ b/kdecore/kernel/kaboutdata.cpp @@ -606,11 +606,11 @@ QList KAboutData::translators() const emailList = translatorEmail.split(QString(QLatin1Char(',')), QString::KeepEmptyParts); } - foreach ( const QString nit, nameList ) + foreach ( const QString &nit, nameList ) { // overkill? QString email; - foreach (const QString eit, emailList ) + foreach (const QString &eit, emailList ) { email = eit; }