From bafbb328e9f6a7e1b441b0d1a5e32236438be7e8 Mon Sep 17 00:00:00 2001
From: Ivailo Monev <xakepa10@gmail.com>
Date: Mon, 10 Oct 2022 01:34:47 +0300
Subject: [PATCH] kutils: return boolean from KDNSSD::startBrowse() indicating
 success or failure

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
---
 kutils/kdnssd/kdnssd.cpp | 15 +++++++++------
 kutils/kdnssd/kdnssd.h   |  2 +-
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/kutils/kdnssd/kdnssd.cpp b/kutils/kdnssd/kdnssd.cpp
index 775599f7..96daee00 100644
--- a/kutils/kdnssd/kdnssd.cpp
+++ b/kutils/kdnssd/kdnssd.cpp
@@ -55,7 +55,7 @@ public:
     bool publishService(const QByteArray &servicetype, const uint serviceport, const QString &servicename);
     bool unpublishService();
 
-    void startBrowse(const QByteArray &servicetype);
+    bool startBrowse(const QByteArray &servicetype);
     QList<KDNSSDService> services() const;
     QString errorString() const;
 
@@ -197,7 +197,7 @@ bool KDNSSDPrivate::unpublishService()
 #endif
 }
 
-void KDNSSDPrivate::startBrowse(const QByteArray &servicetype)
+bool KDNSSDPrivate::startBrowse(const QByteArray &servicetype)
 {
 #if defined(HAVE_AVAHI)
     // qDebug() << Q_FUNC_INFO << servicetype;
@@ -213,7 +213,7 @@ void KDNSSDPrivate::startBrowse(const QByteArray &servicetype)
         );
         if (!avahiservice) {
             m_errorstring = getAvahiClientError(m_avahiclient);
-            return;
+            return false;
         }
 
         m_pollcounter++;
@@ -241,7 +241,7 @@ void KDNSSDPrivate::startBrowse(const QByteArray &servicetype)
         );
         if (!avahibrowser) {
             m_errorstring = getAvahiClientError(m_avahiclient);
-            return;
+            return false;
         }
 
         m_pollcounter++;
@@ -252,6 +252,9 @@ void KDNSSDPrivate::startBrowse(const QByteArray &servicetype)
 
         avahi_service_browser_free(avahibrowser);
     }
+    return true;
+#else
+    return false;
 #endif // HAVE_AVAHI
 }
 
@@ -470,9 +473,9 @@ QList<KDNSSDService> KDNSSD::services() const
     return d->services();
 }
 
-void KDNSSD::startBrowse(const QByteArray &servicetype)
+bool KDNSSD::startBrowse(const QByteArray &servicetype)
 {
-    d->startBrowse(servicetype);
+    return d->startBrowse(servicetype);
 }
 
 QString KDNSSD::errorString() const
diff --git a/kutils/kdnssd/kdnssd.h b/kutils/kdnssd/kdnssd.h
index 3606bc63..a421aed7 100644
--- a/kutils/kdnssd/kdnssd.h
+++ b/kutils/kdnssd/kdnssd.h
@@ -90,7 +90,7 @@ public:
         When the query is done @p finished() signal is emited and the result can be retrieved via
         the @p services() method.
     */
-    void startBrowse(const QByteArray &servicetype = QByteArray());
+    bool startBrowse(const QByteArray &servicetype = QByteArray());
     QList<KDNSSDService> services() const;
 
     /*!