Katana_mirror/kdelibs
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kdelibs.git synced 2025-02-24 02:42:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

plasma: Plasma::ScrollWidgetPrivate::createFlickAnimations() optimization

Browse source 
why is it creating QString to convert it multiple times to QByteArray?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2024-05-22 12:44:49 +03:00
parent 53369ab8d7
commit ab65afa79b
1 changed files with 10 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
plasma/widgets/scrollwidget.cpp
View file

@ -674,13 +674,11 @@ public:
void createFlickAnimations() void createFlickAnimations()
{ {
if (widget.data()) { if (widget.data()) {
QString xProp = QString::fromLatin1("x"); const QByteArray xProp("x");
QString yProp = QString::fromLatin1("y"); const QByteArray yProp("y");
flickAnimationX = new QPropertyAnimation(widget.data(), flickAnimationX = new QPropertyAnimation(widget.data(), xProp, widget.data());
xProp.toLatin1(), widget.data()); flickAnimationY = new QPropertyAnimation(widget.data(), yProp, widget.data());
flickAnimationY = new QPropertyAnimation(widget.data(),
yProp.toLatin1(), widget.data());
QObject::connect(flickAnimationX, SIGNAL(finished()), QObject::connect(flickAnimationX, SIGNAL(finished()),
q, SLOT(fixupX())); q, SLOT(fixupX()));
QObject::connect(flickAnimationY, SIGNAL(finished()), QObject::connect(flickAnimationY, SIGNAL(finished()),
@ -703,14 +701,10 @@ public:
fixupAnimation.groupX = new QSequentialAnimationGroup(widget.data()); fixupAnimation.groupX = new QSequentialAnimationGroup(widget.data());
fixupAnimation.groupY = new QSequentialAnimationGroup(widget.data()); fixupAnimation.groupY = new QSequentialAnimationGroup(widget.data());
fixupAnimation.startX = new QPropertyAnimation(widget.data(), fixupAnimation.startX = new QPropertyAnimation(widget.data(), xProp, widget.data());
xProp.toLatin1(), widget.data()); fixupAnimation.startY = new QPropertyAnimation(widget.data(), yProp, widget.data());
fixupAnimation.startY = new QPropertyAnimation(widget.data(), fixupAnimation.endX = new QPropertyAnimation(widget.data(), xProp, widget.data());
yProp.toLatin1(), widget.data()); fixupAnimation.endY = new QPropertyAnimation(widget.data(), yProp, widget.data());
fixupAnimation.endX = new QPropertyAnimation(widget.data(),
xProp.toLatin1(), widget.data());
fixupAnimation.endY = new QPropertyAnimation(widget.data(),
yProp.toLatin1(), widget.data());
fixupAnimation.groupX->addAnimation( fixupAnimation.groupX->addAnimation(
fixupAnimation.startX); fixupAnimation.startX);
fixupAnimation.groupY->addAnimation( fixupAnimation.groupY->addAnimation(
@ -725,10 +719,8 @@ public:
fixupAnimation.startY->setEasingCurve(QEasingCurve::InQuad); fixupAnimation.startY->setEasingCurve(QEasingCurve::InQuad);
fixupAnimation.endY->setEasingCurve(QEasingCurve::OutQuint); fixupAnimation.endY->setEasingCurve(QEasingCurve::OutQuint);
fixupAnimation.snapX = new QPropertyAnimation(widget.data(), fixupAnimation.snapX = new QPropertyAnimation(widget.data(), xProp, widget.data());
xProp.toLatin1(), widget.data()); fixupAnimation.snapY = new QPropertyAnimation(widget.data(), yProp, widget.data());
fixupAnimation.snapY = new QPropertyAnimation(widget.data(),
yProp.toLatin1(), widget.data());
fixupAnimation.snapX->setEasingCurve(QEasingCurve::InOutQuad); fixupAnimation.snapX->setEasingCurve(QEasingCurve::InOutQuad);
fixupAnimation.snapY->setEasingCurve(QEasingCurve::InOutQuad); fixupAnimation.snapY->setEasingCurve(QEasingCurve::InOutQuad);