Katana_mirror/kdelibs
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kdelibs.git synced 2025-02-24 02:42:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kded: do not deep-copy QString objects when iterating

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2022-12-22 01:03:54 +02:00
parent 7b6f2c92d8
commit a4ac5fbb46
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
kded/vfolder_menu.cpp
View file

@ -55,7 +55,7 @@ static void foldNode(QDomElement &docElem, QDomElement &e, QMap<QString,QDomElem
static void replaceNode(QDomElement &docElem, QDomNode &n, const QStringList &list, const QString &tag) static void replaceNode(QDomElement &docElem, QDomNode &n, const QStringList &list, const QString &tag)
{ {
foreach(const QString it, list) foreach(const QString &it, list)
{ {
QDomElement e = docElem.ownerDocument().createElement(tag); QDomElement e = docElem.ownerDocument().createElement(tag);
QDomText txt = docElem.ownerDocument().createTextNode(it); QDomText txt = docElem.ownerDocument().createTextNode(it);
@ -622,7 +622,7 @@ VFolderMenu::mergeMenus(QDomElement &docElem, QString &name)
QString dir = absoluteDir(e.text(), e.attribute("__BaseDir"), true); QString dir = absoluteDir(e.text(), e.attribute("__BaseDir"), true);
const QStringList dirs = KGlobal::dirs()->findDirs("xdgconf-menu", dir); const QStringList dirs = KGlobal::dirs()->findDirs("xdgconf-menu", dir);
foreach(const QString it, dirs) foreach(const QString &it, dirs)
{ {
registerDirectory(it); registerDirectory(it);
} }
@ -640,7 +640,7 @@ VFolderMenu::mergeMenus(QDomElement &docElem, QString &name)
KStandardDirs::NoDuplicates, fileList); KStandardDirs::NoDuplicates, fileList);
} }
foreach(const QString it, fileList) foreach(const QString &it, fileList)
{ {
pushDocInfo(it); pushDocInfo(it);
mergeFile(docElem, n); mergeFile(docElem, n);
@ -789,7 +789,7 @@ VFolderMenu::locateDirectoryFile(const QString &fileName)
} }
// First location in the list wins // First location in the list wins
foreach(const QString it, m_directoryDirs) foreach(const QString &it, m_directoryDirs)
{ {
const QString tmp = it+fileName; const QString tmp = it+fileName;
if (KGlobal::dirs()->exists(tmp)) if (KGlobal::dirs()->exists(tmp))
@ -1373,7 +1373,7 @@ VFolderMenu::parseMenu(const QString &file)
m_appsInfo = 0; m_appsInfo = 0;
const QStringList dirs = KGlobal::dirs()->resourceDirs("xdgconf-menu"); const QStringList dirs = KGlobal::dirs()->resourceDirs("xdgconf-menu");
foreach(const QString it, dirs) { foreach(const QString &it, dirs) {
registerDirectory(it); registerDirectory(it);
} }