diff --git a/CMakeLists.txt b/CMakeLists.txt index 09234f4c..aa678b3c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -28,15 +28,6 @@ endif(KDE_PLATFORM_FEATURE_DISABLE_DEPRECATED) ############### Give the user the option to build the udisks2 solid backend instead of the udisks backend ############### option(WITH_SOLID_UDISKS2 "Enable the udisks2 solid backend instead" "ON") -############### Misc options ############### - -# FIXME: are those needed globally? maybe define them in kglobalsettings.h for external use? -set(BUG_REPORT_URL "https://github.com/fluxer/katana/issues" - CACHE STRING "Specifies the URL that will be used to report issues.") - -set(BUG_REPORT_EMAIL "xakepa10@gmail.com" - CACHE STRING "Specifies the E-Mail that will be used as contact for issues.") - ############### Load the CTest options ############### # CTestCustom.cmake has to be in the CTEST_BINARY_DIR. # in the KDE build system, this is the same as CMAKE_BINARY_DIR. @@ -239,7 +230,6 @@ configure_file(config-prefix.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-prefix.h configure_file(config-compiler.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-compiler.h ) configure_file(config-pty.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-pty.h ) configure_file(kdemacros.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/kdemacros.h ) -configure_file(config-misc.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-misc.h) # these two calls here should go somewhere else, Alex check_library_exists(nsl gethostbyname "" HAVE_NSL_LIBRARY) diff --git a/config-misc.h.cmake b/config-misc.h.cmake deleted file mode 100644 index 58de2823..00000000 --- a/config-misc.h.cmake +++ /dev/null @@ -1,2 +0,0 @@ -#define BUG_REPORT_URL "${BUG_REPORT_URL}" -#define BUG_REPORT_EMAIL "${BUG_REPORT_EMAIL}" diff --git a/kconf_update/CMakeLists.txt b/kconf_update/CMakeLists.txt index 6bf3bf1f..9737efe3 100644 --- a/kconf_update/CMakeLists.txt +++ b/kconf_update/CMakeLists.txt @@ -1,7 +1,7 @@ project(kconf_update) -include_directories( ${KDE4_KDECORE_INCLUDES} ) +include_directories( ${KDE4_KDECORE_INCLUDES} ${KDE4_KDEUI_INCLUDES} ) ########### next target ############### diff --git a/kconf_update/tests/test_kconf_update.cpp b/kconf_update/tests/test_kconf_update.cpp index 4eeba312..fc9f0d0a 100644 --- a/kconf_update/tests/test_kconf_update.cpp +++ b/kconf_update/tests/test_kconf_update.cpp @@ -40,7 +40,10 @@ static void writeFile(const QString &path, const QString &content) { QFile file(path); bool ok = file.open(QIODevice::WriteOnly); - Q_ASSERT(ok); + // prevent a compiler warning, marvelous isn't it? + if (!ok) { + Q_ASSERT(ok); + } file.write(content.toUtf8()); } diff --git a/kdecore/CMakeLists.txt b/kdecore/CMakeLists.txt index fe3b859b..e0766d0a 100644 --- a/kdecore/CMakeLists.txt +++ b/kdecore/CMakeLists.txt @@ -49,7 +49,7 @@ include(util/ConfigureChecks.cmake) configure_file(util/config-util.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-util.h) -include_directories( ${KDE4_KDECORE_INCLUDES} ) +include_directories( ${KDE4_KDECORE_INCLUDES} ${KDE4_KDEUI_INCLUDES}) include_directories( ${ZLIB_INCLUDE_DIR} ) include_directories( ${QT_INCLUDES} ) diff --git a/kdecore/kernel/kaboutdata.h b/kdecore/kernel/kaboutdata.h index cff560e2..16e310bf 100644 --- a/kdecore/kernel/kaboutdata.h +++ b/kdecore/kernel/kaboutdata.h @@ -26,12 +26,12 @@ #include #include +#include + // Qt #include #include -#include - template class QList; class QVariant; class KAboutData; diff --git a/kdecore/kernel/kcmdlineargs.cpp b/kdecore/kernel/kcmdlineargs.cpp index 36aca082..9e0f2e6d 100644 --- a/kdecore/kernel/kcmdlineargs.cpp +++ b/kdecore/kernel/kcmdlineargs.cpp @@ -18,9 +18,9 @@ #include "kcmdlineargs.h" #include +#include #include -#include #include @@ -913,7 +913,7 @@ KCmdLineArgsStatic::parseAllArgs() { if (!s->about->customAuthorTextEnabled ()) { - if (s->about->bugAddress().isEmpty() ) + if (s->about->bugAddress().isEmpty() || s->about->bugAddress() == QLatin1String(BUG_REPORT_EMAIL)) s->printQ( i18n( "Please use %1.\n", QLatin1String(BUG_REPORT_URL) ) ); else s->printQ( i18n( "Please report bugs to %1.\n", s->about->bugAddress()) ); diff --git a/kdecore/services/kmimetype.cpp b/kdecore/services/kmimetype.cpp index 8590dcd0..293e765b 100644 --- a/kdecore/services/kmimetype.cpp +++ b/kdecore/services/kmimetype.cpp @@ -17,7 +17,7 @@ * Boston, MA 02110-1301, USA. **/ -#include +#include #include "kmimetype.h" #include "kmimetype_p.h" diff --git a/kdecore/tests/kaboutdatatest.cpp b/kdecore/tests/kaboutdatatest.cpp index 92b0eb73..13912ba8 100644 --- a/kdecore/tests/kaboutdatatest.cpp +++ b/kdecore/tests/kaboutdatatest.cpp @@ -26,7 +26,7 @@ #include #include -#include +#include static const char AppName[] = "app"; static const char CatalogName[] = "Catalog"; diff --git a/kdeui/dialogs/kaboutapplicationdialog.cpp b/kdeui/dialogs/kaboutapplicationdialog.cpp index 2c3c363c..c2b86439 100644 --- a/kdeui/dialogs/kaboutapplicationdialog.cpp +++ b/kdeui/dialogs/kaboutapplicationdialog.cpp @@ -42,7 +42,7 @@ #include #include -#include +#include class KAboutApplicationDialog::Private { @@ -184,7 +184,7 @@ void KAboutApplicationDialog::Private::init( const KAboutData *ad, Options opt ) bugsLabel->setContentsMargins( 4, 2, 0, 4 ); bugsLabel->setOpenExternalLinks( true ); if (!aboutData->customAuthorTextEnabled()) { - if (aboutData->bugAddress().isEmpty()) + if (aboutData->bugAddress().isEmpty() || aboutData->bugAddress() == BUG_REPORT_EMAIL) bugsLabel->setText( i18n("Please use %2 to report bugs.\n", BUG_REPORT_URL, BUG_REPORT_URL) ); else { if( ( aboutData->authors().count() == 1 ) && diff --git a/kdeui/kernel/kglobalsettings.h b/kdeui/kernel/kglobalsettings.h index 615c21c1..1d41ac22 100644 --- a/kdeui/kernel/kglobalsettings.h +++ b/kdeui/kernel/kglobalsettings.h @@ -55,6 +55,10 @@ #define HTML_DEFAULT_VIEW_FANTASY_FONT "Sans Serif" #define HTML_DEFAULT_MIN_FONT_SIZE 7 +// misc overrides +#define BUG_REPORT_URL "https://github.com/fluxer/katana/issues" +#define BUG_REPORT_EMAIL "xakepa10@gmail.com" + class KUrl; class QColor; diff --git a/kdeui/widgets/khelpmenu.cpp b/kdeui/widgets/khelpmenu.cpp index 30088474..2850d8d4 100644 --- a/kdeui/widgets/khelpmenu.cpp +++ b/kdeui/widgets/khelpmenu.cpp @@ -53,7 +53,7 @@ #include #endif -#include +#include using namespace KDEPrivate; diff --git a/kio/kio/global.cpp b/kio/kio/global.cpp index c57f4718..35eba16c 100644 --- a/kio/kio/global.cpp +++ b/kio/kio/global.cpp @@ -20,8 +20,8 @@ #include "job.h" #include -#include +#include #include #include #include diff --git a/kio/misc/ksendbugmail/main.cpp b/kio/misc/ksendbugmail/main.cpp index 953f7a04..675008de 100644 --- a/kio/misc/ksendbugmail/main.cpp +++ b/kio/misc/ksendbugmail/main.cpp @@ -32,10 +32,10 @@ #include #include #include +#include #include "smtp.h" -#include void BugMailer::slotError(int errornum) { QString lstr; diff --git a/kunitconversion/CMakeLists.txt b/kunitconversion/CMakeLists.txt index d9690e43..77c19640 100644 --- a/kunitconversion/CMakeLists.txt +++ b/kunitconversion/CMakeLists.txt @@ -56,7 +56,7 @@ if(NOT KUNITCONVERSION_NO_SOLID) set(KUNITCONVERSION_EXTRA_LIBS ${KUNITCONVERSION_EXTRA_LIBS} ${KDE4_SOLID_LIBS}) endif(NOT KUNITCONVERSION_NO_SOLID) -include_directories (${CMAKE_SOURCE_DIR} ${KDE4_KDECORE_INCLUDES}) +include_directories (${CMAKE_SOURCE_DIR} ${KDE4_KDECORE_INCLUDES} ${KDE4_KDEUI_INCLUDES}) kde4_add_library(kunitconversion ${LIBRARY_TYPE} ${kunitconversion_LIB_SRCS}) diff --git a/kunitconversion/tests/CMakeLists.txt b/kunitconversion/tests/CMakeLists.txt index 6938d3a2..051817c5 100644 --- a/kunitconversion/tests/CMakeLists.txt +++ b/kunitconversion/tests/CMakeLists.txt @@ -1,5 +1,5 @@ set(EXECUTABLE_OUTPUT_PATH ${CMAKE_CURRENT_BINARY_DIR}) -include_directories(${KDE4_KDECORE_INCLUDES}) +include_directories(${KDE4_KDECORE_INCLUDES} ${KDE4_KDEUI_INCLUDES}) macro(KUNITCONVERSION_UNIT_TESTS) foreach(_testname ${ARGN})