Katana_mirror/kdelibs
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kdelibs.git synced 2025-02-23 18:32:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

plasma: manage storage jobs lifetime manually in storage job test

Browse source 
fixes test crashes, reference:
40999b8b80
https://github.com/fluxer/kdelibs/blame/master/kdecore/jobs/kjob.h#L252

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2021-09-02 22:43:53 +03:00
parent c3f8cfe6d2
commit a34f66beb9
1 changed files with 20 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
plasma/tests/storagetest.cpp
View file

@ -41,11 +41,11 @@ void StorageTest::store()
StorageJob *storageJob = qobject_cast<StorageJob *>(job);
QVERIFY(storageJob);
if (storageJob) {
storageJob->setData(m_data);
QVERIFY(storageJob->exec());
QVERIFY(storageJob->result().toBool());
}
storageJob->setAutoDelete(false);
storageJob->setData(m_data);
QVERIFY(storageJob->exec());
QVERIFY(storageJob->result().toBool());
storageJob->deleteLater();
}
void StorageTest::retrieve()
@ -57,11 +57,11 @@ void StorageTest::retrieve()
StorageJob *storageJob = qobject_cast<StorageJob *>(job);
QVERIFY(storageJob);
if (storageJob) {
QVERIFY(storageJob->exec());
QVERIFY(storageJob->result().type() != QVariant::Bool);
QCOMPARE(storageJob->data(), m_data);
}
storageJob->setAutoDelete(false);
QVERIFY(storageJob->exec());
QVERIFY(storageJob->result().type() != QVariant::Bool);
QCOMPARE(storageJob->data(), m_data);
storageJob->deleteLater();
}
void StorageTest::deleteEntry()
@ -73,11 +73,11 @@ void StorageTest::deleteEntry()
StorageJob *storageJob = qobject_cast<StorageJob *>(job);
QVERIFY(storageJob);
if (storageJob) {
storageJob->setData(m_data);
QVERIFY(storageJob->exec());
QVERIFY(storageJob->result().toBool());
}
storageJob->setAutoDelete(false);
storageJob->setData(m_data);
QVERIFY(storageJob->exec());
QVERIFY(storageJob->result().toBool());
storageJob->deleteLater();
op = storage.operationDescription("retrieve");
op.writeEntry("group", "Test");
@ -85,11 +85,11 @@ void StorageTest::deleteEntry()
storageJob = qobject_cast<StorageJob *>(job);
QVERIFY(storageJob);
if (storageJob) {
QVERIFY(storageJob->exec());
QVERIFY(storageJob->result().type() != QVariant::Bool);
QVERIFY(storageJob->data().isEmpty());
}
storageJob->setAutoDelete(false);
QVERIFY(storageJob->exec());
QVERIFY(storageJob->result().type() != QVariant::Bool);
QVERIFY(storageJob->data().isEmpty());
storageJob->deleteLater();
}
QTEST_KDEMAIN(StorageTest, NoGUI)