Katana_mirror/kdelibs
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kdelibs.git synced 2025-02-23 18:32:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kio: KFileItem::permissionsString() optimization

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2024-05-27 20:59:43 +03:00
parent 95e5af4190
commit 8e76e09b00
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
kio/kio/kfileitem.cpp
View file

@ -894,7 +894,11 @@ QString KFileItem::permissionsString() const
} }
char buffer[12]; char buffer[12];
char uxbit, gxbit, oxbit; ::memset(buffer, 0, sizeof(buffer));
int bufferlen = 10;
char uxbit = 0;
char gxbit = 0;
char oxbit = 0;
if ((d->m_permissions & (S_IXUSR|S_ISUID)) == (S_IXUSR|S_ISUID)) { if ((d->m_permissions & (S_IXUSR|S_ISUID)) == (S_IXUSR|S_ISUID)) {
uxbit = 's'; uxbit = 's';
@ -908,7 +912,7 @@ QString KFileItem::permissionsString() const
if ((d->m_permissions & (S_IXGRP|S_ISGID)) == (S_IXGRP|S_ISGID)) { if ((d->m_permissions & (S_IXGRP|S_ISGID)) == (S_IXGRP|S_ISGID)) {
gxbit = 's'; gxbit = 's';
} else if ( (d->m_permissions & (S_IXGRP|S_ISGID)) == S_ISGID) { } else if ((d->m_permissions & (S_IXGRP|S_ISGID)) == S_ISGID) {
gxbit = 'S'; gxbit = 'S';
} else if ((d->m_permissions & (S_IXGRP|S_ISGID)) == S_IXGRP) { } else if ((d->m_permissions & (S_IXGRP|S_ISGID)) == S_IXGRP) {
gxbit = 'x'; gxbit = 'x';
@ -960,12 +964,10 @@ QString KFileItem::permissionsString() const
// if (hasExtendedACL()) // if (hasExtendedACL())
if (d->m_entry.contains(KIO::UDSEntry::UDS_EXTENDED_ACL)) { if (d->m_entry.contains(KIO::UDSEntry::UDS_EXTENDED_ACL)) {
buffer[10] = '+'; buffer[10] = '+';
buffer[11] = 0; bufferlen = 11;
} else {
buffer[10] = 0;
} }
return QString::fromLatin1(buffer); return QString::fromLatin1(buffer, bufferlen);
} }
QString KFileItem::timeString(FileTimes which) const QString KFileItem::timeString(FileTimes which) const