Katana_mirror/kdelibs
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kdelibs.git synced 2025-02-23 18:32:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kio: checkDesktopFile() function optimization

Browse source 
KFileItem::isRegularFile() is a simple mode (member) check while
KFileItem::mostLocalUrl() does some dirty work

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2023-09-02 01:57:07 +03:00
parent 5301a82e4c
commit 4051004a5e
2 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
kfile/kurlnavigator.cpp
View file

@ -902,7 +902,6 @@ bool KUrlNavigator::showFullPath() const
return d->m_showFullPath;
}
void KUrlNavigator::setActive(bool active)
{
if (active != d->m_active) {
@ -1024,9 +1023,6 @@ void KUrlNavigator::setFocus()
}
}
void KUrlNavigator::keyPressEvent(QKeyEvent* event)
{
if (isUrlEditable() && (event->key() == Qt::Key_Escape)) {

10
kio/kio/kfileitem.cpp
View file

@ -750,6 +750,11 @@ QString KFileItem::iconName() const
*/
static bool checkDesktopFile(const KFileItem &item, bool _determineMimeType)
{
// only regular files
if (!item.isRegularFile()) {
return false;
}
// only local files
bool isLocal = false;
const KUrl url = item.mostLocalUrl(isLocal);
@ -757,11 +762,6 @@ static bool checkDesktopFile(const KFileItem &item, bool _determineMimeType)
return false;
}
// only regular files
if (!item.isRegularFile()) {
return false;
}
// only if readable
if (!item.isReadable()) {
return false;