Katana_mirror/kdelibs
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kdelibs.git synced 2025-02-24 10:52:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kio: KFileMetaDataConfigurationWidget optimization

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2022-05-28 07:24:19 +03:00
parent 25a9fae7e9
commit 2aca2619c3
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
kio/kfile/kfilemetadataconfigurationwidget.cpp
View file

@ -37,7 +37,7 @@ public:
void init(); void init();
void loadMetaData(); void loadMetaData();
void addItem(const KUrl& uri); void addItem(const QString& uri);
/** /**
* Is invoked after the meta data model has finished the loading of * Is invoked after the meta data model has finished the loading of
@ -83,7 +83,7 @@ void KFileMetaDataConfigurationWidget::Private::loadMetaData()
m_provider->setItems(m_fileItems); m_provider->setItems(m_fileItems);
} }
void KFileMetaDataConfigurationWidget::Private::addItem(const KUrl& uri) void KFileMetaDataConfigurationWidget::Private::addItem(const QString& uri)
{ {
// Meta information provided by KFileMetaInfo that is already // Meta information provided by KFileMetaInfo that is already
// available from KFileItem as "fixed item" (see above) // available from KFileItem as "fixed item" (see above)
@ -96,9 +96,8 @@ void KFileMetaDataConfigurationWidget::Private::addItem(const KUrl& uri)
}; };
int i = 0; int i = 0;
const QString key = uri.prettyUrl();
while (hiddenProperties[i] != 0) { while (hiddenProperties[i] != 0) {
if (key == QLatin1String(hiddenProperties[i])) { if (uri == QLatin1String(hiddenProperties[i])) {
// the item is hidden // the item is hidden
return; return;
} }
@ -110,12 +109,12 @@ void KFileMetaDataConfigurationWidget::Private::addItem(const KUrl& uri)
KConfigGroup settings = config.group("Show"); KConfigGroup settings = config.group("Show");
const QString label = (m_provider == 0) const QString label = (m_provider == 0)
? KFileMetaInfo::name(key) ? KFileMetaInfo::name(uri)
: m_provider->label(key); : m_provider->label(uri);
QListWidgetItem* item = new QListWidgetItem(label, m_metaDataList); QListWidgetItem* item = new QListWidgetItem(label, m_metaDataList);
item->setData(Qt::UserRole, key); item->setData(Qt::UserRole, uri);
const bool show = settings.readEntry(key, true); const bool show = settings.readEntry(uri, true);
item->setCheckState(show ? Qt::Checked : Qt::Unchecked); item->setCheckState(show ? Qt::Checked : Qt::Unchecked);
} }
@ -126,7 +125,7 @@ void KFileMetaDataConfigurationWidget::Private::slotLoadingFinished()
Q_ASSERT(m_provider != 0); Q_ASSERT(m_provider != 0);
foreach (const KFileMetaInfoItem &it, m_provider->data()) { foreach (const KFileMetaInfoItem &it, m_provider->data()) {
addItem(KUrl(it.key())); addItem(it.key());
} }
} }