Commit graph

58 commits

Author SHA1 Message Date
Ivailo Monev
f0859e7749 generic: adjust to KUrl changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-26 01:39:21 +03:00
Ivailo Monev
03c195810d generic: adjust to KUrl changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-25 21:12:46 +03:00
Ivailo Monev
5b7845d814 generic: adjust to KUrl changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 16:55:47 +03:00
Ivailo Monev
2c81ba5423 libs: adjust to QUrl/KUrl changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 16:41:29 +03:00
Ivailo Monev
a5360910a8 libs: correct debug message in isIconOld() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-20 10:54:07 +03:00
Ivailo Monev
6f1c138b12 generic: simplify KDE4WorkspaceConfig
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-18 04:01:26 +03:00
Ivailo Monev
ce48bc0997 generic: preperations for kdelibs changes
automatically replaced via:
find -name CMakeLists.txt -exec sed -e 's|${KDE4_PLASMA_LIBS}|KDE4::plasma|g' -e 's|${KDE4_KIO_LIBS}|KDE4::kio|g' -e 's|${KDE4_SOLID_LIBS}|KDE4::solid|g' -e 's|${KDE4_KFILE_LIBS}|KDE4::kfile|g' -e 's|${KDE4_KDECORE_LIBS}|KDE4::kdecore|g' -e 's|${KDE4_KDEUI_LIBS}|KDE4::kdeui|g' -e 's|${KDE4_KCMUTILS_LIBS}|KDE4::kcmutils|g' -e 's|${KDE4_KDECLARATIVE_LIBS}|KDE4::kdeclarative|g' -e 's|${KDE4_KPTY_LIBS}|KDE4::kpty|g' -e 's|${KDE4_KEMAIL_LIBS}|KDE4::kemail|g' -e 's|${KDE4_KMEDIAPLAYER_LIBS}|KDE4::kmediaplayer|g' -e 's|${KDE4_KPARTS_LIBS}|KDE4::kparts|g' -e 's|${KDE4_KIDLETIME_LIBS}|KDE4::kidletime|g' -e 's|${KDE4_KTEXTEDITOR_LIBS}|KDE4::ktexteditor|g' -e 's|${KDE4_KPASSWDSTORE_LIBS}|KDE4::kpasswdstore|g' -e 's|${KDE4_KARCHIVE_LIBS}|KDE4::karchive|g' -e 's|${KDE4_KDNSSD_LIBS}|KDE4::kdnssd|g' -e 's|${KDE4_KNOTIFYCONFIG_LIBS}|KDE4::knotifyconfig|g' -e 's|${KDE4_KEXIV2_LIBS}|KDE4::kexiv2|g' -i {} +

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-17 23:27:11 +03:00
Ivailo Monev
472f24878b generic: adjust to kdelibs changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-17 18:38:55 +03:00
Ivailo Monev
4c43b79a88 soliduiserver: implement methods to mount/unmount devices that are not Solid UDI and adjust to KAutoMount changes
this goes with 986a303ff6b8e179aadc85468abcae448711a108 in kdelibs repo

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-15 22:16:03 +03:00
Ivailo Monev
0b7caf6071 libs: export konq library as KDE4Workspace library
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-10 23:31:47 +03:00
Ivailo Monev
d728c33c83 generic: remove build variable used to specify library type
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-10 23:04:51 +03:00
Ivailo Monev
153c53f83c libs: store the favicon name in failed downloads list and attempt to download alternative on non-job error
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-10 19:02:26 +03:00
Ivailo Monev
ecdf8f6aaf libs: ensure the favicons sub-directory exists from iconFilePath() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-10 16:22:01 +03:00
Ivailo Monev
f1fe166b7c libs: copyright favicons KDED module to me
rewrote it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-08 13:03:37 +03:00
Ivailo Monev
c542942b82 libs: delete the transfer job as soon as its data is copied in FavIconsModule::slotFinished()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-08 12:59:57 +03:00
Ivailo Monev
42f32426d9 libs: use solid to check the network status in favicons KDED module test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-08 09:30:45 +03:00
Ivailo Monev
ea9ae0d25a libs: remove unused header inclusions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-07 21:22:55 +03:00
Ivailo Monev
a0a2761746 libs: favicons KDED module documentation review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-07 21:21:24 +03:00
Ivailo Monev
15838c25d7 libs: replace FavIconsModule::startDownload() with its body
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-07 21:15:39 +03:00
Ivailo Monev
d811882f97 libs: favicons KDED module rewrite
saves a lot of I/O and network trafic if there are multiple bookmarks to
the same host and multiple queries are made (which essentially will end up
being many jobs for the same icon). also implemented fallback to
alternative http://foo.bar/favicon.png and added tests for more cases,
bonus points?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-07 20:57:44 +03:00
Ivailo Monev
409d5e4225 libs: remove compatibility bits
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-02 14:53:47 +03:00
Ivailo Monev
9ecb90f238 libs: adjust to KIO::Job changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-23 01:40:17 +02:00
Ivailo Monev
8b2eba7361 generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 01:41:49 +02:00
Ivailo Monev
1212fc79f7 generic: adjust to authorization changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-25 19:12:57 +03:00
Ivailo Monev
7bb060f0cf libs: deal with TODOs related to KonqOperations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-23 14:58:11 +03:00
Ivailo Monev
45fbbf2582 generic: compiler warnings fixes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-05 22:06:42 +03:00
Ivailo Monev
0fac8d3580 libs: remove NFS template
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-03 11:37:44 +03:00
Ivailo Monev
38cdd9c0f4 generic: cast pointers with QObject as base class via qobject_cast<T>()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-01 21:54:59 +03:00
Ivailo Monev
f4ec94e4e0 libs: do not down-cast the job to KIO::Job and up-cast it via qobject_cast<T>()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-29 07:53:49 +03:00
Ivailo Monev
de8c7f6af1 libs: do not down-scale favicons images to 16x16
https://www.ibm.com/favicon.ico is 32x32 for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-27 08:26:43 +03:00
Ivailo Monev
509439c8b3 libs: skip favicon tests if images are not readable
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-27 07:52:04 +03:00
Ivailo Monev
b1c155416e libs: call setIconForUrl() in the non-QEventLoop version of the favicons module test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-26 04:06:29 +03:00
Ivailo Monev
c7429922cf libs: comment correction
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 12:44:33 +03:00
Ivailo Monev
b4629ae603 libs: manually delete favicons module jobs
fixes possible crash in case the job is automatically deleted and
KJob::errorString() is called to get the error

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 10:22:48 +03:00
Ivailo Monev
038d9286b0 libs: workaround for QSignalSpy in favicon test
TODO: reimplement QSignalSpy to use connections or just write a new class

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 09:39:49 +03:00
Ivailo Monev
3bcc2da57b libs: convert FavIconsModule::isIconOld() to static function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 09:32:44 +03:00
Ivailo Monev
ec06deac86 libs: declare download info struct as primitive and rename it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 09:19:23 +03:00
Ivailo Monev
c2f38b1a3b libs: connect to all favicons module signals in its test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 08:39:43 +03:00
Ivailo Monev
aa43bf3820 libs: test favicons module with IP addresses
requires:
38079e572c

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 08:06:19 +03:00
Ivailo Monev
02d8a78de8 libs: remove redundant favicons memory cache
the cache is supposed to speed-up non-host icon lookups but it does so only
for the life-time of the module, it becomes cache miss as soon as the
module is unloaded since the cache is not restored by the module from the
FavIconsModule constructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 09:04:20 +03:00
Ivailo Monev
11c62954d8 libs: favicons KDED module test re-write
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 06:54:52 +03:00
Ivailo Monev
6009accdc6 libs: do not store the favicons cache directory
KStandardDirs::saveLocation() will re-create it if it is deleted

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 05:25:14 +03:00
Ivailo Monev
e806e8a4c7 libs: warn when the image reader claims the data is readable but returns null image from favicon KDED module
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:35:12 +03:00
Ivailo Monev
055a8ca5f1 libs: warn when the image reader cannot read the favicon data
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:32:23 +03:00
Ivailo Monev
a55034d4f2 libs: fix possible favicons KDED module race-conditions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:04:45 +03:00
Ivailo Monev
f437e42045 libs: kill the job immediately if the favicon is too big and remove it from the downloads queue
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 03:58:22 +03:00
Ivailo Monev
9790faa5d7 libs: double the wait time for favicon signals
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:35:46 +03:00
Ivailo Monev
3ed404a6be libs: convert FavIconsModulePrivate::makeIconName() to static function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:16:42 +03:00
Ivailo Monev
83a8cd1cf1 libs: de-virtualize FavIconsModulePrivate destructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:14:45 +03:00
Ivailo Monev
5f6c75eee2 libs: attach the signal spy after D-Bus initialization stuff happens in favicon test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 00:09:32 +03:00