Commit graph

183 commits

Author SHA1 Message Date
Ivailo Monev
780dc422b1 libs: do not elevate privileges to send signals to processes
the privilege elevation should ask for the password of the user that owns
the process to begin with not the other way around - `sudo` is asking me if
I know my password to kill `kwin` process of Bob? Yes, I do!

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 13:00:41 +03:00
Ivailo Monev
c7429922cf libs: comment correction
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 12:44:33 +03:00
Ivailo Monev
b4629ae603 libs: manually delete favicons module jobs
fixes possible crash in case the job is automatically deleted and
KJob::errorString() is called to get the error

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 10:22:48 +03:00
Ivailo Monev
038d9286b0 libs: workaround for QSignalSpy in favicon test
TODO: reimplement QSignalSpy to use connections or just write a new class

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 09:39:49 +03:00
Ivailo Monev
3bcc2da57b libs: convert FavIconsModule::isIconOld() to static function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 09:32:44 +03:00
Ivailo Monev
ec06deac86 libs: declare download info struct as primitive and rename it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 09:19:23 +03:00
Ivailo Monev
c2f38b1a3b libs: connect to all favicons module signals in its test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 08:39:43 +03:00
Ivailo Monev
aa43bf3820 libs: test favicons module with IP addresses
requires:
38079e572c

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 08:06:19 +03:00
Ivailo Monev
02d8a78de8 libs: remove redundant favicons memory cache
the cache is supposed to speed-up non-host icon lookups but it does so only
for the life-time of the module, it becomes cache miss as soon as the
module is unloaded since the cache is not restored by the module from the
FavIconsModule constructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 09:04:20 +03:00
Ivailo Monev
11c62954d8 libs: favicons KDED module test re-write
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 06:54:52 +03:00
Ivailo Monev
6009accdc6 libs: do not store the favicons cache directory
KStandardDirs::saveLocation() will re-create it if it is deleted

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 05:25:14 +03:00
Ivailo Monev
e806e8a4c7 libs: warn when the image reader claims the data is readable but returns null image from favicon KDED module
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:35:12 +03:00
Ivailo Monev
055a8ca5f1 libs: warn when the image reader cannot read the favicon data
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:32:23 +03:00
Ivailo Monev
a55034d4f2 libs: fix possible favicons KDED module race-conditions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:04:45 +03:00
Ivailo Monev
f437e42045 libs: kill the job immediately if the favicon is too big and remove it from the downloads queue
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 03:58:22 +03:00
Ivailo Monev
9790faa5d7 libs: double the wait time for favicon signals
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:35:46 +03:00
Ivailo Monev
3ed404a6be libs: convert FavIconsModulePrivate::makeIconName() to static function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:16:42 +03:00
Ivailo Monev
83a8cd1cf1 libs: de-virtualize FavIconsModulePrivate destructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:14:45 +03:00
Ivailo Monev
5f6c75eee2 libs: attach the signal spy after D-Bus initialization stuff happens in favicon test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 00:09:32 +03:00
Ivailo Monev
8acb29cd9f libs: remove unused system ctime header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 00:08:32 +03:00
Ivailo Monev
6153a04df0 libs: if the favicon modification time is not valid consider it as old
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 23:43:16 +03:00
Ivailo Monev
4afd6b308f libs: mark ksysguard processes test case as flaky
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 22:46:20 +03:00
Ivailo Monev
c5c1ecc7fc libs: skip only the tests relying on permissions when they are unexpected
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 22:38:08 +03:00
Ivailo Monev
731cdb39d5 libs: skip some tests when the permissions do not match the expectations
this is the case when the tests are run as root

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 20:46:47 +03:00
Ivailo Monev
61965cf96f libs: quit event loops if signals are not emitted after 10sec in favicons test case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 08:28:43 +03:00
Ivailo Monev
efb984cfae generic: bump minimum Katie version requirement to 4.12.0
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 03:59:41 +03:00
Ivailo Monev
6a5265b9da libs: bootstrap testing build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-20 21:39:26 +03:00
Ivailo Monev
3892372c80 libs: always enable share action for local directories
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-16 23:51:50 +03:00
Ivailo Monev
f68295ea28 generic: move sub-projects from kde-baseapps [ci reset]
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-14 21:56:54 +03:00
Ivailo Monev
d826ae2691 kfirewall: build and install only on Linux
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-07 01:07:56 +03:00
Ivailo Monev
ac3d97b6ae libs: minor KDisplayManager review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-28 12:53:17 +03:00
Ivailo Monev
1f916560b9 libs: ignore inactive sessions in KDisplayManager::localSessions()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-28 12:25:56 +03:00
Ivailo Monev
d83283c11f Merge branch 'master' of ssh://github.com/fluxer/kde-workspace 2022-04-27 23:53:44 +03:00
Ivailo Monev
24e340ac0f libs: remove unused configuration checks
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-27 23:53:31 +03:00
Ivailo Monev
3640705360 libs: fix ConsoleKit fallback in KDisplayManager::isSwitchable()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-27 23:08:05 +03:00
Ivailo Monev
5144677e0d libs: fallback to ConsoleKit in KDisplayManager
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-27 22:52:38 +03:00
Ivailo Monev
87ec7d5735 libs: reimplement KDisplayManager
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-27 22:28:07 +03:00
Ivailo Monev
8695460bb5 libs: fallback to ConsoleKit in KDisplayManager::isSwitchable()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-25 07:13:18 +03:00
Ivailo Monev
03e29652d7 libs: fix KDisplayManager::isSwitchable() when systemd is used instead of ConsoleKit
for reference:
https://bugs.kde.org/show_bug.cgi?id=427777

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-24 21:03:39 +03:00
Ivailo Monev
4385f0be53 generic: remove redundant executables output path override
kde4_add_manual_test() macro already does it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-22 00:30:51 +03:00
Ivailo Monev
fcbc69b222 generic: reimplement screen saver interface via xscreensaver
my monitor is not the latest stock but it has its own screen saver
feature

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-13 01:27:15 +03:00
Ivailo Monev
52e71baa35 libs: remove unused winbind greeter
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-12 18:30:09 +03:00
Ivailo Monev
9f7eb66616 libs: remove KDM leftovers
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-03 15:02:25 +03:00
Ivailo Monev
0411eb46a8 plasma: replace kephal with single class [ci reset]
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-03 05:17:09 +03:00
Ivailo Monev
4abe1ff384 generic: remove unused and fix some configuration checks
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-04-01 18:44:39 +03:00
Ivailo Monev
43dfbda893 libs: remove unused token argument of TaskManager::setTrackGeometry()
if UUID tokens were actually used for something the getter
(TaskManager::trackGeometry()) would also take token argument, token was
always the same string too - {00000000-0000-0000-0000-000000000000}

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-03-21 07:02:18 +02:00
Ivailo Monev
cd2057d407 libs: save and load group tasks pixmaps in Katie image format
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-03-02 16:27:17 +02:00
Ivailo Monev
a66698644a libs: do not disable hinting of fonts used for painting calendar table
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-01-21 09:49:24 +02:00
Ivailo Monev
eaf84b185c libs: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-01-10 07:11:22 +02:00
Ivailo Monev
edb7f10100 libs: add missing defined expression
fixes build on OpenIndiana

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-09-18 16:45:20 +03:00