Commit graph

30 commits

Author SHA1 Message Date
Ivailo Monev
4c2efb764e kdesudo: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 19:38:07 +03:00
Ivailo Monev
a2a57db88f kdesudo: pass the comment argument as-is from KdeSudo constructor
internally KCmdLineArgs converts from and to the current locale encoding

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 19:24:07 +03:00
Ivailo Monev
a5017377d2 kdesudo: store the DISPLAY environment variable as QString
otherwise it will be converted as if it is ASCII later on several times

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 19:18:56 +03:00
Ivailo Monev
90dcef2ec2 kdesudo: remove redundant KDESu::KDESuPrivate::KCookie class
only the display getter is used, also bail out if DISPLAY environment
variable is not set

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 19:15:11 +03:00
Ivailo Monev
e158808da9 kdesudo: set LANG and LC_ALL for the process
translations and command-line programs output parsing do not get along

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 01:00:22 +03:00
Ivailo Monev
bf041a724f kdesudo: fix execution failure detection and notification
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 00:53:53 +03:00
Ivailo Monev
5bca600df3 kdesudo: remove unused stdlib header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:42:26 +03:00
Ivailo Monev
8ef70f7c75 kdesudo: remove unused variable in main()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:40:26 +03:00
Ivailo Monev
ac0c225fe8 kdesudo: increase the wait times in KDESu::KDESuPrivate::KCookie constructor to 3secs
100ms is not a whole lot with kernel scheduling, if the process is ready
to read in less than 3secs the waiting will stop anyway

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:39:54 +03:00
Ivailo Monev
63c440a6d3 kdesudo: terminate the process from KdeSudo destructor
the process is not detached thus it will happen one way or other but doing
it from the KdeSudo destructor with 3sec wait time for the process to
terminate will silence the QProcess runtime warning (possibly, unless the
process does not quit on SIGTERM or within 3 seconds)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:30:32 +03:00
Ivailo Monev
cea6fb2142 kdesudo: keep reference to the QByteArray object in KdeSudo::parseOutput()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:21:33 +03:00
Ivailo Monev
71f69968ff kdesudo: plug memory leak
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:19:31 +03:00
Ivailo Monev
2d3f88e1cf kdesudo: remove unused KdeSudo::slotUser1() slot
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:16:59 +03:00
Ivailo Monev
648b95d4d2 kdesudo: remove unused KdeSudo members and methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:14:02 +03:00
Ivailo Monev
af98b78b2a kdesudo: disable session management
kdesudo does not support session restoration

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-06 16:06:34 +03:00
Ivailo Monev
0eae2deaa0 kdesudo: remove redundant KDESu::KDESuPrivate::KCookie::KCookiePrivate class
private class in a private namespace does not need a d pointer for compat

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-04 12:59:32 +03:00
Ivailo Monev
96928dcb22 kdesudo: remove unused fake options
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-04 12:53:41 +03:00
Ivailo Monev
b358e20491 kdesudo: do not set website and bug address
if not set default to Katana links

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 01:43:24 +03:00
Ivailo Monev
ce48bc0997 generic: preperations for kdelibs changes
automatically replaced via:
find -name CMakeLists.txt -exec sed -e 's|${KDE4_PLASMA_LIBS}|KDE4::plasma|g' -e 's|${KDE4_KIO_LIBS}|KDE4::kio|g' -e 's|${KDE4_SOLID_LIBS}|KDE4::solid|g' -e 's|${KDE4_KFILE_LIBS}|KDE4::kfile|g' -e 's|${KDE4_KDECORE_LIBS}|KDE4::kdecore|g' -e 's|${KDE4_KDEUI_LIBS}|KDE4::kdeui|g' -e 's|${KDE4_KCMUTILS_LIBS}|KDE4::kcmutils|g' -e 's|${KDE4_KDECLARATIVE_LIBS}|KDE4::kdeclarative|g' -e 's|${KDE4_KPTY_LIBS}|KDE4::kpty|g' -e 's|${KDE4_KEMAIL_LIBS}|KDE4::kemail|g' -e 's|${KDE4_KMEDIAPLAYER_LIBS}|KDE4::kmediaplayer|g' -e 's|${KDE4_KPARTS_LIBS}|KDE4::kparts|g' -e 's|${KDE4_KIDLETIME_LIBS}|KDE4::kidletime|g' -e 's|${KDE4_KTEXTEDITOR_LIBS}|KDE4::ktexteditor|g' -e 's|${KDE4_KPASSWDSTORE_LIBS}|KDE4::kpasswdstore|g' -e 's|${KDE4_KARCHIVE_LIBS}|KDE4::karchive|g' -e 's|${KDE4_KDNSSD_LIBS}|KDE4::kdnssd|g' -e 's|${KDE4_KNOTIFYCONFIG_LIBS}|KDE4::knotifyconfig|g' -e 's|${KDE4_KEXIV2_LIBS}|KDE4::kexiv2|g' -i {} +

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-17 23:27:11 +03:00
Ivailo Monev
1df5da15d3 generic: remove references to build variables that are no set
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-17 19:23:17 +03:00
Ivailo Monev
472f24878b generic: adjust to kdelibs changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-17 18:38:55 +03:00
Ivailo Monev
4390ea265e kdesudo: use dbus-run-session instead of dbus-launch
dbus-run-session will terminate the dbus-daemon process and cleanup

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-02 21:08:10 +02:00
Ivailo Monev
ee7194cc31 kdesudo: minor optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-02 20:56:16 +02:00
Ivailo Monev
8b2eba7361 generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 01:41:49 +02:00
Ivailo Monev
4b95471273 kdesudo: assign KdeSudo::m_tmpName member to the temporary filepath, not a variable
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 18:37:41 +03:00
Ivailo Monev
79bb1f47d8 kdesudo: use KTemporaryFile::filePath() to generate temporary file name
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 18:11:34 +03:00
Ivailo Monev
1cedf80f48 kdesudo: log warning messages to the kdesudo area
1206 is not reserved for anything

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-22 23:53:18 +03:00
Ivailo Monev
5af270efc2 kdesudo: log messages to specialized area
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-22 23:26:50 +03:00
Ivailo Monev
3bc3e31176 kdesudo: use the static QFile::exists() method instead of constructing QFile object and changing its filename
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-09 03:44:50 +03:00
Ivailo Monev
f68295ea28 generic: move sub-projects from kde-baseapps [ci reset]
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-14 21:56:54 +03:00