Commit graph

335 commits

Author SHA1 Message Date
Ivailo Monev
ea611115c4 generic: call KToolInvocation::setLaunchEnv() as static method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-19 16:22:07 +02:00
Ivailo Monev
f3e5025c2f generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-17 15:43:14 +02:00
Ivailo Monev
00c878740e kcontrol: explicitly load in case its not timzeone change from KclockModule::save()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-14 21:34:50 +02:00
Ivailo Monev
0ea8aca13b kcontrol: lower the timezone poll time to 1 second
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-14 21:26:07 +02:00
Ivailo Monev
7e8f1620a0 generic: disable KCM when not authorized
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-14 21:12:03 +02:00
Ivailo Monev
1e2511421c generic: adjust to KAuthorization changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 08:27:34 +02:00
Ivailo Monev
f9c0870657 kcontrol: openbox hack
if openbox still fails to launch check the system log, it has not been
maintained for years so I do not expect a crash to get fixed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 04:37:49 +02:00
Ivailo Monev
fe23eb4d95 kcontrol: use QFileInfo instead of QRegExp to get the window manager basename
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-10 15:11:54 +02:00
Ivailo Monev
ed44557733 kcontrol: use KProcess to start the window manager processes
by using KProcess::setShellCommand() the Exec key can contain not only
program but also arguments, ksmserver splits the Exec key already (see
kde-workspace/ksmserver/server.cpp)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-10 14:41:47 +02:00
Ivailo Monev
2ccfe10531 kcontrol: format and indent componentchooser KCM source and header files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-10 14:26:38 +02:00
Ivailo Monev
f1de78f207 kcontrol: set X-KDE-WindowManagerConfigure to obconf for openbox
it is the official configuration manager

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-10 10:57:49 +02:00
Ivailo Monev
e98a79801d kcontrol: replace timer with counter
don't need to register timer for this, just a bit of math

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-10 10:33:25 +02:00
Ivailo Monev
e9fff98398 kcontrol: remove compiz-custom desktop file
references script that is not provided by Katana nor compiz

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-10 07:11:06 +02:00
Ivailo Monev
57034bbac3 kcontrol: set X-KDE-WindowManagerConfigure to xfwm4-settings for xfwm4
it has two more programs for that tho - xfwm4-tweaks-settings and
xfwm4-workspace-settings

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 10:51:46 +02:00
Ivailo Monev
dea51842b8 kcontrol: disable the window manager choose while the timer dialog is active
clicking on any of its widgets before the dialog is closed can mess up the
configuration because the widgets are still connected to signals and slots

side note: if the overview button is clicked (i.e. the componentchoooser
KCM is closed) while the timer dialog is active is can happen regardless

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 10:45:47 +02:00
Ivailo Monev
2168e10dbc kcontrol: essentially window manager chooser rewrite
two things were not done properly before:
 - current window manager was not replaced if the window manager that
   would replace does not have --replace command (or alternative)
 - waiting for the window manager to become active

now that that is done, any window manager can be started right away and
more .desktop files may be added in the future

also, something that occurred to me while writing the code for it - KWin
replaces the window manager on the current screen only and it is
possible to code the window manager chooser to start the replacing window
manager on any screen (assuming it has --screen argument or something
like that)
2022-12-09 10:21:27 +02:00
Ivailo Monev
eba0c48859 generic: adjust to KToolInvocation changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 06:36:46 +02:00
Ivailo Monev
24e21ea89d kcontrol: remove redundant KToolInvocation::klauncher()->reparseConfiguration() call
the terminal application config option does not affect klauncher

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 04:00:43 +02:00
Ivailo Monev
2315772e5a generic: MOC warnings fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-06 23:59:08 +02:00
Ivailo Monev
594e39a043 generic: adjust to KCrash and klauncher interface changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-04 22:44:00 +02:00
Ivailo Monev
fcbec5f0cc generic: adjust to solid power manager changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-01 23:54:21 +02:00
Ivailo Monev
67d1219669 kcontrol: correct XkbSetControls() return value check
I should've checked the return type before commit
7e5939c9fb

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-30 04:49:17 +02:00
Ivailo Monev
7e5939c9fb kcontrol: fix regression since 45fbbf2582
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 12:40:45 +02:00
Ivailo Monev
795cb31a59 generic: remove redundant HAVE_XRENDER configuration definition
if Xrender is not found a fatal message will be issued by the top-level
CMakeLists file because it is required by KWin compositor for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 00:46:00 +02:00
Ivailo Monev
243f64bdfd kcontrol: read font settings directly from the kdeglobals config
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 20:12:44 +02:00
Ivailo Monev
56b3159f80 kcontrol: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 19:55:04 +02:00
Ivailo Monev
45778efb45 kcontrol: enable animatetoolbox when effects are enabled
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 15:46:06 +02:00
Ivailo Monev
9ed7286504 kcontrol: partial fix for KGlobalSettings race
the style KCM for example emits changes via
KGlobalSettings::self()->emitChange() however it does not wait for the
KGlobalSettings::settingsChanged() signal (which means settings are
reloaded) before running krdb, font and palette settings are likely subject
to this race-condition but for now that will do

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 05:18:50 +02:00
Ivailo Monev
35151a7d91 generic: adjust to KGlobalSettings changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 05:05:45 +02:00
Ivailo Monev
617366c72d kcontrol: remove unused applyQtColors() and applyQtSettings() arguments
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 02:29:27 +02:00
Ivailo Monev
71e0885005 kcontrol: run krdb after emiting KGlobalSettings changes from style KCM
krdb itself uses KGlobalSettings to get the palette, font and other
settings

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 02:28:15 +02:00
Ivailo Monev
26a25dae5f kcontrol: flush the QSettings changes before notifying applications about the changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 02:16:34 +02:00
Ivailo Monev
2266ab6cba kcontrol: enable Katie effects based on Katana graphics effect level
note that the only way to set EffectsEnabled, EffectFadeMenu,
EffectFadeTooltip and EffectAnimateCombo was manually (by editing the
~/.katana/share/config/kdeglobals config file) because there is no GUI for
those config options but there is for the graphics effects level

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 23:51:37 +02:00
Ivailo Monev
8b2eba7361 generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 01:41:49 +02:00
Ivailo Monev
3e62be6595 kcontrol: indent and format randr module source and header files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 12:59:52 +02:00
Ivailo Monev
74cd0ad0f5 kcontrol: indent and format randr module source and header files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 12:47:56 +02:00
Ivailo Monev
24082b4a04 kcontrol: I am the maintainer of kdebug KCM since 2014
it has been that long?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 11:52:18 +02:00
Ivailo Monev
4f40e8fa19 kcontrol: save kdebug KCM changes when the output file changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 11:50:14 +02:00
Ivailo Monev
000dfaa7e3 kcontrol: save kdebug KCM settings when destination changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 11:34:07 +02:00
Ivailo Monev
347f9d7177 kcontrol: merge DesktopStartItem class into AutoStartItem
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 12:47:53 +02:00
Ivailo Monev
12bb86ae51 kcontrol: write Name entry for custom desktop files from autostart KCM
otherwise it is empty the next time autostart KCM loads the .desktop files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 11:48:13 +02:00
Ivailo Monev
c80d049e53 kcontrol: disable autostart items the filepath of which is not writable
this is kinda not according to the spec (which allows user overrides) but
what is the outcome of having a local copy of system file?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 08:19:26 +02:00
Ivailo Monev
897ca32dcf kcontrol: fix autostart add
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 08:07:16 +02:00
Ivailo Monev
e5a021693f kcontrol: notify when error occurrs when attempting to remove program autostart
can happen if the .desktop file is in /usr/share/autostart/ for example and
the user cannot write there

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 07:44:58 +02:00
Ivailo Monev
967aed50d1 kcontrol: skip non-existing directories in autostart KCM
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 07:43:12 +02:00
Ivailo Monev
361cdfb5f7 generic: prepare for autostart changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 09:40:50 +02:00
Ivailo Monev
1a87bf0849 kcontrol: drop support for scripts in autostart KCM
see the previous commit, also fixes detection of programs that are
automatically started by using KStandardDirs to find the autostart
directories

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 09:21:35 +02:00
Ivailo Monev
e159cc5e21 kcontrol: use mutable list iterator in RandRCrtc::modes()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 14:24:31 +02:00
Ivailo Monev
b6405cb178 kcontrol: formant and indent randr KCM files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 14:20:15 +02:00
Ivailo Monev
609a72aa84 kcontrol: drop legacy configuration support in randr KCM
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-03 16:35:42 +02:00