Ivailo Monev
f4ec94e4e0
libs: do not down-cast the job to KIO::Job and up-cast it via qobject_cast<T>()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-29 07:53:49 +03:00
Ivailo Monev
de8c7f6af1
libs: do not down-scale favicons images to 16x16
...
https://www.ibm.com/favicon.ico is 32x32 for example
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-27 08:26:43 +03:00
Ivailo Monev
b4629ae603
libs: manually delete favicons module jobs
...
fixes possible crash in case the job is automatically deleted and
KJob::errorString() is called to get the error
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 10:22:48 +03:00
Ivailo Monev
3bcc2da57b
libs: convert FavIconsModule::isIconOld() to static function
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 09:32:44 +03:00
Ivailo Monev
ec06deac86
libs: declare download info struct as primitive and rename it
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 09:19:23 +03:00
Ivailo Monev
02d8a78de8
libs: remove redundant favicons memory cache
...
the cache is supposed to speed-up non-host icon lookups but it does so only
for the life-time of the module, it becomes cache miss as soon as the
module is unloaded since the cache is not restored by the module from the
FavIconsModule constructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 09:04:20 +03:00
Ivailo Monev
6009accdc6
libs: do not store the favicons cache directory
...
KStandardDirs::saveLocation() will re-create it if it is deleted
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 05:25:14 +03:00
Ivailo Monev
e806e8a4c7
libs: warn when the image reader claims the data is readable but returns null image from favicon KDED module
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:35:12 +03:00
Ivailo Monev
055a8ca5f1
libs: warn when the image reader cannot read the favicon data
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:32:23 +03:00
Ivailo Monev
a55034d4f2
libs: fix possible favicons KDED module race-conditions
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:04:45 +03:00
Ivailo Monev
f437e42045
libs: kill the job immediately if the favicon is too big and remove it from the downloads queue
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 03:58:22 +03:00
Ivailo Monev
3ed404a6be
libs: convert FavIconsModulePrivate::makeIconName() to static function
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:16:42 +03:00
Ivailo Monev
83a8cd1cf1
libs: de-virtualize FavIconsModulePrivate destructor
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:14:45 +03:00
Ivailo Monev
8acb29cd9f
libs: remove unused system ctime header inclusion
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 00:08:32 +03:00
Ivailo Monev
6153a04df0
libs: if the favicon modification time is not valid consider it as old
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 23:43:16 +03:00
Ivailo Monev
f68295ea28
generic: move sub-projects from kde-baseapps [ci reset]
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-14 21:56:54 +03:00
