Katana_mirror/kde-workspace
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kde-workspace.git synced 2025-02-24 02:42:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
2449 commits 2 branches 0 tags 121 MiB
Commit graph

27 commits

Author SHA1 Message Date
Ivailo Monev
2c81ba5423 libs: adjust to QUrl/KUrl changes 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-22 16:41:29 +03:00
Ivailo Monev
a5360910a8 libs: correct debug message in isIconOld() function 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-20 10:54:07 +03:00
Ivailo Monev
ce48bc0997 generic: preperations for kdelibs changes 
automatically replaced via:
find -name CMakeLists.txt -exec sed -e 's|${KDE4_PLASMA_LIBS}|KDE4::plasma|g' -e 's|${KDE4_KIO_LIBS}|KDE4::kio|g' -e 's|${KDE4_SOLID_LIBS}|KDE4::solid|g' -e 's|${KDE4_KFILE_LIBS}|KDE4::kfile|g' -e 's|${KDE4_KDECORE_LIBS}|KDE4::kdecore|g' -e 's|${KDE4_KDEUI_LIBS}|KDE4::kdeui|g' -e 's|${KDE4_KCMUTILS_LIBS}|KDE4::kcmutils|g' -e 's|${KDE4_KDECLARATIVE_LIBS}|KDE4::kdeclarative|g' -e 's|${KDE4_KPTY_LIBS}|KDE4::kpty|g' -e 's|${KDE4_KEMAIL_LIBS}|KDE4::kemail|g' -e 's|${KDE4_KMEDIAPLAYER_LIBS}|KDE4::kmediaplayer|g' -e 's|${KDE4_KPARTS_LIBS}|KDE4::kparts|g' -e 's|${KDE4_KIDLETIME_LIBS}|KDE4::kidletime|g' -e 's|${KDE4_KTEXTEDITOR_LIBS}|KDE4::ktexteditor|g' -e 's|${KDE4_KPASSWDSTORE_LIBS}|KDE4::kpasswdstore|g' -e 's|${KDE4_KARCHIVE_LIBS}|KDE4::karchive|g' -e 's|${KDE4_KDNSSD_LIBS}|KDE4::kdnssd|g' -e 's|${KDE4_KNOTIFYCONFIG_LIBS}|KDE4::knotifyconfig|g' -e 's|${KDE4_KEXIV2_LIBS}|KDE4::kexiv2|g' -i {} +

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-17 23:27:11 +03:00
Ivailo Monev
153c53f83c libs: store the favicon name in failed downloads list and attempt to download alternative on non-job error 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-10 19:02:26 +03:00
Ivailo Monev
ecdf8f6aaf libs: ensure the favicons sub-directory exists from iconFilePath() function 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-10 16:22:01 +03:00
Ivailo Monev
f1fe166b7c libs: copyright favicons KDED module to me 
rewrote it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-08 13:03:37 +03:00
Ivailo Monev
c542942b82 libs: delete the transfer job as soon as its data is copied in FavIconsModule::slotFinished() 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-08 12:59:57 +03:00
Ivailo Monev
ea9ae0d25a libs: remove unused header inclusions 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-07 21:22:55 +03:00
Ivailo Monev
a0a2761746 libs: favicons KDED module documentation review 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-07 21:21:24 +03:00
Ivailo Monev
15838c25d7 libs: replace FavIconsModule::startDownload() with its body 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-07 21:15:39 +03:00
Ivailo Monev
d811882f97 libs: favicons KDED module rewrite 
saves a lot of I/O and network trafic if there are multiple bookmarks to
the same host and multiple queries are made (which essentially will end up
being many jobs for the same icon). also implemented fallback to
alternative http://foo.bar/favicon.png and added tests for more cases,
bonus points?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2023-06-07 20:57:44 +03:00
Ivailo Monev
f4ec94e4e0 libs: do not down-cast the job to KIO::Job and up-cast it via qobject_cast<T>() 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-29 07:53:49 +03:00
Ivailo Monev
de8c7f6af1 libs: do not down-scale favicons images to 16x16 
https://www.ibm.com/favicon.ico is 32x32 for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-27 08:26:43 +03:00
Ivailo Monev
b4629ae603 libs: manually delete favicons module jobs 
fixes possible crash in case the job is automatically deleted and
KJob::errorString() is called to get the error

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-24 10:22:48 +03:00
Ivailo Monev
3bcc2da57b libs: convert FavIconsModule::isIconOld() to static function 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-24 09:32:44 +03:00
Ivailo Monev
ec06deac86 libs: declare download info struct as primitive and rename it 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-24 09:19:23 +03:00
Ivailo Monev
02d8a78de8 libs: remove redundant favicons memory cache 
the cache is supposed to speed-up non-host icon lookups but it does so only
for the life-time of the module, it becomes cache miss as soon as the
module is unloaded since the cache is not restored by the module from the
FavIconsModule constructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-23 09:04:20 +03:00
Ivailo Monev
6009accdc6 libs: do not store the favicons cache directory 
KStandardDirs::saveLocation() will re-create it if it is deleted

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-23 05:25:14 +03:00
Ivailo Monev
e806e8a4c7 libs: warn when the image reader claims the data is readable but returns null image from favicon KDED module 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-23 04:35:12 +03:00
Ivailo Monev
055a8ca5f1 libs: warn when the image reader cannot read the favicon data 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-23 04:32:23 +03:00
Ivailo Monev
a55034d4f2 libs: fix possible favicons KDED module race-conditions 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-23 04:04:45 +03:00
Ivailo Monev
f437e42045 libs: kill the job immediately if the favicon is too big and remove it from the downloads queue 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-23 03:58:22 +03:00
Ivailo Monev
3ed404a6be libs: convert FavIconsModulePrivate::makeIconName() to static function 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-23 01:16:42 +03:00
Ivailo Monev
83a8cd1cf1 libs: de-virtualize FavIconsModulePrivate destructor 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-23 01:14:45 +03:00
Ivailo Monev
8acb29cd9f libs: remove unused system ctime header inclusion 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-23 00:08:32 +03:00
Ivailo Monev
6153a04df0 libs: if the favicon modification time is not valid consider it as old 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-22 23:43:16 +03:00
Ivailo Monev
f68295ea28 generic: move sub-projects from kde-baseapps [ci reset] 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
 2022-05-14 21:56:54 +03:00