Commit graph

19 commits

Author SHA1 Message Date
Ivailo Monev
02d8a78de8 libs: remove redundant favicons memory cache
the cache is supposed to speed-up non-host icon lookups but it does so only
for the life-time of the module, it becomes cache miss as soon as the
module is unloaded since the cache is not restored by the module from the
FavIconsModule constructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 09:04:20 +03:00
Ivailo Monev
11c62954d8 libs: favicons KDED module test re-write
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 06:54:52 +03:00
Ivailo Monev
6009accdc6 libs: do not store the favicons cache directory
KStandardDirs::saveLocation() will re-create it if it is deleted

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 05:25:14 +03:00
Ivailo Monev
e806e8a4c7 libs: warn when the image reader claims the data is readable but returns null image from favicon KDED module
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:35:12 +03:00
Ivailo Monev
055a8ca5f1 libs: warn when the image reader cannot read the favicon data
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:32:23 +03:00
Ivailo Monev
a55034d4f2 libs: fix possible favicons KDED module race-conditions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:04:45 +03:00
Ivailo Monev
f437e42045 libs: kill the job immediately if the favicon is too big and remove it from the downloads queue
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 03:58:22 +03:00
Ivailo Monev
9790faa5d7 libs: double the wait time for favicon signals
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:35:46 +03:00
Ivailo Monev
3ed404a6be libs: convert FavIconsModulePrivate::makeIconName() to static function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:16:42 +03:00
Ivailo Monev
83a8cd1cf1 libs: de-virtualize FavIconsModulePrivate destructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:14:45 +03:00
Ivailo Monev
5f6c75eee2 libs: attach the signal spy after D-Bus initialization stuff happens in favicon test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 00:09:32 +03:00
Ivailo Monev
8acb29cd9f libs: remove unused system ctime header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 00:08:32 +03:00
Ivailo Monev
6153a04df0 libs: if the favicon modification time is not valid consider it as old
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 23:43:16 +03:00
Ivailo Monev
c5c1ecc7fc libs: skip only the tests relying on permissions when they are unexpected
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 22:38:08 +03:00
Ivailo Monev
731cdb39d5 libs: skip some tests when the permissions do not match the expectations
this is the case when the tests are run as root

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 20:46:47 +03:00
Ivailo Monev
61965cf96f libs: quit event loops if signals are not emitted after 10sec in favicons test case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 08:28:43 +03:00
Ivailo Monev
6a5265b9da libs: bootstrap testing build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-20 21:39:26 +03:00
Ivailo Monev
3892372c80 libs: always enable share action for local directories
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-16 23:51:50 +03:00
Ivailo Monev
f68295ea28 generic: move sub-projects from kde-baseapps [ci reset]
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-14 21:56:54 +03:00