From d3a7c7571aee91f3c4315bdc3620d57e331a687f Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Sun, 11 Dec 2022 08:41:29 +0200 Subject: [PATCH] kwin: remove unused X-KDE-Ordering property the effects have no dependencies and can be loaded and unloaded at any, also none of the effects provide the same functionality (there used to be such effects before but not anymore) Signed-off-by: Ivailo Monev --- kwin/effects.cpp | 2 -- kwin/effects/diminactive/diminactive.desktop | 1 - kwin/effects/highlightwindow/highlightwindow.desktop | 1 - kwin/effects/kwineffect.desktop | 3 --- kwin/effects/logout/logout.desktop | 1 - kwin/effects/minimizeanimation/minimizeanimation.desktop | 1 - kwin/effects/presentwindows/presentwindows.desktop | 1 - kwin/effects/resize/resize.desktop | 1 - kwin/effects/slide/slide.desktop | 1 - kwin/effects/slideback/slideback.desktop | 1 - kwin/effects/slidingpopups/slidingpopups.desktop | 1 - kwin/effects/startupfeedback/startupfeedback.desktop | 2 -- kwin/effects/taskbarthumbnail/taskbarthumbnail.desktop | 1 - kwin/effects/windowgeometry/windowgeometry.desktop | 3 --- 14 files changed, 20 deletions(-) diff --git a/kwin/effects.cpp b/kwin/effects.cpp index f042ae55..99483fb4 100644 --- a/kwin/effects.cpp +++ b/kwin/effects.cpp @@ -1361,8 +1361,6 @@ bool EffectsHandlerImpl::loadEffect(const QString& name, bool checkDefault) } kDebug(1212) << "Internal effect has been loaded" << name; - - // order does not matter really loaded_effects.append(EffectPair(name, effect)); effectsChanged(); return true; diff --git a/kwin/effects/diminactive/diminactive.desktop b/kwin/effects/diminactive/diminactive.desktop index 826859a4..cc8e59c3 100644 --- a/kwin/effects/diminactive/diminactive.desktop +++ b/kwin/effects/diminactive/diminactive.desktop @@ -156,4 +156,3 @@ X-KDE-PluginInfo-Category=Focus X-KDE-PluginInfo-Depends= X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-EnabledByDefault=false -X-KDE-Ordering=50 diff --git a/kwin/effects/highlightwindow/highlightwindow.desktop b/kwin/effects/highlightwindow/highlightwindow.desktop index e6b8b026..4197bfb9 100644 --- a/kwin/effects/highlightwindow/highlightwindow.desktop +++ b/kwin/effects/highlightwindow/highlightwindow.desktop @@ -140,4 +140,3 @@ X-KDE-PluginInfo-Category=Appearance X-KDE-PluginInfo-Depends= X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-EnabledByDefault=true -X-KDE-Ordering=70 diff --git a/kwin/effects/kwineffect.desktop b/kwin/effects/kwineffect.desktop index 0434825b..df51cd56 100644 --- a/kwin/effects/kwineffect.desktop +++ b/kwin/effects/kwineffect.desktop @@ -85,6 +85,3 @@ Comment[wa]=Efet KWin Comment[x-test]=xxKWin Effectxx Comment[zh_CN]=KWin 效果 Comment[zh_TW]=KWin 效果 - -[PropertyDef::X-KDE-Ordering] -Type=int diff --git a/kwin/effects/logout/logout.desktop b/kwin/effects/logout/logout.desktop index 298f9cce..36ee0905 100644 --- a/kwin/effects/logout/logout.desktop +++ b/kwin/effects/logout/logout.desktop @@ -160,4 +160,3 @@ X-KDE-PluginInfo-Category=Appearance X-KDE-PluginInfo-Depends= X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-EnabledByDefault=true -X-KDE-Ordering=85 diff --git a/kwin/effects/minimizeanimation/minimizeanimation.desktop b/kwin/effects/minimizeanimation/minimizeanimation.desktop index 80516a24..0cf6bdc3 100644 --- a/kwin/effects/minimizeanimation/minimizeanimation.desktop +++ b/kwin/effects/minimizeanimation/minimizeanimation.desktop @@ -156,4 +156,3 @@ X-KDE-PluginInfo-Category=Appearance X-KDE-PluginInfo-Depends= X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-EnabledByDefault=true -X-KDE-Ordering=50 diff --git a/kwin/effects/presentwindows/presentwindows.desktop b/kwin/effects/presentwindows/presentwindows.desktop index c77a87c1..48ec37bb 100644 --- a/kwin/effects/presentwindows/presentwindows.desktop +++ b/kwin/effects/presentwindows/presentwindows.desktop @@ -155,4 +155,3 @@ X-KDE-PluginInfo-Category=Window Management X-KDE-PluginInfo-Depends= X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-EnabledByDefault=true -X-KDE-Ordering=70 diff --git a/kwin/effects/resize/resize.desktop b/kwin/effects/resize/resize.desktop index 9f3e3c26..ac570894 100644 --- a/kwin/effects/resize/resize.desktop +++ b/kwin/effects/resize/resize.desktop @@ -128,4 +128,3 @@ X-KDE-PluginInfo-Category=Window Management X-KDE-PluginInfo-Depends= X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-EnabledByDefault=false -X-KDE-Ordering=60 diff --git a/kwin/effects/slide/slide.desktop b/kwin/effects/slide/slide.desktop index faa063e4..0ba57762 100644 --- a/kwin/effects/slide/slide.desktop +++ b/kwin/effects/slide/slide.desktop @@ -144,4 +144,3 @@ X-KDE-PluginInfo-Category=Appearance X-KDE-PluginInfo-Depends= X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-EnabledByDefault=true -X-KDE-Ordering=50 diff --git a/kwin/effects/slideback/slideback.desktop b/kwin/effects/slideback/slideback.desktop index 173157a0..e574f7c8 100644 --- a/kwin/effects/slideback/slideback.desktop +++ b/kwin/effects/slideback/slideback.desktop @@ -115,4 +115,3 @@ X-KDE-PluginInfo-Category=Focus X-KDE-PluginInfo-Depends= X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-EnabledByDefault=false -X-KDE-Ordering=50 diff --git a/kwin/effects/slidingpopups/slidingpopups.desktop b/kwin/effects/slidingpopups/slidingpopups.desktop index ee10a799..d5c9a01d 100644 --- a/kwin/effects/slidingpopups/slidingpopups.desktop +++ b/kwin/effects/slidingpopups/slidingpopups.desktop @@ -134,4 +134,3 @@ X-KDE-PluginInfo-Category=Appearance X-KDE-PluginInfo-Depends= X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-EnabledByDefault=true -X-KDE-Ordering=40 diff --git a/kwin/effects/startupfeedback/startupfeedback.desktop b/kwin/effects/startupfeedback/startupfeedback.desktop index 0f033390..03735802 100644 --- a/kwin/effects/startupfeedback/startupfeedback.desktop +++ b/kwin/effects/startupfeedback/startupfeedback.desktop @@ -117,5 +117,3 @@ X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-Depends= X-KDE-PluginInfo-EnabledByDefault=true X-KDE-Library=kwin4_effect_builtins -X-KDE-Ordering=90 -X-KWin-Requires-OpenGL=true diff --git a/kwin/effects/taskbarthumbnail/taskbarthumbnail.desktop b/kwin/effects/taskbarthumbnail/taskbarthumbnail.desktop index 49b98f7e..1970ad37 100644 --- a/kwin/effects/taskbarthumbnail/taskbarthumbnail.desktop +++ b/kwin/effects/taskbarthumbnail/taskbarthumbnail.desktop @@ -154,4 +154,3 @@ X-KDE-PluginInfo-Category=Appearance X-KDE-PluginInfo-Depends= X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-EnabledByDefault=true -X-KDE-Ordering=70 diff --git a/kwin/effects/windowgeometry/windowgeometry.desktop b/kwin/effects/windowgeometry/windowgeometry.desktop index b1c0e68c..8ebef384 100644 --- a/kwin/effects/windowgeometry/windowgeometry.desktop +++ b/kwin/effects/windowgeometry/windowgeometry.desktop @@ -125,6 +125,3 @@ X-KDE-PluginInfo-License=GPL X-KDE-PluginInfo-Depends= # Whether this effect should be enabled by default X-KDE-PluginInfo-EnabledByDefault=false -# The plugin (library) which contains the effect. One library may contain more effects. -# The order in which this effect is loaded. Lower numbers are loaded first. -X-KDE-Ordering=90