Katana_mirror/kde-workspace
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kde-workspace.git synced 2025-02-23 10:22:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kurifilter-plugins: remove test case that relies on QTDIR environment variable

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2022-09-23 12:20:15 +03:00
parent 7a6eca5689
commit ce73514ea0
3 changed files with 1 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
kurifilter-plugins/shorturi/kshorturifilter.cpp
View file

@ -262,7 +262,7 @@ bool KShortUriFilter::filterUri( KUriFilterData& data ) const
if ( expanded || cmd.startsWith( '/' ) )
{
// Look for #ref again, after $ and ~ expansion (testcase: $QTDIR/doc/html/functions.html#s)
// Look for #ref again, after $ and ~ expansion
// Can't use KUrl here, setPath would escape it...
const int pos = path.indexOf('#');
if ( pos > -1 )

9
kurifilter-plugins/tests/kurifiltertest.cpp
View file

@ -154,7 +154,6 @@ static char s_delimiter = ':'; // the alternative is ' '
KUriFilterTest::KUriFilterTest()
{
minicliFilters << "kshorturifilter" << "kurisearchfilter" << "localdomainurifilter";
qtdir = getenv("QTDIR");
home = getenv("HOME");
kdehome = getenv("KDEHOME");
}
@ -326,11 +325,6 @@ void KUriFilterTest::environmentVariables()
filter( "$SOMEVAR/kdelibs/kio", 0, KUriFilterData::Error ); // note: this dir doesn't exist...
filter( "$ETC/passwd", "/etc/passwd", KUriFilterData::LocalFile );
QString qtdocPath(qtdir+"/doc/html/functions.html");
if (QFile::exists(qtdocPath)) {
QString expectedUrl = KUrl(qtdocPath).url()+"#s";
filter( "$QTDIR/doc/html/functions.html#s", expectedUrl.toUtf8(), KUriFilterData::LocalFile );
}
filter( "http://www.kde.org/$USER", "http://www.kde.org/$USER", KUriFilterData::NetProtocol ); // no expansion
filter( "$KDEHOME/share", QByteArray(kdehome+"/share"), KUriFilterData::LocalDir );
@ -358,9 +352,6 @@ void KUriFilterTest::environmentVariables()
filter( "$1/$2/$3", "https://www.google.com/search?q=%241%2F%242%2F%243&ie=UTF-8", KUriFilterData::NetProtocol ); // can be used as bogus or valid test. Currently triggers default search, i.e. google
filter( "$$$$", "https://www.google.com/search?q=%24%24%24%24&ie=UTF-8", KUriFilterData::NetProtocol ); // worst case scenarios.
if (!qtdir.isEmpty()) {
filter( "$QTDIR", qtdir, KUriFilterData::LocalDir, QStringList( "kshorturifilter" ) ); //use specific filter.
}
filter( "$HOME", home, KUriFilterData::LocalDir, QStringList( "kshorturifilter" ) ); //use specific filter.
}

1
kurifilter-plugins/tests/kurifiltertest.h
View file

@ -42,7 +42,6 @@ private slots:
private:
QStringList minicliFilters;
QByteArray qtdir;
QByteArray home;
QByteArray kdehome;