Katana_mirror/kde-workspace
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kde-workspace.git synced 2025-02-24 10:52:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kfirewall: do not generate duplicate rules for non-port rules

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2022-05-07 13:44:37 +03:00
parent 1e3d07c334
commit cb997a19f7
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
kfirewall/kcm/kfirewallhelper.cpp
View file

@ -27,6 +27,11 @@ static QByteArray ruleForSettings(const QByteArray &uservalue, const QByteArray
const QByteArray &addressvalue, const uint portvalue, const QByteArray &addressvalue, const uint portvalue,
const QByteArray &actionvalue, const bool appendrules, const bool tcprule) const QByteArray &actionvalue, const bool appendrules, const bool tcprule)
{ {
if (!tcprule && portvalue <= 0) {
// no port specified
return QByteArray();
}
QByteArray iptablesruledata; QByteArray iptablesruledata;
bool isinbound = false; bool isinbound = false;
QByteArray iptablestraffic = trafficvalue.toUpper(); QByteArray iptablestraffic = trafficvalue.toUpper();
@ -152,6 +157,8 @@ ActionReply KFirewallHelper::apply(const QVariantMap &parameters)
ActionReply KFirewallHelper::revert(const QVariantMap &parameters) ActionReply KFirewallHelper::revert(const QVariantMap &parameters)
{ {
//qDebug() << Q_FUNC_INFO << parameters;
if (parameters.isEmpty()) { if (parameters.isEmpty()) {
KAuth::ActionReply errorreply(KAuth::ActionReply::HelperError); KAuth::ActionReply errorreply(KAuth::ActionReply::HelperError);
errorreply.setErrorDescription("Empty rules"); errorreply.setErrorDescription("Empty rules");