From b6c58628a6de00f2eea19b6daae4910ac6408469 Mon Sep 17 00:00:00 2001
From: Ivailo Monev <xakepa10@gmail.com>
Date: Tue, 4 Jun 2024 05:36:34 +0300
Subject: [PATCH] kwin: use KEditListWidget as window classes editor in
 dimscreen effect KCM

more convenient than KLineEdit

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
---
 kwin/effects/dimscreen/dimscreen_config.ui    | 34 ++++++++-----------
 .../effects/presentwindows/presentwindows.cpp |  2 +-
 2 files changed, 15 insertions(+), 21 deletions(-)

diff --git a/kwin/effects/dimscreen/dimscreen_config.ui b/kwin/effects/dimscreen/dimscreen_config.ui
index 27202869..a59e0b2b 100644
--- a/kwin/effects/dimscreen/dimscreen_config.ui
+++ b/kwin/effects/dimscreen/dimscreen_config.ui
@@ -10,41 +10,35 @@
     <height>161</height>
    </rect>
   </property>
-  <layout class="QGridLayout" name="gridLayout">
-   <item row="0" column="0" colspan="1">
+  <layout class="QVBoxLayout" name="boxLayout">
+   <item>
     <widget class="QLabel" name="windowClassesLabel">
      <property name="text">
       <string>&amp;Window Classes:</string>
      </property>
+     <property name="alignment">
+      <set>Qt::AlignCenter</set>
+     </property>
      <property name="buddy">
       <cstring>kcfg_WindowClasses</cstring>
      </property>
     </widget>
    </item>
-   <item row="0" column="1" colspan="1">
-    <widget class="KLineEdit" name="kcfg_WindowClasses">
-     <property name="placeholderText">
-      <string>Apply effect to the win&amp;dow classes</string>
-     </property>
+   <item>
+    <widget class="KEditListWidget" name="kcfg_WindowClasses">
     </widget>
    </item>
-   <item row="1" column="0" colspan="2">
-    <spacer name="verticalSpacer">
-     <property name="orientation">
-      <enum>Qt::Vertical</enum>
-     </property>
-     <property name="sizeHint" stdset="0">
-      <size>
-       <width>20</width>
-       <height>0</height>
-      </size>
-     </property>
-    </spacer>
-   </item>
   </layout>
  </widget>
  <tabstops>
   <tabstop>kcfg_WindowClasses</tabstop>
  </tabstops>
+ <customwidgets>
+  <customwidget>
+   <class>KEditListWidget</class>
+   <extends>QWidget</extends>
+   <header>keditlistwidget.h</header>
+  </customwidget>
+ </customwidgets>
  <connections/>
 </ui>
diff --git a/kwin/effects/presentwindows/presentwindows.cpp b/kwin/effects/presentwindows/presentwindows.cpp
index 64026587..7a1d5f3d 100755
--- a/kwin/effects/presentwindows/presentwindows.cpp
+++ b/kwin/effects/presentwindows/presentwindows.cpp
@@ -732,7 +732,7 @@ void PresentWindowsEffect::grabbedKeyboardEvent(QKeyEvent *e)
             }
             break;
         case 0:
-            return; // HACK: Workaround for Qt bug on unbound keys (#178547)
+            return; // HACK: Workaround for unbound keys (#178547)
         default:
             if (!e->text().isEmpty()) {
                 m_windowFilter.append(e->text());