Katana_mirror/kde-workspace
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kde-workspace.git synced 2025-02-23 18:32:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kdirshare: do not open the file when sending response

Browse source 
KHTTP should send error response if opening the file fails

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2022-12-24 15:05:38 +02:00
parent c6d63798cf
commit 6e8b03eeb9
1 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
kdirshare/kded/kdirshareimpl.cpp
View file

@ -202,18 +202,10 @@ void KDirShareImpl::respond(const QByteArray &url, QByteArray *outdata,
outheaders->insert("Content-Type", "text/html; charset=UTF-8");
outdata->append(contentForDirectory(pathinfo.filePath(), m_directory));
} else if (pathinfo.isFile()) {
QFile pathfile(pathinfo.filePath());
if (!pathfile.open(QFile::ReadOnly)) {
kWarning() << "Could not open" << pathinfo.filePath() << pathfile.errorString();
outdata->append(s_data500);
*outhttpstatus = 500;
outheaders->insert("Content-Type", "text/html; charset=UTF-8");
} else {
const QString filemime = getFileMIME(pathinfo.filePath());
*outhttpstatus = 200;
outheaders->insert("Content-Type", QString::fromLatin1("%1; charset=UTF-8").arg(filemime).toAscii());
outfilepath->append(pathinfo.filePath());
};
const QString filemime = getFileMIME(pathinfo.filePath());
*outhttpstatus = 200;
outheaders->insert("Content-Type", QString::fromLatin1("%1; charset=UTF-8").arg(filemime).toAscii());
outfilepath->append(pathinfo.filePath());
} else {
outdata->append(s_data404);
*outhttpstatus = 404;