Katana_mirror/kde-workspace
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kde-workspace.git synced 2025-02-23 18:32:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kdirshare: fix pointer derefence on serve or publish error

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2022-05-11 03:17:02 +00:00
parent 85e1e8a8ea
commit 6ce6615bd6
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
kdirshare/kded/kded_kdirshare.cpp
View file

@ -97,13 +97,15 @@ QString KDirShareModule::share(const QString &dirpath, const uint portmin, const
}
// qDebug() << Q_FUNC_INFO << serverport;
if (!kdirshareimpl->serve(QHostAddress(QHostAddress::Any), portmin, portmax)) {
const QString serveerror = kdirshareimpl->errorString();
delete kdirshareimpl;
return i18n("Could not serve: %1", kdirshareimpl->errorString());
return i18n("Could not serve: %1", serveerror);
}
if (!kdirshareimpl->publish()) {
const QString publisherror = kdirshareimpl->publishError();
kdirshareimpl->stop();
delete kdirshareimpl;
return i18n("Could not publish service: %1", kdirshareimpl->publishError());
return i18n("Could not publish service: %1", publisherror);
}
m_dirshares.append(kdirshareimpl);
return QString();