Katana_mirror/kde-workspace
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kde-workspace.git synced 2025-02-23 18:32:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kcrash: use persistent notifications

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2023-08-04 00:42:34 +03:00
parent 522f9f2631
commit 686f99c9c3
2 changed files with 26 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
kcrash/kded/kded_kcrash.cpp
View file

@ -18,7 +18,6 @@
#include "kded_kcrash.h"
#include <kpluginfactory.h>
#include <knotification.h>
#include <kglobal.h>
#include <kstandarddirs.h>
#include <klocale.h>
@ -56,7 +55,15 @@ KCrashModule::KCrashModule(QObject *parent, const QList<QVariant> &args)
KCrashModule::~KCrashModule()
{
m_dirwatch->deleteLater();
delete m_dirwatch;
kDebug() << "Closing notifications" << m_notifications.size();
QMutableListIterator<KNotification*> iter(m_notifications);
while (iter.hasNext()) {
KNotification* knotification = iter.next();
disconnect(knotification, 0, this, 0);
knotification->close();
iter.remove();
}
}
void KCrashModule::slotDirty(const QString &path)
@ -94,11 +101,14 @@ void KCrashModule::slotDirty(const QString &path)
kcrashappname = kcrashdata["appname"].toString();
}
kDebug() << "Sending notification for" << kcrashfilepath;
KNotification* knotification = new KNotification("Crash");
// NOTE: when the notification is closed/deleted the actions become non-operational
KNotification* knotification = new KNotification("Crash", KNotification::Persistent, this);
knotification->setComponentData(KComponentData("kcrash"));
knotification->setTitle(i18n("%1 crashed", kcrashappname));
knotification->setText(i18n("For details about the crash look into the system log."));
knotification->setActions(QStringList() << i18n("Report"));
m_notifications.append(knotification);
connect(knotification, SIGNAL(closed()), this, SLOT(slotClosed()));
connect(knotification, SIGNAL(action1Activated()), this, SLOT(slotReport()));
knotification->sendEvent();
}
@ -116,8 +126,17 @@ void KCrashModule::slotDirty(const QString &path)
}
}
void KCrashModule::slotClosed()
{
KNotification* knotification = qobject_cast<KNotification*>(sender());
kDebug() << "Notification closed" << knotification;
m_notifications.removeAll(knotification);
}
void KCrashModule::slotReport()
{
KNotification* knotification = qobject_cast<KNotification*>(sender());
knotification->close();
const QString kcrashreporturl = KDE_BUG_REPORT_URL;
KToolInvocation::invokeBrowser(kcrashreporturl);
}

5
kcrash/kded/kded_kcrash.h
View file

@ -21,7 +21,8 @@
#include "kdedmodule.h"
#include <KDirWatch>
#include <kdirwatch.h>
#include <knotification.h>
class KCrashModule: public KDEDModule
{
@ -34,11 +35,13 @@ public:
private Q_SLOTS:
void slotDirty(const QString &path);
void slotClosed();
void slotReport();
private:
QString m_kcrashpath;
KDirWatch *m_dirwatch;
QList<KNotification*> m_notifications;
};
#endif // KCRASH_KDED_H