From 61d831381afc0e20fd26536699e52e215fce3a31 Mon Sep 17 00:00:00 2001
From: Ivailo Monev <xakepa10@gmail.com>
Date: Wed, 14 Dec 2022 19:35:41 +0200
Subject: [PATCH] knotify: image conversion optimization

QImage::scanLine() detaches the image, QImage::constScanLine() does not

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
---
 knotify/imageconverter.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/knotify/imageconverter.cpp b/knotify/imageconverter.cpp
index 5c6fa284..0f728a0d 100644
--- a/knotify/imageconverter.cpp
+++ b/knotify/imageconverter.cpp
@@ -64,7 +64,7 @@ QVariant variantForImage(const QImage &_image)
 {
 	qDBusRegisterMetaType<SpecImage>();
 
-	QImage image = _image.convertToFormat(QImage::Format_ARGB32);
+	const QImage image = _image.convertToFormat(QImage::Format_ARGB32);
 
 	int rowStride = image.width() * 4;
 
@@ -78,8 +78,8 @@ QVariant variantForImage(const QImage &_image)
 	data.resize(rowStride * image.height());
 	char* dst = data.data();
 	for (int y=0; y<image.height(); ++y) {
-		QRgb* src = (QRgb*)image.scanLine(y);
-		QRgb* end = src + image.width();
+		const QRgb* src = (const QRgb*)image.constScanLine(y);
+		const QRgb* end = src + image.width();
 		for (;src != end; ++src) {
 			// Probably slow, but free of endianess issues
 			*dst++ = qRed(*src);