Katana_mirror/kde-workspace
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kde-workspace.git synced 2025-02-23 18:32:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

dolphin: VersionControlObserver::searchPlugin() optimization

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2023-07-14 09:51:02 +03:00
parent 7370500b8b
commit 519a66a631
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
dolphin/src/views/versioncontrol/versioncontrolobserver.cpp
View file

@ -24,15 +24,20 @@
#include <KLocale>
#include <KService>
#include <KServiceTypeTrader>
#include <kde_file.h>
#include <kitemviews/kfileitemmodel.h>
#include <kversioncontrolplugin.h>
#include "updateitemstatesthread.h"
#include <QDir>
#include <QMutex>
#include <QTimer>
static bool kVersionDirExists(const QString &fileName)
{
KDE_struct_stat statbuff;
return (KDE::stat(fileName, &statbuff) == 0 && S_ISDIR(statbuff.st_mode));
}
VersionControlObserver::VersionControlObserver(QObject* parent) :
QObject(parent),
m_pendingItemStatesUpdate(false),
@ -287,7 +292,7 @@ KVersionControlPlugin* VersionControlObserver::searchPlugin(const KUrl& director
// like .svn, .git, ...
foreach (KVersionControlPlugin* plugin, plugins) {
const QString fileName = directory.path(KUrl::AddTrailingSlash) + plugin->fileName();
if (QFileInfo(fileName).exists()) {
if (kVersionDirExists(fileName)) {
// The score of this plugin is 0 (best), so we can just return this plugin,
// instead of going through the plugin scoring procedure, we can't find a better one ;)
return plugin;
@ -301,7 +306,7 @@ KVersionControlPlugin* VersionControlObserver::searchPlugin(const KUrl& director
int upUrlCounter = 1;
while ((upUrlCounter < bestScore) && (upUrl != dirUrl)) {
const QString fileName = dirUrl.path(KUrl::AddTrailingSlash) + plugin->fileName();
if (QDir(fileName).exists()) {
if (kVersionDirExists(fileName)) {
if (upUrlCounter < bestScore) {
bestPlugin = plugin;
bestScore = upUrlCounter;