From 34f08fca9eaa593e2155a21ee93ec77bcad641fb Mon Sep 17 00:00:00 2001
From: Ivailo Monev <xakepa10@gmail.com>
Date: Sat, 29 Oct 2022 04:45:32 +0300
Subject: [PATCH] dolphin: use QMutableSetIterator<T> for iteration in
 KFileItemModelRolesUpdater::updateChangedItems()

fixes possible crash

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
---
 dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp b/dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp
index fced7fb0..d19619d3 100644
--- a/dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp
+++ b/dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp
@@ -786,11 +786,13 @@ void KFileItemModelRolesUpdater::updateChangedItems()
     QList<int> visibleChangedIndexes;
     QList<int> invisibleChangedIndexes;
 
-    foreach (const KFileItem& item, m_changedItems) {
+    QMutableSetIterator<KFileItem> changedItemsIter(m_changedItems);
+    while (changedItemsIter.hasNext()) {
+        const KFileItem& item = changedItemsIter.next();
         const int index = m_model->index(item);
 
         if (index < 0) {
-            m_changedItems.remove(item);
+            changedItemsIter.remove();
             continue;
         }