From 1b116dbc2e237b74abce72b86c42dc9010e31332 Mon Sep 17 00:00:00 2001
From: Ivailo Monev <xakepa10@gmail.com>
Date: Fri, 1 Sep 2023 19:07:10 +0300
Subject: [PATCH] kdirshare: do not percentage-encode the file links

if only there was a way to tell browsers:
Hey, browser! Don't decode the URL - you don't know where it points to!

for reference:
https://ibb.co/cyhwppK

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
---
 kdirshare/kded/kdirshareimpl.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kdirshare/kded/kdirshareimpl.cpp b/kdirshare/kded/kdirshareimpl.cpp
index b5482359..b594492b 100644
--- a/kdirshare/kded/kdirshareimpl.cpp
+++ b/kdirshare/kded/kdirshareimpl.cpp
@@ -170,7 +170,9 @@ static QByteArray contentForFile(const QString &basedir, const QFileInfo &filein
     }
 
     data.append("        <td><a href=\"");
-    data.append(QUrl::toPercentEncoding(cleanpath));
+    // NOTE: browsers produce bogus URLs for mixed (non-percentage and percentage-encoded) paths,
+    // also browsers decode percentage URLs and pass it back which for local files may be invalid
+    data.append(cleanpath.toUtf8());
     data.append("\">");
     data.append(fileinfo.fileName().toUtf8());
     data.append("</a></td>\n");