From 12b862ccf5fdd35b325171e664d22a185d4df6ad Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Tue, 4 Jun 2024 05:00:32 +0300 Subject: [PATCH] dolphin: different take on overlays still the version plugin overlays are not a thing outside the view of dolphin Signed-off-by: Ivailo Monev --- .../kitemviews/kfileitemmodelrolesupdater.cpp | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp b/dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp index 6a10bc03..3f048a5b 100644 --- a/dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp +++ b/dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp @@ -426,20 +426,7 @@ void KFileItemModelRolesUpdater::slotGotPreview(const KFileItem& item, const QPi QHash data = rolesData(item); - const QStringList overlays = data["iconOverlays"].toStringList(); - // Strangely KFileItem::overlays() returns empty string-values, so - // we need to check first whether an overlay must be drawn at all. - // It is more efficient to do it here, as KIconLoader::drawOverlays() - // assumes that an overlay will be drawn and has some additional - // setup time. - foreach (const QString& overlay, overlays) { - if (!overlay.isEmpty()) { - // There is at least one overlay, draw all overlays above m_pixmap - // and cancel the check - KIconLoader::global()->drawOverlays(overlays, scaledPixmap, KIconLoader::Desktop); - break; - } - } + // TODO: version plugin (KVersionControlPlugin) overlays data.insert("iconPixmap", scaledPixmap); @@ -912,6 +899,8 @@ QHash KFileItemModelRolesUpdater::rolesData(const KFileIte data.insert("type", item.mimeComment()); } + data.insert("iconOverlays", item.overlays()); + return data; }