Katana_mirror/kde-playground
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kde-playground.git synced 2025-02-24 02:42:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

karchivemanager: add TODOs

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2021-04-01 17:04:45 +03:00
parent 873b81e661
commit 606e0d4de7
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
karchivemanager/CMakeLists.txt
View file

@ -8,16 +8,18 @@ if(${CMAKE_SOURCE_DIR} STREQUAL ${CMAKE_CURRENT_SOURCE_DIR})
endif() endif()
set(karchivemanager_sources set(karchivemanager_sources
strmode.c
karchiveapp.cpp karchiveapp.cpp
karchivemanager.cpp karchivemanager.cpp
main.cpp main.cpp
# TODO: only if system does not have strmode()
strmode.c
) )
add_executable(karchivemanager ${karchivemanager_sources}) add_executable(karchivemanager ${karchivemanager_sources})
target_link_libraries(karchivemanager target_link_libraries(karchivemanager
${KDE4_KDEUI_LIBS} ${KDE4_KDEUI_LIBS}
${KDE4_KFILE_LIBS} ${KDE4_KFILE_LIBS}
# TODO: lookup via find_package()
z z
bz2 bz2
archive archive

8
karchivemanager/karchivemanager.cpp
View file

@ -389,8 +389,8 @@ bool KArchiveManagerPrivate::closeWrite(struct archive* m_archive) {
} }
bool KArchiveManagerPrivate::copyData(struct archive* aread, struct archive* awrite) { bool KArchiveManagerPrivate::copyData(struct archive* aread, struct archive* awrite) {
char buffer[KARCHIVEMANAGER_BUFFSIZE]; char readbuffer[KARCHIVEMANAGER_BUFFSIZE];
ssize_t readsize = archive_read_data(aread, buffer, sizeof(buffer)); ssize_t readsize = archive_read_data(aread, readbuffer, sizeof(readbuffer));
while (readsize > 0) { while (readsize > 0) {
const int result = archive_errno(aread); const int result = archive_errno(aread);
if (result != ARCHIVE_OK) { if (result != ARCHIVE_OK) {
@ -398,12 +398,12 @@ bool KArchiveManagerPrivate::copyData(struct archive* aread, struct archive* awr
return false; return false;
} }
if (archive_write_data(awrite, buffer, readsize) != readsize) { if (archive_write_data(awrite, readbuffer, readsize) != readsize) {
kWarning() << "archive_write_data" << archive_error_string(awrite); kWarning() << "archive_write_data" << archive_error_string(awrite);
return false; return false;
} }
readsize = archive_read_data(aread, buffer, sizeof(buffer)); readsize = archive_read_data(aread, readbuffer, sizeof(readbuffer));
} }
return true; return true;